From nobody Thu Nov 19 16:24:41 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jVkMG03Rzz71Mgc for ; Thu, 19 Nov 2026 16:24:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jVkMF36QPz4CWk for ; Thu, 19 Nov 2026 16:24:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795105481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VyS+CkJJEohqkyI7mty67hSfC0H7qRNuNpz/nXIN74g=; b=gsmujlFIN3rKtw1PLYV4+thXq1ZvN1HKJoSA5aWZiVliDAi04lpaZbm5jkS4Pxq0ehk490 4gUgHePGa841+nkrlDh5QTewZkIZ1oqaG2haHmXaFQ9Z6JfmVQEMQwTX8PbxcOAcoxyL9z JTlMQdNUQS3BYdPmw3f9eEylqfGdr21tpDn3R9FQfKRYhRw+mfxzSqz0QJNsCu8wY9uxRp 3qgvT+N8H0uGVFt76K7RM+3oj14tGn83rrSEb4dHTobIIWvEOWD9bsFRSU6rWl8CVamrXC e6DEV843dDN1BU0R9Ccl9dl3BPryyz5iuAusS9osNUajKaQzIJtJNgHCkx2vHw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795105481; b=OLU0MPW/KGrMkKfyNq7KRcktQ0sbHTdQIfMgmDCUO+yk5fs5Jt2YId6blOGXuaZNSD8KUc oiu8oVNdRkBohRjS8lKHubiSutRimLYC0JS24aircttxuTnSByhUO9vHhsAPN3bXL3+m/W tFf7/FnbMJTw0+D7SBOTHRXW5KWxzd7X95pC+xtecNBCzgcB8Juny7Eig52CuPbNbkkj1j 7CNt3GrCGVWR+LoyWKKEFeS8ktH8nSGX++MIH3dLm35Jw6MAriRI+7A77eR46ApJja3lL7 TMaJrSubOQFDVRAxRO8tCDcY5tu4TNMf2OJLTIAKu22FMPIqeXgsRhXwaUGEag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795105481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VyS+CkJJEohqkyI7mty67hSfC0H7qRNuNpz/nXIN74g=; b=sRB7ToNXzzOj4z9qYKNjFniqoq6KMOjzL0jw4kKKgl60M6/2QzjuPIW+GAC/vAL+Z3wmyA u9riY7hW3QlGx49VcMj+LNCa6j+evLjAslqiEJd9qRta2MhLi92M8CldvDnLn2STqOZVpv azn5Qi71s0DY7IMWAdxLjzEFJB9IaufFfSD2cC8RCPtXXuFtEIhIk/TWuQGnd7W9uMRIFe gK9R5TncY0NSUjkEzlMslOWakrEnmgWq9uZWUtuvOsEPEHKtoGZyW0vVSE6I3EJ9EjFJhR C/R3doXKbVuCh4EvU2FXYYuxsBgxR8NSWzrCcdP3BJLoA1HyWgdh/DojYwB2Ig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jVkMF2WY9z17WZ for ; Thu, 19 Nov 2026 16:24:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 11dc9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 19 Nov 2026 16:24:41 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ryan Libby Subject: git: 670bad029bb9 - main - pause fail point: affirm sleeping without a lock List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rlibby X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 670bad029bb9bcb3d522f6a16b9d8693b4c67f81 Auto-Submitted: auto-generated Date: Thu, 19 Nov 2026 16:24:41 +0000 Message-Id: <6aff22c9.11dc9.2930219@gitrepo.freebsd.org> The branch main has been updated by rlibby: URL: https://cgit.FreeBSD.org/src/commit/?id=670bad029bb9bcb3d522f6a16b9d8693b4c67f81 commit 670bad029bb9bcb3d522f6a16b9d8693b4c67f81 Author: Ryan Libby AuthorDate: 2026-11-19 16:13:17 +0000 Commit: Ryan Libby CommitDate: 2026-11-19 16:13:17 +0000 pause fail point: affirm sleeping without a lock The previous patch to fail_point_pause removed a lock wrapping a sleep. INVARIANTS assertions require we affirm we are deliberately sleeping without a lock or timeout via the PNOLOCK flag. Reported by: netchild Reviewed by: netchild Fixes: 331613ddd8a5 ("Pause failpoint: replace mtx_sleep with tsleep") Differential Revision: https://reviews.freebsd.org/D61730 --- sys/kern/kern_fail.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/kern_fail.c b/sys/kern/kern_fail.c index 40b02040a504..8932cdec66d0 100644 --- a/sys/kern/kern_fail.c +++ b/sys/kern/kern_fail.c @@ -411,7 +411,7 @@ fail_point_pause(struct fail_point *fp, enum fail_point_return_code *pret) if (fp->fp_pre_sleep_fn) fp->fp_pre_sleep_fn(fp->fp_pre_sleep_arg); - tsleep(FP_PAUSE_CHANNEL(fp), 0, "failpt", 0); + tsleep(FP_PAUSE_CHANNEL(fp), PNOLOCK, "failpt", 0); if (fp->fp_post_sleep_fn) fp->fp_post_sleep_fn(fp->fp_post_sleep_arg);