From nobody Thu Nov 19 16:06:49 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jVjyf3VpNz71KL0 for ; Thu, 19 Nov 2026 16:06:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jVjyd5dxKz3PV1 for ; Thu, 19 Nov 2026 16:06:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795104409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DxJ7NaO+NpR4wlRr29/5LTj+GIz0qoTeZPDSFRbv6ec=; b=DhzN4DfwoMvPG/75to8IQ9HZbrvWToG0FqYFnIGx0zu3sVEo/4m5HF4qkNG6h7j8HwiBHO 8/I39JSNshdq9mjxIuufJdo4AH2orR9GEdJy5pvTUTXDDLMpJyzUYz1H3ZqhmeK2rbZ0tK pMVpf060S3Tk4yIn1SnGYG01xvOedDISZHfjd3kCIxd7TE7tdnmvcg4kuduZDoqm3wHZCV 5wlINVXueo5CTD1D2zBKDmjHjRfcgLt8OcrS53dJXWjV37v39uJDdD4409XpeRPmavlo6M ntC+x8yhVO2Oerp+LFzvBftxQFiRmOadYbUSplHWLYqtTmRS6fsKmwPY7hVY8g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795104409; b=pJKSkKFa+lVwcPbI+vzSiPMsQu6LeIqRBuDqv4dctGwCsLtT5OBeQ+li5eOW5Ps7w4y6w1 auB6HIbGu39E7sSVCiNbvTBF+pAmisf3VYmSvLHdcQ+976+9wUTu5em1ODBoylTuJNYk1l Id8QSF9V1hu2iNhfogFGhDverrKo8xYiM8MreXBu3LrTfZGKNsd9Wxg5Z3HDR39E3Ig/q0 pCuW+/ypjrU2tZmCqi4R+IsNxXVX12BtNkxqIE/VAdbdF58n4SUMafc3iacuIbIZzsFoE7 DrlCel/9FoL6Tp/qh2pX7WEtsoo42ir3WGI+e1RnJqHCEFPgEfrg0Z93O2aA2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795104409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DxJ7NaO+NpR4wlRr29/5LTj+GIz0qoTeZPDSFRbv6ec=; b=jX4C9ayW3M+WxeZ/2yN3UVrna8rZmve6RohNnq3LykCnk+l3BjfAAdx7F54YW2w+9N2JdU pHtT28Uv+XjbD8hlRR+LZTgEEcGBqlHyexcH0eaZei11O5pWFiZlVmb7zcvkxlnubosEDX i47rql3ZMwEAsqafrJn5WFtqwpaEPJe3wgsbBFmfSN66v3qMpANxwwFKLMIOnzEk8CT78n uor6KPbyI6mDA2igh8J76TyEbSeiyl8wsLXvxU64WQc6VCUQU0gY/W9VPLKwfYIpHteZNE VjZ7uz3Tht1iT7q1lDG+1sSUNbrU3vWfI7fbNc+rPVcktVrEAdY57B9kM8XoGQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jVjyd5JFPz16rS for ; Thu, 19 Nov 2026 16:06:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id ebe3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 19 Nov 2026 16:06:49 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: a00d93c4caef - stable/14 - acpi_pci_link: Ignore tunables with negative values List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a00d93c4caefd2464036aca1c5224c4792e765d3 Auto-Submitted: auto-generated Date: Thu, 19 Nov 2026 16:06:49 +0000 Message-Id: <6aff1e99.ebe3.af8c3e4@gitrepo.freebsd.org> The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=a00d93c4caefd2464036aca1c5224c4792e765d3 commit a00d93c4caefd2464036aca1c5224c4792e765d3 Author: John Baldwin AuthorDate: 2026-11-14 16:02:38 +0000 Commit: John Baldwin CommitDate: 2026-11-19 15:01:25 +0000 acpi_pci_link: Ignore tunables with negative values IRQ values are unsigned and negative values do not make sense. The invalid IRQ value (255) is already ignored, so ignoring other invalid values is consistent with that behavior. Reported by: cperciva (cherry picked from commit 81dab94a5452f996a063bdba2103eda4aa32b3d1) --- sys/dev/acpica/acpi_pci_link.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/dev/acpica/acpi_pci_link.c b/sys/dev/acpica/acpi_pci_link.c index d9807876c443..cb6adee87252 100644 --- a/sys/dev/acpica/acpi_pci_link.c +++ b/sys/dev/acpica/acpi_pci_link.c @@ -974,7 +974,8 @@ acpi_pci_link_choose_irq(device_t dev, struct link *link) sizeof(link_name)))) { snprintf(tunable_buffer, sizeof(tunable_buffer), "hw.pci.link.%s.%d.irq", link_name, link->l_res_index); - if (getenv_int(tunable_buffer, &i) && PCI_INTERRUPT_VALID(i)) { + if (getenv_int(tunable_buffer, &i) && i >= 0 && + PCI_INTERRUPT_VALID(i)) { if (!link_valid_irq(link, i)) device_printf(dev, "Warning, IRQ %d is not listed as valid\n", @@ -983,7 +984,8 @@ acpi_pci_link_choose_irq(device_t dev, struct link *link) } snprintf(tunable_buffer, sizeof(tunable_buffer), "hw.pci.link.%s.irq", link_name); - if (getenv_int(tunable_buffer, &i) && PCI_INTERRUPT_VALID(i)) { + if (getenv_int(tunable_buffer, &i) && i >= 0 && + PCI_INTERRUPT_VALID(i)) { if (!link_valid_irq(link, i)) device_printf(dev, "Warning, IRQ %d is not listed as valid\n",