From nobody Thu Nov 19 16:05:01 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jVjwZ2gtGz71KHK for ; Thu, 19 Nov 2026 16:05:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jVjwY6PWYz3MG1 for ; Thu, 19 Nov 2026 16:05:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795104301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ExvSqft92jk3OtnwPQvBM7HuMiljrGmebCK5npAPiY0=; b=y3S4i+RLxVZB/Tk40hVr8/fcoFYfME/27uRZI8WyAkZhX1hpTBlsQ+sE4HVdYm62UJmGhG hpCVd3LTmsfEXaeYHnlKvjFS7LJ1UbQDI7UQh3/TXAub3CfD/eZdN1qySHHm9ibAkE2nQJ cUJraX7oL11kU68bYW3r72URULC7lf9eg72Dt2i0EfZ0iEE83ucJ3a+VaTIdReRiRP6W8s 9t2QzfPA/4+eczjWhDA3Nvlw6tJLrpdC5+3BQh6vrIOysTXw8HALBu6HJvkvVmCiA82K7S cg3Ax8VokTilZgMCauzJ6xdV5dhQlDb8jNNQtjkuub5T5M0rPfR9YE4ssLv4Wg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795104301; b=EzZ5XlgCaFlX3QPyLverHIMwE3rwQVDweKTg5QZuhL0jrtlwOjRhK0mDXjUGZraL0WGPt2 fGLCpL6C33BIAxqcvC29kjDYqD14VMGf3grHIOY0fAb3He7LfyZ8MFCjxHhKCkXw82yLPG Esgm5T9FaRFC2Eb1mQG8dnkUvZPswz7XnFdndJxQb2Y6eTNE6tTa31I2tC3NUClFYQU/rF LrVJtW/6OABoAnbBi8eR1rkqV69PnjPQ7skr1zuJ8PasLvS9OKdRw8nFrR5sjWx+d2O3Kp T8vniMFzbN/DWw12cBI/h18VklSU2y1RnPHU9ztNNlu8sgQZdrePabOaVLaglw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795104301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ExvSqft92jk3OtnwPQvBM7HuMiljrGmebCK5npAPiY0=; b=nLpFiF9n7CHAlvEOVZ5oAkscysjmXTVjv//KJejNmaiTzx3coB2ORaT+OFIpqZKB/0RYJW AYqsbNAe1PF1DQp4U7/69IvmTP7f4MYtZuYZ/PYSMOCfhtE6rYIx2TTQ7ufo7qYmyKSjwk 4Kvg8QBmEJTcwf5AsXKbqDN6yxwTljrlIRBrXbVYkeLSHsi+npdv1TMwHdESdTWkkewMKD UlU6KuCkoytUJVV70d35pFmmpHFiy1i5PGnvE7b8Ybd1MtqAl4bSsL6E7I6uJNgVUx0REU 5l1vmKvm03ValrFCxf8KtivRyyUWw3lP07U9sbb1YVN+Nxgp/HeHK7CAIiS59w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jVjwY60NHz16sT for ; Thu, 19 Nov 2026 16:05:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id fd91 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 19 Nov 2026 16:05:01 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: John Baldwin From: Colin Percival Subject: git: 0421a245da67 - releng/15.2 - acpi_pci_link: Ignore tunables with negative values List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.2 X-Git-Reftype: branch X-Git-Commit: 0421a245da67838bc6a11ffbdd359d06806d9c62 Auto-Submitted: auto-generated Date: Thu, 19 Nov 2026 16:05:01 +0000 Message-Id: <6aff1e2d.fd91.414d320b@gitrepo.freebsd.org> The branch releng/15.2 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=0421a245da67838bc6a11ffbdd359d06806d9c62 commit 0421a245da67838bc6a11ffbdd359d06806d9c62 Author: John Baldwin AuthorDate: 2026-11-14 16:02:38 +0000 Commit: Colin Percival CommitDate: 2026-11-19 16:04:36 +0000 acpi_pci_link: Ignore tunables with negative values IRQ values are unsigned and negative values do not make sense. The invalid IRQ value (255) is already ignored, so ignoring other invalid values is consistent with that behavior. Approved by: re (cperciva) Reported by: cperciva (cherry picked from commit 81dab94a5452f996a063bdba2103eda4aa32b3d1) (cherry picked from commit 1b71cb09074be51a87a2eb84acb46ee77fceec45) --- sys/dev/acpica/acpi_pci_link.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/dev/acpica/acpi_pci_link.c b/sys/dev/acpica/acpi_pci_link.c index d9807876c443..cb6adee87252 100644 --- a/sys/dev/acpica/acpi_pci_link.c +++ b/sys/dev/acpica/acpi_pci_link.c @@ -974,7 +974,8 @@ acpi_pci_link_choose_irq(device_t dev, struct link *link) sizeof(link_name)))) { snprintf(tunable_buffer, sizeof(tunable_buffer), "hw.pci.link.%s.%d.irq", link_name, link->l_res_index); - if (getenv_int(tunable_buffer, &i) && PCI_INTERRUPT_VALID(i)) { + if (getenv_int(tunable_buffer, &i) && i >= 0 && + PCI_INTERRUPT_VALID(i)) { if (!link_valid_irq(link, i)) device_printf(dev, "Warning, IRQ %d is not listed as valid\n", @@ -983,7 +984,8 @@ acpi_pci_link_choose_irq(device_t dev, struct link *link) } snprintf(tunable_buffer, sizeof(tunable_buffer), "hw.pci.link.%s.irq", link_name); - if (getenv_int(tunable_buffer, &i) && PCI_INTERRUPT_VALID(i)) { + if (getenv_int(tunable_buffer, &i) && i >= 0 && + PCI_INTERRUPT_VALID(i)) { if (!link_valid_irq(link, i)) device_printf(dev, "Warning, IRQ %d is not listed as valid\n",