From nobody Thu Nov 19 15:42:41 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jVjQn6qKvz71GJv for ; Thu, 19 Nov 2026 15:42:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jVjQn3xr2z3C0w for ; Thu, 19 Nov 2026 15:42:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795102961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XQoOH/t9SB3ZJ6sUrnyPC2KgVniVCvAJKWye/tuZ1lg=; b=eZJ+T10RrGGFKlkVW8vpH5cveq1A5r26MeRXQ/wY+am+wKNs+6z5vcAsonCmFApbVuWexX 0/tQ54aAbSHWEX6kG7kOE1ImCVeWPAj5LSC1Zhm/s4+LBWzADGR/vkI4/2p2iofsw5MAkD j8XU+km4R7CTbyfBWQNwYs1J2O7vAwfRwQn3ss6NN84aRrDpX69Q3/OTuXeYRt8DQJP7kR qVbU6rby6gUAhO2kodUWUhLHsKos8ZGjOY/gMYbYQgwzqklUNrpPFg4u5utUYDsiasUbAD 5gT1UoYnaIznnCUjdOHvWjvOsoLOozEelutfF85pBySr5YOqdrM2Ph4JYaAfNg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795102961; b=S2/tEASyjdxwDfBsK5bSe/aaH1zRK7qnclHPEPjwK9qa1axKREdWW3P3m2TQTTXxgw0QyI 6IAY+9iepIgVNE8qBM4phaDfeBNLGTqIlD0GWF/2kVf0pHNx5dO7DjBgM0RTukBhM8QhjB NHgosPm1F+v9nxHTXdM79qP+2+BmnXDYZCQbaJHQmnMx5j1grSD3NPf3SxdT7CKp/ZOF/z 7jTfw1V797TzHC0mHwrFrq1hGM06Y+V8AzZFdxLuhzvfU1Wdx48J3r/n/2bi+3P9tmQGp+ y7Y1nD25wLKwTiGQbzd2G0Q4Nkw7Vz7LT3Zz4b/GJhtApORorCRWUrNAmzOrIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795102961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XQoOH/t9SB3ZJ6sUrnyPC2KgVniVCvAJKWye/tuZ1lg=; b=VaTEJFkSQWs61+fNawQB/NyyXNvjSu+lCW+jGR7gIfeXfiy0hsVFliXJSHoOqdXJNxBv4r RNn8W/pltHaUe+RSc+vPnrJtrx37WYSj3dgA++CuBlF87R6rtPE1Zxwn8ovea2iLpBFPc3 UXMvrl/nSuX+Nxk/QhEUg2cdpIhtGDtjAcqMv+iCmcWqWWkwq6QfM6Zgiii24hmUWTOClL eKDLa5qab4oya7ODvCTKgo7nNiWkwLwIgsAuzWQFtij71Gfvm6VlV8TQz37VTfKVSgYIe9 9bnMi+q1qaIzUPN+wsD1/LT7B5Z97uKKuh1zRDGBYMYPjuQ99CXiQ86/J0GK4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jVjQn3cc0z16Fh for ; Thu, 19 Nov 2026 15:42:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id dcf1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 19 Nov 2026 15:42:41 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 469ac5a9c05f - stable/15 - ctld: Fix namespace IDs for exported NVMe namespaces part 2 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 469ac5a9c05f21526f81cb34833bfff53b07a7d5 Auto-Submitted: auto-generated Date: Thu, 19 Nov 2026 15:42:41 +0000 Message-Id: <6aff18f1.dcf1.15a8ecc0@gitrepo.freebsd.org> The branch stable/15 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=469ac5a9c05f21526f81cb34833bfff53b07a7d5 commit 469ac5a9c05f21526f81cb34833bfff53b07a7d5 Author: John Baldwin AuthorDate: 2026-11-12 15:43:55 +0000 Commit: John Baldwin CommitDate: 2026-11-19 15:42:20 +0000 ctld: Fix namespace IDs for exported NVMe namespaces part 2 This is the same fix as in commit 9c8be6518e2e5f396055ecdab8098ce19c4b2218 just applied to another method that also accepts namespace IDs. The original commit handled configuration statements assigning a named LUN to a namespace. This change handles anonymous namespaces configured within a controller context. Fixes: 66b5296f1b29 ("ctld: Add support for NVMe over Fabrics") Sponsored by: Chelsio Communications (cherry picked from commit 9a99fa3932ddd794234becc6eab6519d56ae6947) --- usr.sbin/ctld/nvmf.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/ctld/nvmf.cc b/usr.sbin/ctld/nvmf.cc index a596d32d660c..689c3404af1a 100644 --- a/usr.sbin/ctld/nvmf.cc +++ b/usr.sbin/ctld/nvmf.cc @@ -413,9 +413,9 @@ nvmf_controller::start_namespace(u_int id) return nullptr; } - std::string lun_label = "namespace ID " + std::to_string(id - 1); + std::string lun_label = "namespace ID " + std::to_string(id); std::string lun_name = freebsd::stringf("%s,nsid,%u", name(), id); - return target::start_lun(id, lun_label.c_str(), lun_name.c_str()); + return target::start_lun(id - 1, lun_label.c_str(), lun_name.c_str()); } struct portal_group *