From nobody Thu Nov 19 10:39:17 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jVZhv3nrYz72LwY; Thu, 19 Nov 2026 10:39:27 +0000 (UTC) (envelope-from olce@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jVZhv3G2qz3CfY; Thu, 19 Nov 2026 10:39:27 +0000 (UTC) (envelope-from olce@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795084767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=17Fbk0X8gW2k6BX2neLn7PGLk2fdEjRb+E/fn/lEN1o=; b=rCyc1PRcFYZY3nxKkaJi0jJpmrbZc3c+PuJ06b43piUwb6GtWjZ1cmxcHivAgrGgB3VyV/ 9XTrKEhV3ORDqhvSSiHEilLJZPEMDWalAmPhk/Ywu28gEtiUVzQoI8jyF1I9r5fBYi9CAQ cuS27z6sqA7W4e3fHa37/fDwacPmxrVIcxkFUjQDpUE29MydL7KR/tiQBGn+gj16f6vzly WQhXzJv1QkEUl+wc6R6Cw5CiE6scNsqqQDQS4LYj/JohUV5mBWvguIEoDCYySUSsAWmjd/ /y0xKgja2GaFN9SrajRzBa4s8C+VP1YAYcpxfcssgm3PVwjO4BlnLg9UnyB7xA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795084767; b=uDY5fAcqHGmyxmhRvYZhzklWnXLIhqZXE/l1i+LhSsSFJQCF+IqaUOtgblpO3lUDaGtkdM 5/03cpnXa76NzGjlmmlQgqRQePU9C4XtT5eXrsJt/r950PjWerJwav5TKHsBsnGC5Hkgq4 AcapL6xLMZe3qdFaoq3ApC0VwARMwXjsNMkLKlrMXhg1uI4PvyKoJAei37u4fBWjT8KnTo eRXJyMMzlVp9wQN3ECpb+hlhHztSXzYvP8DSQ8l9FNOi7diLaZ3Sj+5FDQRDf4yzXYUJZ+ D1jmbwIznZBc4i0jlYYPFPr/Gy21+Ofu6mipmBIC6wE9onAdx9TZCoibkXKaeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795084767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=17Fbk0X8gW2k6BX2neLn7PGLk2fdEjRb+E/fn/lEN1o=; b=Z2rwrFjRAGF1SG4Bb5qQvUyJ4V6n2Vp/rjlYuZO+v64+tct+7Q/je7pBcCQ/z6i0UK94xI EsJ2XgQOwHl/JUiPpZDY8LmJIGM+zpRG3sqCeAD2T/b66PFDL1VAg9YLtUEyua6liDqUAg YTCZVcZPuK6AaK3tjOFbI/yGYqrP1lAoFe2gzwUo7KDAuyMXczzKQeDAiYvEjlh/4kjATQ 9VdKw4xNwY+e256w1Q2gruxpZNXeZCHjlWLDrxJJisd63wAb6upSuDKl26lacQEZo18ByO rQUMuJeZ8XBr7f/+GpnnJAM/k/bsI8AlAbsvJ92ONoZvpHEcQ0tM1HKdsbel7A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from ravel.localnet (lfbn-nic-1-328-19.w90-116.abo.wanadoo.fr [90.116.162.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: olce/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4jVZht2QYsz1P82; Thu, 19 Nov 2026 10:39:26 +0000 (UTC) (envelope-from olce@freebsd.org) From: Olivier Certner To: John Baldwin , Brooks Davis Cc: Konstantin Belousov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 3a1f5a28f007 - main - proc.h: Order thread_lock*() functions more logically Date: Thu, 19 Nov 2026 11:39:17 +0100 Message-ID: <3219646.hHqAuc6tWs@ravel> In-Reply-To: References: <6af88c7a.1655d.45212520@gitrepo.freebsd.org> <15663fe6-a938-489a-9c9d-c9514c8b6781@FreeBSD.org> List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2560153.THHZn3L5Ee"; micalg="pgp-sha384"; protocol="application/pgp-signature" --nextPart2560153.THHZn3L5Ee Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Olivier Certner To: John Baldwin , Brooks Davis Date: Thu, 19 Nov 2026 11:39:17 +0100 Message-ID: <3219646.hHqAuc6tWs@ravel> In-Reply-To: MIME-Version: 1.0 > > I sort them alphabetically, but may use separate groups instead of > > one giant group if there are comments for the groups. > > IMO the important thing is that it's entierly clear where to put the > next thing. The easiest way to do that is to sort things. I'm exactly in line with this. > I highly recommmend blank lines or comments to break the groups up. Doing that, and also a bit more to regroup thread-lock-related functions into . Please see https://reviews.freebsd.org/D61748. -- Olivier Certner --nextPart2560153.THHZn3L5Ee Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmr+0dUACgkQjKEwQJce JidtIw//Qkq+lFqx+4OsXm8CL1xgC4EXixAketeI6fuHCYYHRAEVphspBqPqWuTQ oP6UJkxgqi/HT6KsYnR0NkhVUClyMiCGhvwabmZYR1yHE/epPzB6DMAC//eJqtmm HuElka32MWhTngw7a7m0ghLh+dWGcA4qX8wSxGa5jIdU/4LfY2ZSubKZLaIp4Jjc SyLrc4z5O1keDRo2FrvI4Bxra5L2Cj59UuX4b0zaDWrEVcINSUhc0beU2GEJRN59 AM9FRhqelYCJulxoUM74rOaZuPXpWTwwEwMvHKeonlGoLQB1ePZByjVHb1nHmLPL oDueevpU19f7dVOyKr3XH/N92mMWSXb+w34HEjdGQO51Rw5erQ92g8mMPguZConh fbjseL1XCg7j5B8+q3Jogrjn0tfSiDYGm9egZvTGLuHHg4otcOWZ7hwAZBrBO+jj f6mYZUHXkB+f4QhvhGfsJAzywF2h3moeroBta9JOhJPfqReSjvT0x5039/WgRPJg cwEo/MCLf1KlkweRokj1q2SUnRr7AqaUqWIk4zgTrMMkY+h4fZwE1gLqt2ORPLwC fFlc4HJOwUgwOchGY3RegCBJDZrqGL3vS7SRr2EubOaYTEqHyDUWJ32H+0eYk49c 5KaNTW0C56vqrPCnFHkvuDa3LimLVFWX+DEMidmL7QmYtPq77+E= =Nyz9 -----END PGP SIGNATURE----- --nextPart2560153.THHZn3L5Ee--