From nobody Wed Nov 18 19:24:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jVBPj22s1z715y5 for ; Wed, 18 Nov 2026 19:24:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jVBPj1FjTz3FC7 for ; Wed, 18 Nov 2026 19:24:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795029897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GAsjNejDhefZvTfHIrQKx9kfU/m2zlE3rTMWD2ZsAyU=; b=kziPXWDCPQop709/bSQxbv/fvD593C43aa3hUeuf/Ggelxg8gCqAB/pHXGuRfa3Ym6Tl1x 8GN53T4B202BQmlqmgovgV7HV5xSf/n4ypOQkocy86BNHEPDGtX4Kug34YwpAGhwUxn0NP 6XFO9o+voLdZQjpytYYCDli6OFHmzuYs3WsnIbqku7yRXw2Xb/xiOonRYMfYOno+PRyhv0 BT9lEcypJVKQAbA40AFam45Yw0NcJgbpZNJ/F0uGUDoMUEBL37543mqkCEIhGRy1cTIqjp GqwFMU+cyTpMm+Y4X6oYHll6e56STgpch2njVGJkI4Psj9OnZPs9wS57KU1JSg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795029897; b=L1e4EjbuZ895//omhjXxqI1YZawMf41k8TZ68KoVU9Lk6egDww5cHAL++4Yr440szI8JiO lwcHnlx2WZZi9YdS4OxWLEU3wS9/UJjUHwRIn3DVPuGRTB8rbFxCWKkgnjx8YlzlyPOP2F SKKit2seY6xI0YurW5GwSdnjIVAaOzn7jU2DJ/o/OfaGIiH6wxdh3JFxwvlroT6BjmU4Yb HUdCL3ZjBmz3FBlnyRaqgvsj9wVrho4N0gw26Q3xHpD0IZs2NtO9J0jy+opWCjnqPZ/dJp 90qXU3vXOUjt5aeeISnIzsFRDI20vDIJCwlubc7CSKG01bRjvm7pssldfyKFPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795029897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GAsjNejDhefZvTfHIrQKx9kfU/m2zlE3rTMWD2ZsAyU=; b=kZHvfmNgPT1WJFS6Wt3jKFeLFeHu9wVX2sMP+1U+twH25Isrlmp2SCl1iXJEk/RpLDmPgg b6wAt1AnZpm9ss9oWfU/SLYMpIyLyUROfWfXBMXVqvhBRFxr9AF/T/p3uItFhlwE++1GCg jdTNLkFZ15RWCHIhW0MRcoVfQ6efmSh/gnp5OGoeAvBp0b0UfKXCMT1VuYTaBWplwtQdxx ieFnqE6yBVuWxlqxHuobjkPfvUQhv8mCfd+FNZJlMWyEfUDAjaMoFEQxLFQ/dlweTTtVql qy7rSBerT9GRACNpU4ZG2L8NSJcv1g61oHttCez/fbBUkja1qz1N95pg9TvQmQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jVBPj0wcXzQtg for ; Wed, 18 Nov 2026 19:24:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 14fd3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 18 Nov 2026 19:24:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Tim Hostetler From: Mark Johnston Subject: git: b9dca399ce35 - main - gve: Fix return value in gve_tx_has_desc_room_dqo() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b9dca399ce35a2f50316187f8a6567bb94da53c9 Auto-Submitted: auto-generated Date: Wed, 18 Nov 2026 19:24:57 +0000 Message-Id: <6afdfb89.14fd3.58181031@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=b9dca399ce35a2f50316187f8a6567bb94da53c9 commit b9dca399ce35a2f50316187f8a6567bb94da53c9 Author: Tim Hostetler AuthorDate: 2026-11-18 14:22:55 +0000 Commit: Mark Johnston CommitDate: 2026-11-18 19:24:35 +0000 gve: Fix return value in gve_tx_has_desc_room_dqo() When the cached tx->dqo.desc_head does not show enough available descriptor ring slots, gve_tx_has_desc_room_dqo() reloads desc_head from tx->dqo.hw_tx_head and re-checks availability. If the refreshed desc_head provides sufficient space, the function mistakenly returns 0 (false) instead of true, causing callers to treat a successful descriptor head refresh as ENOBUFS, stop the TX queue, and retry or abort packet transmission (including unloading already-mapped DMA segments) unnecessarily. Return true when sufficient descriptor space is available after refreshing desc_head. In 60s iperf benchmarks between two FreeBSD 14.4 c4-standard-192 instances, this eliminates spurious tx->stopped transitions across all workloads: - TCP 1-stream: 54,859 -> 13 (-99.98%) - TCP 16-stream: 9,623,851 -> 6,324,299 (-34.3%, -3.30M spurious stops) - UDP 1-stream: 71,626 -> 0 (-100%) - UDP 16-stream: 608,585 -> 3,622 (-99.4%) Signed-off-by: Tim Hostetler Fixes: d438b4ef0cfc ("gve: Add DQO RDA support") Reviewed by: markj, Jasper Tran O'Leary MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D61232 --- sys/dev/gve/gve_tx_dqo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/gve/gve_tx_dqo.c b/sys/dev/gve/gve_tx_dqo.c index 95490eb1de4c..e2dcedb43bbb 100644 --- a/sys/dev/gve/gve_tx_dqo.c +++ b/sys/dev/gve/gve_tx_dqo.c @@ -574,7 +574,7 @@ gve_tx_has_desc_room_dqo(struct gve_tx_ring *tx, int needed_descs) return (false); } - return (0); + return (true); } static void