From nobody Wed Nov 18 18:03:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jV8bM41s7z70xn2 for ; Wed, 18 Nov 2026 18:03:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jV8bM0nLNz4k8T for ; Wed, 18 Nov 2026 18:03:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795024991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wZWHBU+gDN+JmfZECSEeAwcLhXmGzamuUGdJyboRAuw=; b=Ij0Fymq4XVH5M39VGLeaFar2ykhpvFMCTH8b3hmwQGmWj0hPi5SmmlNpJjnSkSPwssNJvd zY4rSILLrISwR5ibiD3GlhwcZuZsN4ShSs6R/QGhFstoMk+6bWJJ8QZfjF0f6m7YvXeFAm QK38RqQkbg0hzjuFnP0fsK3c2WZUoQi34pIzHLB58EJONWVHsARNfxViRKQ+UuNwXPfENG l57Cnfbr/SFzk+ULOmF0pQmnHZSkHFhzwTIS35K18zYbZkyhNel88ZeWhanbme/C1OCpHN zT+FaNb3PIgvd+Z0KBl7J/qRVQ1ybtqa/KAiC1o24snoqEX19zfDvkcqWlHTNA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795024991; b=hOLftEavPWMiGIhP8N1Azpyi/9JbwexmrNIsW5GZMfmBX5mcUHy//x6HefIEaZ+wmnBv6X cq/bER4ptZkFDinCSmbrfMxJLxAwS29VedJZBSLbzenKzyigQMOf+mU1Hb5Dj9p09w9GFL 2i8ZNRBLPGXCe59+R6H30Ccipgo50g/g0JGsQ4k7DQoNqmC6tlCWChbyV0ZGZBa2ruLvFl NxlO4P1jpTmtlGXN5fLt+8i5ep0VVXkWissB4MjsvIlT9iCXPw7eRcY+g/22uEdInWSPk4 MO/MALIYt5mKxt6liEoDMpqSRLUEOrNJTK2AaZCw+5USSXmjCG3Q3pW8aDtXIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795024991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wZWHBU+gDN+JmfZECSEeAwcLhXmGzamuUGdJyboRAuw=; b=G/XnMnKFPqJ7h1V2uPDIrEa6KdLg4l2t/ilTiQAFU/kYEiK+8OMVoy1OCZKdQaB54PWgTv MiZtQxm4rHOCp7q4v1TyF8iSGAVDuo1PSjj2zYtgsj6XNGfCFwzGq2cVLaNwrZcKyybVIa kh8HQrY+Ht8cF+nO+dUUiv3WyRlUTQUxF4NuCV0JJ9GGVtXu4zBb2Nfe6G7Yp+kbe7fkzu VBzJ0SrD3nCROG4PahOLUmKu5RqZ/RwuyDLNS9zE2hZwElqKyBkGILihfU9uQCDDdj9Iww IXSaGN/zEE6tEuoifwfQTwM/wa+6ENI37GSXKlY1ObtIy8mFlzZsJipr0MFvdA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jV8bM0SVyzNjt for ; Wed, 18 Nov 2026 18:03:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id e2ee by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 18 Nov 2026 18:03:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kenneth D. Merry Subject: git: 89e585b8a459 - stable/15 - pass(4): Don't drop the periph lock before selrecord() in passpoll() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ken X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 89e585b8a4592649d5edda9ca23167ed6fd6b502 Auto-Submitted: auto-generated Date: Wed, 18 Nov 2026 18:03:11 +0000 Message-Id: <6afde85f.e2ee.7cc07b29@gitrepo.freebsd.org> The branch stable/15 has been updated by ken: URL: https://cgit.FreeBSD.org/src/commit/?id=89e585b8a4592649d5edda9ca23167ed6fd6b502 commit 89e585b8a4592649d5edda9ca23167ed6fd6b502 Author: Kenneth D. Merry AuthorDate: 2026-11-11 14:26:19 +0000 Commit: Kenneth D. Merry CommitDate: 2026-11-18 17:37:11 +0000 pass(4): Don't drop the periph lock before selrecord() in passpoll() passpoll() checked the done queue while holding the peripheral lock, dropped the lock, and only then called selrecord(). A CCB completing in the window between the unlock and the selrecord() call sent its selwakeuppri() before the polling thread was on the selinfo list, so the wakeup was lost and select(2) or poll(2) slept until another completion arrived or the timeout expired. Call selrecord() before dropping the lock. This lock order is already established: passdone() calls selwakeuppri(), which takes the selinfo lock, while holding the peripheral lock. kqueue is not affected, since the knlist is backed by the peripheral mutex. Reported by: llm-postcr Fixes: a9934668aa13 MFC after: 1 week Sponsored by: Spectra Logic Assisted-by: Claude Fable 5 (cherry picked from commit 88c5709e91ad2cc6df51380673837f0ebd8a2d50) --- sys/cam/scsi/scsi_pass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/cam/scsi/scsi_pass.c b/sys/cam/scsi/scsi_pass.c index 8164edd243fd..0be9daa1e36c 100644 --- a/sys/cam/scsi/scsi_pass.c +++ b/sys/cam/scsi/scsi_pass.c @@ -2121,9 +2121,9 @@ passpoll(struct cdev *dev, int poll_events, struct thread *td) if (!TAILQ_EMPTY(&softc->done_queue)) { revents |= poll_events & (POLLIN | POLLRDNORM); } - cam_periph_unlock(periph); if (revents == 0) selrecord(td, &softc->read_select); + cam_periph_unlock(periph); } return (revents);