From nobody Wed Nov 18 18:02:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jV8b275RLz70xmr for ; Wed, 18 Nov 2026 18:02:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jV8b260L8z4jk9 for ; Wed, 18 Nov 2026 18:02:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795024974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SDMHLza3+bj41an0f3Jj3pTwGBtzFfoX/fu7WdRKbCw=; b=sknSV3Gb4ekv5W1rJ4hXbuPzpKhAc7So6VD8Qf+Ih5muPG9Xrx7B8CmHzWXI5L9++WRC4C PWCXNNG+DTi9Ri2BKCh0Tmz0TGaLfcmvhyyW3iY6kR92z47AErQ4bFkO4c0vAKJqxmo3ij KHhgqE+l8JfEPyHYknkOS+wTcN/J5HUzqH11a/teDKpsdNPt9R+Nd5fURT+9g3rDY27COY wlpqi2GPlQjXFWwNQqIPFxW+snRFjy4cxg+q6MLXp698VthOLMaBU6tV0ZqFKpLVUuHO/R 5hXh1qcjzY72DPLJWa3mEM/2TFyzDobOFaoHx4/x3ge5Jd+04tdV8ECCLO4f2A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795024974; b=ZP4GWZRqLTG/OJbPyyrSqEbqeTswC3NtPUXDJ0jpyyKWseQ07M02ADLETpy4BpSKBgtn+T aCgw79lLMteomAM7xPqfRp2JDv0KMMGkkDlzo5oEUPounYRmPV46UoHmUbXczgVEljywYJ u1uc6TAdgQF19RrXy8ta6QVnPPrjPgTUpULztrE/qOyzYfhlEBSyrZXUnlaHbXF1+prI2i WvMWG59QU4T9KYCFVby/VAoMzM8P9JZW1BswHtSuB5V3Y1WnKDC0pKXiLJ6qyESqI6iK/2 66hLqRypSjTWKmpv/s8RZNcN3AKGP1dbbmUAs8eAeJe5QY90Z+IJPoKAU4KeBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795024974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SDMHLza3+bj41an0f3Jj3pTwGBtzFfoX/fu7WdRKbCw=; b=dgpoqD9AuyXpugSYH18t2VXo5rw8devS1lta/KckNP15PxDNKDzgC0+sNz/4Aa5wBA2Pnx T59w1eNapomGr0FWFfmbBiBJBpafVJtvBUSyCeNS7XXwZxPmvix9k2PZ3BmoGf7IAEUCmN urQ6CAE9FgUwgKmxLdkusVh3irLissIizVyV+5H0GuEneUUBXf6TgW2RAoEth8a/HNe2IJ AXlOrVqmIU/ZSGOvDgnW92TRcXlmLekaX0QVvjX4WEmyl3p1t/uyXcKnlqPU5BUrSzJ//y PglRAs9Rl7yexXhWwzwgZ4oFIHidHh4LF/lW86lKO7n8Dxd59vvtMwfLOP7WoA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jV8b25fz0zPDn for ; Wed, 18 Nov 2026 18:02:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id df90 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 18 Nov 2026 18:02:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kenneth D. Merry Subject: git: 21b7a2ff550f - stable/14 - pass(4): Wake select/kqueue waiters when an immediate CCB completes List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ken X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 21b7a2ff550f96b87ad7b1ca750f6eedc66e988a Auto-Submitted: auto-generated Date: Wed, 18 Nov 2026 18:02:54 +0000 Message-Id: <6afde84e.df90.6b192fbf@gitrepo.freebsd.org> The branch stable/14 has been updated by ken: URL: https://cgit.FreeBSD.org/src/commit/?id=21b7a2ff550f96b87ad7b1ca750f6eedc66e988a commit 21b7a2ff550f96b87ad7b1ca750f6eedc66e988a Author: Kenneth D. Merry AuthorDate: 2026-11-10 23:01:38 +0000 Commit: Kenneth D. Merry CommitDate: 2026-11-18 17:37:29 +0000 pass(4): Wake select/kqueue waiters when an immediate CCB completes In the CAMIOQUEUE ioctl, a queued CCB completes through passdone(), which moves it to the done queue and calls selwakeuppri() and KNOTE_LOCKED() so that a consumer blocked in select(2), poll(2) or kevent(2) wakes up and collects the CCB with CAMIOGET. An immediate CCB (e.g. XPT_DEV_ADVINFO or XPT_DEV_MATCH) is instead executed synchronously in the ioctl and moved to the done queue directly, with no notification, so a consumer sleeping while waiting for its completion never wakes up until some other queued I/O completes. Send the same notification that passdone() sends. The peripheral lock is held at this point and backs the knlist, so KNOTE_LOCKED() is the correct variant. A version of this fix has been in production use at Spectra Logic since 2024. Co-authored-by: Dave Baukus Reviewed by: imp MFC after: 1 week Sponsored by: Spectra Logic Assisted-by: Claude Fable 5 Differential Revision: https://reviews.freebsd.org/D61416 (cherry picked from commit 6442a92a7d9c20c666999cc699610f1f5bec3cfd) --- sys/cam/scsi/scsi_pass.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/cam/scsi/scsi_pass.c b/sys/cam/scsi/scsi_pass.c index 72035e1e0d0e..3215b66454a1 100644 --- a/sys/cam/scsi/scsi_pass.c +++ b/sys/cam/scsi/scsi_pass.c @@ -1994,11 +1994,14 @@ passdoioctl(struct cdev *dev, u_long cmd, caddr_t addr, int flag, struct thread /* * If this is not a queued CCB (i.e. it is an immediate CCB), * then it is already done. We need to put it on the done - * queue for the user to fetch. + * queue for the user to fetch, and notify any waiters so + * they know there is a completed CCB to collect. */ if ((fc & XPT_FC_QUEUED) == 0) { TAILQ_REMOVE(&softc->active_queue, io_req, links); TAILQ_INSERT_TAIL(&softc->done_queue, io_req, links); + selwakeuppri(&softc->read_select, PRIBIO); + KNOTE_LOCKED(&softc->read_select.si_note, 0); } break;