From nobody Tue Nov 17 17:09:56 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWSN51Hcz71Ss5 for ; Tue, 17 Nov 2026 17:09:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWSN35krz4QV9 for ; Tue, 17 Nov 2026 17:09:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UTqhpVls2ulGeNR6xbhAt9SCtLvsjdzIqgkFNzfc1RM=; b=owtX5NqZH9kiNaPem5SdpU+l3Jk4jGIQcy+ydG81kbD6FXUNqg+TfaGnsysA8pjTXqYrDe 88zYg2tZ3Ib9TBUdM57qEjKgZqXsfM/YAYTLOQOjYT692cAnX1xdgVVloRCJqX83nIcfDY qi1YTNpRzrhZGdeJSzsXMRKzTDR6ezt6s5CRoEXw+0GZ/bPcplhaCkppCIwPxcYVxXZ58i 0JwAD6gcymymhBQk8KblDM5gt7HkSPV3WLB9w6VkJTDtZVkIpUmY8rzMI4u1cCVMjQ1Slo FRRsADlDJtj4MFDrErGvlFzzHhUCJQm8MNGlu2aZwLqv4S+Vehh46cAyjM0Ffw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935396; b=whv3X6S83YSvwp62Gvz5Mdcl+GeywJRV3rVXQaRr/Z4lZo1BSxdYy9scuji/EGcB8huqsR jbQMadcC7M7Ed3isz5q8Nc9DUVaIJNaFc/qvjdsUjFwUwxo1HCT34KNqx9IebCHbmtfEAS 4O9ADH5TS1nVAJnp+FisoEaH+sekGAZ3pytYXz9hZuzBypfVAF7QZnROZ9M+Bn/v2sS25K 9TWC2ztr3f0au3jn6OXrVX6Wkygn9K6RmTKrO4GkfgaK/vAU3YCjv+bh+3xIyJ8GcRZ6JS 7ZeciPmQJoVtK1kVOe+HTevhI+vZumG6setvAeSsniHNA0WTVeCMA010cRXXKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UTqhpVls2ulGeNR6xbhAt9SCtLvsjdzIqgkFNzfc1RM=; b=UYhyvPWd+BOU900gLtliVdElC5WsV75o1bpWsWqy8sbcwaPiSYGbV14+sqPh+aN7tmfT4x hce2G3cQm9Ywi5Uv1veWLdiDlIRppyQ7PjmA8Ff9RXLW2bqAfngzN91tdXJ2QczpJJ5LCM Uue+03Yix9zyoWf89FS13HCR6+hkzI1sopv0fJzleEalqQg9ycrfQAoDWXIdHG6T+U1VXu /8yswjd6COLnXddU/who/h+DHH0tdKC+87JEOSrWvhxz5NeJsUG8yjCGo20Rb9Zk/tbDfc FwbQlUkPi0OS1g/V5zIZOHpRbLrtPFjZBUti08dhl6v9X2QpXeB3L9eV7xfIqQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWSN2YtNzs1s for ; Tue, 17 Nov 2026 17:09:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id f01 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:09:56 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Konstantin Belousov From: Mark Johnston Subject: git: 92a5188e7149 - releng/15.2 - fdescfs: add VOP_ACCESS() implementation List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.2 X-Git-Reftype: branch X-Git-Commit: 92a5188e7149d07c13e6c20715a444b6d9f74a21 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:09:56 +0000 Message-Id: <6afc8a64.f01.afc6080@gitrepo.freebsd.org> The branch releng/15.2 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=92a5188e7149d07c13e6c20715a444b6d9f74a21 commit 92a5188e7149d07c13e6c20715a444b6d9f74a21 Author: Konstantin Belousov AuthorDate: 2026-11-06 00:00:19 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 13:36:45 +0000 fdescfs: add VOP_ACCESS() implementation kern_truncate() checks VWRITE only through VOP_ACCESS() on the fdescfs vnode, which always succeeded until now. So a file opened read-only could be truncated, even if the caller has no write permission for it. Note that reopen on mounts without nodup already performs the permission checks in dupfdopen(). For nodup mounts, the VOP_ACCESS() implementation of the real filesystem is used. Approved by: re (cperciva) Approved by: so Security: FreeBSD-SA-26:91.fdescfs Security: CVE-2026-127745 Reported by: Kevin Day Sponsored by: The FreeBSD Foundation --- sys/fs/fdescfs/fdesc_vnops.c | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/sys/fs/fdescfs/fdesc_vnops.c b/sys/fs/fdescfs/fdesc_vnops.c index 0ff11591cabf..d29ce4236eac 100644 --- a/sys/fs/fdescfs/fdesc_vnops.c +++ b/sys/fs/fdescfs/fdesc_vnops.c @@ -73,11 +73,12 @@ static vop_readdir_t fdesc_readdir; static vop_readlink_t fdesc_readlink; static vop_reclaim_t fdesc_reclaim; static vop_setattr_t fdesc_setattr; +static vop_access_t fdesc_access; static struct vop_vector fdesc_vnodeops = { .vop_default = &default_vnodeops, - .vop_access = VOP_NULL, + .vop_access = fdesc_access, .vop_getattr = fdesc_getattr, .vop_lookup = fdesc_lookup, .vop_open = fdesc_open, @@ -704,3 +705,34 @@ out: vn_lock(vn, lockflags | LK_RETRY); return (error); } + +static int +fdesc_access(struct vop_access_args *va) +{ + struct vnode *vp; + struct fdescnode *fd; + struct file *fp; + int error, flags, locked; + + vp = va->a_vp; + fd = VTOFDESC(vp); + if (fd->fd_type == Froot) + return (0); + error = fget(va->a_td, fd->fd_fd, &cap_no_rights, &fp); + if (error != 0) + return (error); + flags = 0; + if ((va->a_accmode & VREAD) != 0) + flags |= FREAD; + if ((va->a_accmode & (VWRITE | VAPPEND)) != 0) + flags |= FWRITE; + if ((va->a_accmode & VEXEC) != 0) + flags |= FEXEC; + if ((flags & fp->f_flag) != flags) + error = EACCES; + locked = VOP_ISLOCKED(vp); + VOP_UNLOCK(vp); + fdrop(fp, va->a_td); + vn_lock(vp, locked | LK_RETRY); + return (error); +}