From nobody Tue Nov 17 17:09:52 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWSJ6K5Rz71Stb for ; Tue, 17 Nov 2026 17:09:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWSJ1hmYz4QWr for ; Tue, 17 Nov 2026 17:09:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=exKGdrveZyg6RAevoRl0IFyhUwyXEHfuHIWHxHDsrrs=; b=ABef+YL1uF37XeaIIjjihMkLmKScIS91T/4V3bdcWfroclmd/esBRC4XVNKiCE2zk/FWxv ThMFJnC/Xv2w2W9VxZ2ihQhTkOtG9d30VfyaIXMn8KvBYSQEH8DhBPEhlrazmtKc/2jbFQ lznx6Gule4qWoi4JrRxgnVZEtjk7xXDdwhMj8I0MOTzaVbZlepJZVVY+0/IOJmr1/lfZmX uYflwFr/c3JBKQrewJ/QHuRwwKBQfVmCjiUD/6ZGeP3btQkyiY+RJkpdfWOvAvUnLM+UEh MkFRBYQX5i2EJtYOHleuZWZJnasHXExW/dPU3p/mX9Xaoq6erSImcfHb7iPPBQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935392; b=ThElE6SQAz1WUQfSJMtGdYLtAxkMV8iaCp32C+qC3gbY+SLvfMLZQ1m6lKp0cen3fxZBhq iaxiibzNXkvA92ZfmUK/Tz2OgyMdJ1pAPvntrJMtKNmSfFj3n2MOQUrmCrJnYTl/71P2k/ syQmQVi2FKe+fJ56/Rev1lNX/iZOScpdV/y6LAZ9DLeKthuDmH0yV6coc5fe+yXyUXnhZ+ W4CJvmbCWSDukRVZcFFXUg8NRBXV7cZOqwE46xETJX9FQspHBv9GjNCw0BjgGuphMAXm4M SMheFip2sSN3OCkOI1LFYRGdQQF0vS9S3jMCP6spb9JW+S8DE8bzJg7FKzw6uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=exKGdrveZyg6RAevoRl0IFyhUwyXEHfuHIWHxHDsrrs=; b=rpjzSkjRbeQ/bIbl0sJhSDf28QrPj6hml23wrRWfzOeoPMz2OOvPeLGIRLb5d/7pvGRP6V jvHjNzcBEyn6jjPJtJLh4LRaEjFwiOPVPBwF0oHwZ9h1QqgJ2NGY8Ln6ysHdv0h6IcdZwp LKr9xK//VelGRHqoLrgYoGIggs74ulEp424rnwIIbvBsL+XRnUs+3VYw0A8bhw6WfOLn2N ojXzvX9/0K9YLMAql6x8f1h5kr71uh8TwpBHFs8vOV9nUO1+8WyGL/LcZjgH66fC6oABKq qA9D7KIiBxgKwuRtm/ZpxZ4N5C4bXM7ssz+xDZKe8sv7funKdSW+BP6seKcJyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWSJ15Nyzrhm for ; Tue, 17 Nov 2026 17:09:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id a0b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:09:52 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Maxim Konovalov From: Mark Johnston Subject: git: 921480fc2144 - releng/15.2 - bsnmp: reject an oversized vacmViewTreeFamilyMask List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.2 X-Git-Reftype: branch X-Git-Commit: 921480fc21443da65fe810fb101bc9b4e5fc284d Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:09:52 +0000 Message-Id: <6afc8a60.a0b.24a303b5@gitrepo.freebsd.org> The branch releng/15.2 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=921480fc21443da65fe810fb101bc9b4e5fc284d commit 921480fc21443da65fe810fb101bc9b4e5fc284d Author: Maxim Konovalov AuthorDate: 2026-11-13 03:07:48 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 13:36:18 +0000 bsnmp: reject an oversized vacmViewTreeFamilyMask The SET handler for vacmViewTreeFamilyMask compared the value length against the 16-byte view->mask, but the check had no statement of its own: it guarded the following malloc() instead of rejecting the request. A value longer than 16 bytes was therefore copied into view->mask with memcpy(), overflowing struct vacm_view. Add the missing return so an over-long value is refused with wrongValue. Approved by: re (cperciva) Approved by: so Security: FreeBSD-SA-26:89.bsnmp Security: CVE-2026-127743 Reviewed by: harti Fixes: 135f7de5ddb6 --- contrib/bsnmp/snmp_vacm/vacm_snmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/bsnmp/snmp_vacm/vacm_snmp.c b/contrib/bsnmp/snmp_vacm/vacm_snmp.c index 39371176e493..29d1b8ffcb1e 100644 --- a/contrib/bsnmp/snmp_vacm/vacm_snmp.c +++ b/contrib/bsnmp/snmp_vacm/vacm_snmp.c @@ -490,6 +490,7 @@ op_vacm_view(struct snmp_context *ctx, struct snmp_value *val, uint32_t sub, switch (val->var.subs[sub - 1]) { case LEAF_vacmViewTreeFamilyMask: if (val->v.octetstring.len > sizeof(view->mask)) + return (SNMP_ERR_WRONG_VALUE); ctx->scratch->ptr1 = malloc(sizeof(view->mask)); if (ctx->scratch->ptr1 == NULL) return (SNMP_ERR_GENERR);