From nobody Tue Nov 17 17:09:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWS52DnNz71SsL for ; Tue, 17 Nov 2026 17:09:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWS45dwXz4Q14 for ; Tue, 17 Nov 2026 17:09:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QawLh1eGOTRxh3qTtM5+3iBvjRnOh6Fecu2uasycNaI=; b=Mi+g8oxNWLyEI36Bq28UZKCdqGFdH1b8Ea0ghtGubyvPPBYYOEhgu7eXS9YfIOZP7iTQyu bolcpUHw261Yhq8oFs4IYTAjow+jwJA1ow3DhUIBrsfna0DMVe+hHZjDi1VG4HJKGOEmM5 IHdYfaSfrvP2QZ4QNOyXPMElH33UADhx/At7yYJWd2SXFqa0aouAYtjKla35oAqLzB8FfP zu+StqgcfKDXoiv/nHja4jIcr2iedL7Nv9J5aVDfa7Uvv01Q+YLxcepRskaJki9VgmjiEI 8wCjkjWKgqlIhLykOd5rEVX5ITCam29/YQOP3ewisHA88Y3wL3jJeENCNZE1wg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935380; b=U5JPAaCDqhoTh2Okq09Fj50niLByuI5BMtoxj5aFeYQI4saMIxISkg5Y8oe+M3YFJu1vXE M2XcexdhAN6bWBYEKpr+3Rtb7zZtLIszEZw56RMODi6zD6KD2EE77XpOTjIsHE3ETaX35N qFIFmbsuTqQwdOrQBKfBets2LClXIsXa2gEnfFAPrLCKtGktwRYTPxobXXHBJb+vzqAedA ULwsjyYNktiJe9KNtdKetMIuABvMybvG39SYlklN5qGzz/eOqqqC1wML3WLdNbE3r8dAD2 hWDJzJ/JYGz/6c5cfJ3h6nXzdkd0IpOY2xE4+rAK5to1ILs1PA7nrC4AGJR3Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QawLh1eGOTRxh3qTtM5+3iBvjRnOh6Fecu2uasycNaI=; b=G7VLJheVzqxbG3SjlhieIGW7e1jUPDltP9XQLl0VuumKtT1E208hsoNYtyLVmJx2KmSccF uRJisIVrSf3WVoV0StxGdrksyDxqJasBk2iPkz2X4STIknrLyS+4NCxUvR7nPPelSRx6OP oBWJDXVYQ2ZgrxwVCvqLja1TE6YpJOCEfKjNgl0xOh/QYU27gmq8KTgKyrGppvwocZmzHi EFYyyqcxx2ff+Ju7o3as738B/cpJAg2Irn2o64XLC8F9o55eeHvFLrihDXS173h5P1pO0E vSS6pLtpPZo+awTpbcMSr97Cyrel0iiL7OIVB2lqdNBLJbt7qt6RFgnqDw3+7Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWS43wK3zry5 for ; Tue, 17 Nov 2026 17:09:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id c20 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:09:40 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Pawel Jakub Dawidek From: Mark Johnston Subject: git: dbbddbaef0f6 - releng/15.2 - lookup_cap_dotdot test: check dotdot VV_ROOT escape List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.2 X-Git-Reftype: branch X-Git-Commit: dbbddbaef0f678a51d40fbf87666355d765f7237 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:09:40 +0000 Message-Id: <6afc8a54.c20.2e1aff85@gitrepo.freebsd.org> The branch releng/15.2 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=dbbddbaef0f678a51d40fbf87666355d765f7237 commit dbbddbaef0f678a51d40fbf87666355d765f7237 Author: Pawel Jakub Dawidek AuthorDate: 2026-10-23 04:01:41 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 13:35:05 +0000 lookup_cap_dotdot test: check dotdot VV_ROOT escape Approved by: re (cperciva) Approved by: so Security: FreeBSD-SA-26:81.vfs --- tests/sys/vfs/lookup_cap_dotdot.c | 71 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) diff --git a/tests/sys/vfs/lookup_cap_dotdot.c b/tests/sys/vfs/lookup_cap_dotdot.c index fa26a13568ca..08c3f81b0d57 100644 --- a/tests/sys/vfs/lookup_cap_dotdot.c +++ b/tests/sys/vfs/lookup_cap_dotdot.c @@ -26,8 +26,10 @@ #include #include +#include #include #include +#include #include #include @@ -255,6 +257,74 @@ ATF_TC_BODY(lookup_cap_dotdot__root, tc) ATF_REQUIRE_ERRNO(ENOTCAPABLE, openat(dfd, "..", O_DIRECTORY)); } +/* + * ".." from a directory that is a mount root: the lookup must not cross + * to the covered vnode and leave its starting directory. + */ +static char mntpath[MAXPATHLEN]; + +static void +mount_tmpfs(void) +{ + struct iovec iov[4]; + char cwd[MAXPATHLEN]; + + ATF_REQUIRE(getcwd(cwd, sizeof(cwd)) != NULL); + snprintf(mntpath, sizeof(mntpath), "%s/mnt", cwd); + ATF_REQUIRE(mkdir(mntpath, 0777) == 0); + iov[0].iov_base = __DECONST(char *, "fstype"); + iov[0].iov_len = sizeof("fstype"); + iov[1].iov_base = __DECONST(char *, "tmpfs"); + iov[1].iov_len = sizeof("tmpfs"); + iov[2].iov_base = __DECONST(char *, "fspath"); + iov[2].iov_len = sizeof("fspath"); + iov[3].iov_base = mntpath; + iov[3].iov_len = strlen(mntpath) + 1; + ATF_REQUIRE_MSG(nmount(iov, nitems(iov), 0) == 0, "nmount: %s", + strerror(errno)); +} + +ATF_TC_WITH_CLEANUP(lookup_cap_dotdot__mountroot); +ATF_TC_HEAD(lookup_cap_dotdot__mountroot, tc) +{ + atf_tc_set_md_var(tc, "descr", + "Validate that .. from a mount root stays beneath it"); + atf_tc_set_md_var(tc, "require.user", "root"); +} + +ATF_TC_BODY(lookup_cap_dotdot__mountroot, tc) +{ + int dfd; + + check_capsicum(); + mount_tmpfs(); + + ATF_REQUIRE((dfd = open(mntpath, O_RDONLY | O_DIRECTORY)) >= 0); + ATF_REQUIRE(mkdirat(dfd, "sub", 0777) == 0); + + /* A ".." that ends at the start is fine. */ + ATF_REQUIRE_MSG(openat(dfd, "sub/..", O_RDONLY | O_DIRECTORY | + O_RESOLVE_BENEATH) >= 0, "%s", strerror(errno)); + + ATF_REQUIRE_ERRNO(ENOTCAPABLE, openat(dfd, "..", O_RDONLY | + O_DIRECTORY | O_RESOLVE_BENEATH) < 0); + + ATF_REQUIRE(cap_enter() >= 0); + + ATF_REQUIRE_ERRNO(ENOTCAPABLE, + openat(dfd, "..", O_RDONLY | O_DIRECTORY) < 0); +} + +ATF_TC_CLEANUP(lookup_cap_dotdot__mountroot, tc) +{ + char cwd[MAXPATHLEN]; + + if (getcwd(cwd, sizeof(cwd)) == NULL) + return; + snprintf(mntpath, sizeof(mntpath), "%s/mnt", cwd); + (void)unmount(mntpath, MNT_FORCE); +} + ATF_TP_ADD_TCS(tp) { @@ -267,6 +337,7 @@ ATF_TP_ADD_TCS(tp) ATF_TP_ADD_TC(tp, lookup_cap_dotdot__advanced); ATF_TP_ADD_TC(tp, lookup_cap_dotdot__negative); ATF_TP_ADD_TC(tp, lookup_cap_dotdot__root); + ATF_TP_ADD_TC(tp, lookup_cap_dotdot__mountroot); return (atf_no_error()); }