From nobody Tue Nov 17 17:08:37 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWQt2GZlz71SVt for ; Tue, 17 Nov 2026 17:08:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWQt06Ytz4NRw for ; Tue, 17 Nov 2026 17:08:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=er0Pv4QUJayWB+9lBun6uSjIiLm6KZdoboFn4s11qCk=; b=rVGASWAM+xPnvXzDx5Q51hRoSqexYx11FJKNUXsY05mM5y+geu/bErbzWf/hqtP8z4+QAH Op7BEjQHhtQ03CXXaKpxzjDn3bPFjh762fG01CIk0LnmJpDHQC97zGAFi+W1zCwdQmWtgy ZyR3TTDS9HLTppIa3pXN0F+Og7OfyPIB7/nN8jKMXbAm35iAfadkQDbe+a1fxKaAmjcv3X YMh8uqZbi4JYsbtr6jqrOP5z0c1aNl2Ot3MkjuZC8Z+B7H8ii/7JNtZFZFzDDa/XpPE9// xIT+u0JilnBLQFW1yG/K7ACyxWY/TJRFB/ptgQSFSknaH/ACSM8NkeXhmFcYnA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935318; b=pakp8Qw+zML4s1LTVaxPUNU9qD+SKXVux2+GbS81JJ+o0SDSoJeOVA0e3qTE9v+qAmjYmo w8622Kl1fnNUFDXsBnoHzQzFLI0W1VMFQr+NGzXrJn/gdP5v2I5412wPHcQcHhko4KsEpS PaqaaihZinbEWV7zJg+5ZYhIYxdR+Q0OxFsxLwwCp11Hy3QU392IB8IX0IhX6328RtnLb2 QRcdvmllVWb+Lbyjs7c/AQRuZybb57R7o1QKMrIFTaJvcMAfVmjU5G32N8sDxlwTvF9rUl +And/iINpMIxwuVMouyBltvQq30GRiXT4vrMOKeV22CSBMdexYXBjGkHGZ21zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=er0Pv4QUJayWB+9lBun6uSjIiLm6KZdoboFn4s11qCk=; b=R1fz/aD35XVd22G639HXRyGfdoGZwptoqRJAZAOHdtcKozLPbdJI28CWr13eEjSeon0LR9 FWjKnxZp6FJHi09LrNgVdbsvGidi0+L/K4c4t50VEnxhVnu0ovRclu3R11uSHH/7bUakpi ERQMPSdKiHq5N+V5B7byVcwM/N/Y7JKhXBFU5MNDFy5OJrRMoC8eCYfipQJ4wf5j9NL86P OqSeC/HB2UqjomKYVS94FPNvvxzjmSK92hpZdu3VmIIVcRu3fXc9Ntv+8LbaqINWuTjKb+ Y0XuIrBtBlm6Hp3zwvYQWsMcT4KufiZYZ34mGxZjISLQUMBENm8ouzZPTSwQiQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWQs6LQ3zrsb for ; Tue, 17 Nov 2026 17:08:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1ea65 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:08:37 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Kevin Day From: Mark Johnston Subject: git: 085b4738c82b - releng/15.1 - tmpfs: Clear setgid on creation by nonmembers List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.1 X-Git-Reftype: branch X-Git-Commit: 085b4738c82b249fbed97286b1eb458fd844becf Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:08:37 +0000 Message-Id: <6afc8a15.1ea65.1a13b960@gitrepo.freebsd.org> The branch releng/15.1 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=085b4738c82b249fbed97286b1eb458fd844becf commit 085b4738c82b249fbed97286b1eb458fd844becf Author: Kevin Day AuthorDate: 2026-11-14 01:40:14 +0000 Commit: Mark Johnston CommitDate: 2026-11-16 21:25:06 +0000 tmpfs: Clear setgid on creation by nonmembers New tmpfs nodes inherit their parent directory group. Clear S_ISGID when the creator is not a member of that group and lacks PRIV_VFS_SETGID, matching UFS and tmpfs chmod behavior. Approved by: so Security: FreeBSD-SA-26:94.tmpfs Security: CVE-2026-127749 Reviewed by: kib --- sys/fs/tmpfs/tmpfs_subr.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sys/fs/tmpfs/tmpfs_subr.c b/sys/fs/tmpfs/tmpfs_subr.c index dd281d18d87d..b9643266caba 100644 --- a/sys/fs/tmpfs/tmpfs_subr.c +++ b/sys/fs/tmpfs/tmpfs_subr.c @@ -1167,6 +1167,7 @@ tmpfs_alloc_file(struct vnode *dvp, struct vnode **vpp, struct vattr *vap, struct componentname *cnp, const char *target) { int error; + mode_t mode; struct tmpfs_dirent *de; struct tmpfs_mount *tmp; struct tmpfs_node *dnode; @@ -1195,9 +1196,15 @@ tmpfs_alloc_file(struct vnode *dvp, struct vnode **vpp, struct vattr *vap, } else parent = NULL; + mode = vap->va_mode; + if ((mode & S_ISGID) != 0 && + !groupmember(dnode->tn_gid, cnp->cn_cred) && + priv_check_cred(cnp->cn_cred, PRIV_VFS_SETGID) != 0) + mode &= ~S_ISGID; + /* Allocate a node that represents the new file. */ error = tmpfs_alloc_node(dvp->v_mount, tmp, vap->va_type, - cnp->cn_cred->cr_uid, dnode->tn_gid, vap->va_mode, parent, + cnp->cn_cred->cr_uid, dnode->tn_gid, mode, parent, target, vap->va_rdev, &node); if (error != 0) return (error);