From nobody Tue Nov 17 17:08:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWQh4zhRz71SM6 for ; Tue, 17 Nov 2026 17:08:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWQh38cmz4NHy for ; Tue, 17 Nov 2026 17:08:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=swKny8SPPzxYsRfPJ1y3iCbKRB8u7gt4Q0QW3ju98H4=; b=wEYAvBfRdfxrOVyuu1eP+FZJ2yHPxiCG6e6xj1LOvuC1UUBhu0nhgWUj8R0I9df+nO6Rmw atY7RmqNpdFGgf+eLJKE9Vx7xuB+WCs2R4vOotXFeY103iLWwrLd9RETn72noh0YkoWGpp iWz+vptXjl//jbTI1d2HT8WtJ6nROfGZJHjhSyvN5zTMPThQNQH9CC7Qvu2aFksgykhzfH f37LdXc9voUuOjIE2eUyDNprMelROhmuD+rd5p2+AYAVFtFds0W1YyMcuL8OOnXNaRA3Bg 4nNr7heVdlrSfn590y+gIVLDxDL1ImAVXlhYnW78pzqjyERC3zTZKOJ71+Apdw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935308; b=btFSFSsrZmHeApMQqCbUIRTop8AV9hpzLm4Yt7mW4vLE4EESFJzLAu0xwg1DZ90pMvGNOY tmDFTnv9rU2adrkVCqA0wgIciiPv0yaKejgYpPjuQMkF/HTHfmAClRMfHv7aa+olyM4pDZ wivwPKrwbM0FMExhV9OojZfw9SN4+CRYB++5SCpu6gqOVMeRhMmVjP6Fz1XtjN5dGBqMUt pPW10r16lZepI2B8uTdNA8hDt8OV2v8xb5DET+uE45JM3I25sB+0seLxiYk/zjO0ZjT35I QRSr/cKB4XFbubriQYZKBiqpYrC24HMXhFdKIv2e0Q4AuukMCAIk+GfmPO1ewQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=swKny8SPPzxYsRfPJ1y3iCbKRB8u7gt4Q0QW3ju98H4=; b=JPoLRzgzhSj/rtueya/t4na9lNwQWqksNHVj/sxSCJboU7OfCaDWjWnVS7d015i+9ow4r7 SSjI2s3aA3lFqEqJJqD3jKt4tNPtKcolpfKSH1IQFgIUYsqrSc+q5osrGXFWgmUUqIgVCl oeO9u5R0/HoBg6u3eGBUpTqmHaUPdaLicIv3pTooSDTl1JIhKfTGAmGnKxCdNXfeBmkrlB VAuze9qXT7Rt7qFIqbCfPsifm3qDZ8cqYVrl4hMxxRlSFvK3XErCrIpbRSFAg4dIfUcckn W6pIynkMVEV7M801VXrVw2L8/sIlzj44JHTOai6CCST+BW/elcIAgvJeVMzENw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWQh2q6vzs1T for ; Tue, 17 Nov 2026 17:08:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1cef6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:08:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Maxim Konovalov From: Mark Johnston Subject: git: f53227d63591 - releng/15.1 - bsnmp: reject an oversized vacmViewTreeFamilyMask List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.1 X-Git-Reftype: branch X-Git-Commit: f53227d6359192733db6281ff66ef4315da181e8 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:08:28 +0000 Message-Id: <6afc8a0c.1cef6.4fbb18a2@gitrepo.freebsd.org> The branch releng/15.1 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=f53227d6359192733db6281ff66ef4315da181e8 commit f53227d6359192733db6281ff66ef4315da181e8 Author: Maxim Konovalov AuthorDate: 2026-11-13 03:07:48 +0000 Commit: Mark Johnston CommitDate: 2026-11-16 21:25:03 +0000 bsnmp: reject an oversized vacmViewTreeFamilyMask The SET handler for vacmViewTreeFamilyMask compared the value length against the 16-byte view->mask, but the check had no statement of its own: it guarded the following malloc() instead of rejecting the request. A value longer than 16 bytes was therefore copied into view->mask with memcpy(), overflowing struct vacm_view. Add the missing return so an over-long value is refused with wrongValue. Approved by: so Security: FreeBSD-SA-26:89.bsnmp Security: CVE-2026-127743 Reviewed by: harti Fixes: 135f7de5ddb6 --- contrib/bsnmp/snmp_vacm/vacm_snmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/bsnmp/snmp_vacm/vacm_snmp.c b/contrib/bsnmp/snmp_vacm/vacm_snmp.c index 39371176e493..29d1b8ffcb1e 100644 --- a/contrib/bsnmp/snmp_vacm/vacm_snmp.c +++ b/contrib/bsnmp/snmp_vacm/vacm_snmp.c @@ -490,6 +490,7 @@ op_vacm_view(struct snmp_context *ctx, struct snmp_value *val, uint32_t sub, switch (val->var.subs[sub - 1]) { case LEAF_vacmViewTreeFamilyMask: if (val->v.octetstring.len > sizeof(view->mask)) + return (SNMP_ERR_WRONG_VALUE); ctx->scratch->ptr1 = malloc(sizeof(view->mask)); if (ctx->scratch->ptr1 == NULL) return (SNMP_ERR_GENERR);