From nobody Tue Nov 17 17:06:20 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWNF0Dftz71S1S for ; Tue, 17 Nov 2026 17:06:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWND4Dntz4JdZ for ; Tue, 17 Nov 2026 17:06:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BUjyDz0+jdkPr4Vo4Rafb2YwEh0acrFfbIMfamB2YCI=; b=EnQnPR7bBwh2u1BBAp+N77WPNTJHeHbuhFutK4xlPHBm4MhxRA2zWsVfHbV+nUKWrwzQm9 wfBKb+9TCe33eypuIgWrruyw5n7gfwNH9dLB0FCK2hlf99lzfhma+ot6J1I51MQQynJGgY Ps3OmUiU44SonAPBLIqnNcD0Cu5I/YoD94AUkfIyeEpEPBRnIO9JDfes4fBMBWmneJ4EUR 1BEHMoxxKn1ljv9+Ob260IICErqpLHVfJSvt1pttRX523WTBfyMnI44nVEKeYSAaM6fY9q Ebg4h1fAPRwnk4S4qi+Hs+/zTBeUk4R+XNhDapNQn9eTT0YZ7aCoDW4Jtmw3Dg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935180; b=HmmyRtCCls6j+NGCw+tSccE68Heb6rA+OM7jUTjvTfH5BRc0AnMr1hi2Ror4J7tAZafb06 WmXEdKgCYiQ1XYnBfDBK3DKOVdaL9YoyEB8pHEbTdiIriH/pREpqdWX8GtpluCNDIZzztL dx6UTRKJmIn74kZLOOIXvbgtzUOzkjdaVUiH2KhKtmHlzNyIAgMpMar3bPZ2+Yal7Z1t77 Ldc1IJ/rxe7IQGZ9K8/qJdsepL8okBmmCDpgny7Vav+O6r4kpZ1cMhE15eMtaeSoGu0L6/ 0p8l/HpkKXQZaIx0pyYpFz+lTNTq2QZ8XBK7LO0LTn+hegrIcofnlmUx2Deolg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BUjyDz0+jdkPr4Vo4Rafb2YwEh0acrFfbIMfamB2YCI=; b=TWAJ+Swe7X8XqOCkPg1q1vashiVj+slYl37DfogEW7F67UA7Es4+E0hcxfeMBjlvG5cQmf lz+rIBigYXfN5lfBrDpNqp02+SykbcutljLxbV3QUGIB9PCOVMlv63gF+mdzYHjs9bsm51 GznkkU5bqxRqFlQkRd/RUgsKsjHpUkol9Bexh+vyWHRqEYNsfDkYeDzc5WC6h58buEvd3V ZYOqF+w6KcXmDsnQAtK8/npO+ZIiP7eZf9EgBGpL1NG9zDo8KWQhFGPbTI5k/3EXDsyI88 rG7pO60mxbXAKjPWj8oYAjJFBYuzmapBRmYvQn1ntIE85rGh3ASgFj+4r7VdqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWND3vxTzr9V for ; Tue, 17 Nov 2026 17:06:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e526 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:06:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Kevin Day From: Mark Johnston Subject: git: c56077b5ce6a - stable/15 - tmpfs: Clear setgid on creation by nonmembers List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: c56077b5ce6a6f2f5380e79c456bd134cf91384a Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:06:20 +0000 Message-Id: <6afc898c.1e526.2a11e0d4@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=c56077b5ce6a6f2f5380e79c456bd134cf91384a commit c56077b5ce6a6f2f5380e79c456bd134cf91384a Author: Kevin Day AuthorDate: 2026-11-14 01:40:14 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 16:57:23 +0000 tmpfs: Clear setgid on creation by nonmembers New tmpfs nodes inherit their parent directory group. Clear S_ISGID when the creator is not a member of that group and lacks PRIV_VFS_SETGID, matching UFS and tmpfs chmod behavior. Approved by: so Security: FreeBSD-SA-26:94.tmpfs Security: CVE-2026-127749 Reviewed by: kib --- sys/fs/tmpfs/tmpfs_subr.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sys/fs/tmpfs/tmpfs_subr.c b/sys/fs/tmpfs/tmpfs_subr.c index dd281d18d87d..b9643266caba 100644 --- a/sys/fs/tmpfs/tmpfs_subr.c +++ b/sys/fs/tmpfs/tmpfs_subr.c @@ -1167,6 +1167,7 @@ tmpfs_alloc_file(struct vnode *dvp, struct vnode **vpp, struct vattr *vap, struct componentname *cnp, const char *target) { int error; + mode_t mode; struct tmpfs_dirent *de; struct tmpfs_mount *tmp; struct tmpfs_node *dnode; @@ -1195,9 +1196,15 @@ tmpfs_alloc_file(struct vnode *dvp, struct vnode **vpp, struct vattr *vap, } else parent = NULL; + mode = vap->va_mode; + if ((mode & S_ISGID) != 0 && + !groupmember(dnode->tn_gid, cnp->cn_cred) && + priv_check_cred(cnp->cn_cred, PRIV_VFS_SETGID) != 0) + mode &= ~S_ISGID; + /* Allocate a node that represents the new file. */ error = tmpfs_alloc_node(dvp->v_mount, tmp, vap->va_type, - cnp->cn_cred->cr_uid, dnode->tn_gid, vap->va_mode, parent, + cnp->cn_cred->cr_uid, dnode->tn_gid, mode, parent, target, vap->va_rdev, &node); if (error != 0) return (error);