From nobody Tue Nov 17 17:06:18 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWNB6zy9z71Rxf for ; Tue, 17 Nov 2026 17:06:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWNB3nV5z4Jb0 for ; Tue, 17 Nov 2026 17:06:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2hWNx0OmWz0uxnIx8piyPSkG36aSA2MygzwD2Cij1Hk=; b=ymjGvseN1BItGEjFmx0uQObbmYCAvQoXBSZiBA3oHIkd3glc7hgcOZLhds+yof3dSNOqqN PkvkJ4O8/GKxcmL2wRMJeCxJCNEXoTgKxU7/DaW3VXIVh0v4smh2txVxS5fiWMidk+zC7O ggcUm4+8COhZWqnnyfro7IA0+A3usU7vaCHWpQwN1l0+kwTQB3VAQD3Kn+J2l8F0xzMMhU xckEiw0jKWSE2gHvOfRG7In2uIhp04L8AM4KXskMxUT6xaikVQT6i9k7YYRNRjSBgcx6+R 8h7j67BA79IetmuliuMGWzJYQL2ahWZZ0WHGRnPgrmUBEbE5jh7sSr5LCp5eYg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935178; b=Tg3Xm8ojRJCqjDuAUbRN7Pa4uJ+a/G1m7YApAUCAgFBjq7q4bit/rvc+MC8Ej4k8CbOPrN NLiU62aOwj8JKM3CfubJOo8JXUjlu8SNCZPpRaFFAz9jLnBGELmk88d+yyDfUlL88Gg8Qz 0XXvk/NgTJDcGQiFLazxPDUggDI3eEhJ7UsDkFlgSeGFhHYdPEvmVsgx5az1uEt3cUyvCV kNybuKex2UbS6K3rcJzRogjysk/xFfur8zc6d3iZsiqm4Ifcr5NeBnqd80072WC/uQPREm O4q882g+hK9Y8KjgaEEvHKpDqAuS66a7xaZ05XuIv8iUP3HUnxVbqafFLFTimg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2hWNx0OmWz0uxnIx8piyPSkG36aSA2MygzwD2Cij1Hk=; b=iDQGDJTXPhaqzxGLrBbrkMF8J8SHInRO5lo6+HGZCBW5d6/jy5WHI5tFbu7L0VOFLNgvBj 618dGoWrJbWuTajqqaD6MevC9k42+gA6+eq1Kb/aEOjKiV7dWV4oYZfTenxYztwRnYld3X domJ2QNasHEGzHyT4wuy7Q9JDAOMBx6ipfqzCrBf98Z/1pdQnWmi3jCTiYGgNHp3Qh0bvi KqovV/DGxbhXNxFO0FjeuXncDOzBPn8fqOR4a0L3EPZ2nIRM31295CUcgG59/6lfqHde4/ dCwZlK4HgnXtLBiYwdZjAlZl9BzzvE1xKVKVD2WOZSUs6S/qyJryEl7ya+n0ZA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWNB39D3zrhJ for ; Tue, 17 Nov 2026 17:06:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d1c2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:06:18 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Kevin Day From: Mark Johnston Subject: git: 564d62460956 - stable/15 - vfs: Check access for O_CREAT directory opens List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 564d6246095603ccf4b07042b564199b8f840c8b Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:06:18 +0000 Message-Id: <6afc898a.1d1c2.7d1993eb@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=564d6246095603ccf4b07042b564199b8f840c8b commit 564d6246095603ccf4b07042b564199b8f840c8b Author: Kevin Day AuthorDate: 2026-11-13 19:49:13 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 16:57:23 +0000 vfs: Check access for O_CREAT directory opens O_CREAT with O_DIRECTORY takes LOOKUP without creating a vnode. Clear O_CREAT there so vn_open_vnode checks read or search access. Add an unprivileged regression test for denied and permitted opens. Approved by: so Security: FreeBSD-SA-26:92.vfs Security: CVE-2026-127746 Reviewed by: kib Fixes: 9e18c9eb27cd --- sys/kern/vfs_vnops.c | 1 + tests/sys/file/fcntlflags_test.c | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index 97f36c1851d1..2a11c5be22d4 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -405,6 +405,7 @@ restart: fmode &= ~O_CREAT; } } else { + fmode &= ~O_CREAT; ndp->ni_cnd.cn_nameiop = LOOKUP; ndp->ni_cnd.cn_flags = open2nameif(fmode, vn_open_flags, ndp->ni_cnd.cn_flags); diff --git a/tests/sys/file/fcntlflags_test.c b/tests/sys/file/fcntlflags_test.c index 15a18c113c4a..15bf460a5887 100644 --- a/tests/sys/file/fcntlflags_test.c +++ b/tests/sys/file/fcntlflags_test.c @@ -25,6 +25,7 @@ */ #include +#include #include #include #include @@ -96,6 +97,37 @@ ATF_TC_BODY(exec_only_sh, tc) basic_tests("/bin/sh", O_EXEC, "O_EXEC"); } +ATF_TC_WITH_CLEANUP(creat_directory_permissions); +ATF_TC_HEAD(creat_directory_permissions, tc) +{ + atf_tc_set_md_var(tc, "require.user", "unprivileged"); +} +ATF_TC_BODY(creat_directory_permissions, tc) +{ + const char *dir = "creat_directory_permissions"; + int fd; + + ATF_REQUIRE(mkdir(dir, 0700) == 0); + ATF_REQUIRE(chmod(dir, 0300) == 0); + ATF_REQUIRE_ERRNO(EACCES, + open(dir, O_RDONLY | O_CREAT | O_DIRECTORY, 0) == -1); + fd = open(dir, O_SEARCH | O_CREAT | O_DIRECTORY, 0); + ATF_REQUIRE(fd >= 0); + ATF_REQUIRE(close(fd) == 0); + + ATF_REQUIRE(chmod(dir, 0400) == 0); + ATF_REQUIRE_ERRNO(EACCES, + open(dir, O_SEARCH | O_CREAT | O_DIRECTORY, 0) == -1); + fd = open(dir, O_RDONLY | O_CREAT | O_DIRECTORY, 0); + ATF_REQUIRE(fd >= 0); + ATF_REQUIRE(close(fd) == 0); +} +ATF_TC_CLEANUP(creat_directory_permissions, tc) +{ + (void)chmod("creat_directory_permissions", 0700); + (void)rmdir("creat_directory_permissions"); +} + ATF_TC_WITHOUT_HEAD(fioasync_dev_null); ATF_TC_BODY(fioasync_dev_null, tc) { @@ -127,6 +159,7 @@ ATF_TP_ADD_TCS(tp) ATF_TP_ADD_TC(tp, write_only_null); ATF_TP_ADD_TC(tp, read_write_null); ATF_TP_ADD_TC(tp, exec_only_sh); + ATF_TP_ADD_TC(tp, creat_directory_permissions); ATF_TP_ADD_TC(tp, fioasync_dev_null); return (atf_no_error());