From nobody Tue Nov 17 17:06:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWN744LRz71RvH for ; Tue, 17 Nov 2026 17:06:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWN72f9Fz4Jcp for ; Tue, 17 Nov 2026 17:06:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Hww1iPf7Zxzx2kW50dyzsdPDBh/y7fc1JxsCTm2Apzk=; b=VuXWlFlFUFCMFpUymHzPSwaKwwen9QTMmpY7Sa0IEKekMbAEruAmtcb1tvfcSu4zGAF1xn wOMNldGNxA0hjMRMWEtD3e2nTQ/h+yAubNlpZyiUJRrB/0K8qxQlZazKTGnSQFwvMarKdE JyfupYgxgxom4+f/EkaM6uE/Qh57vIxmbiGHptZ0VqdkX0UOrrTV0cuy4CFw7/cnp3owyi +rMaQlYvgCwf1+BAJY9xHcxtqze5QBWoWW7wzqYRSK+pZQqmoqpUGx2JM/p2sbbmZ0Bs3+ kXWbNxRbWOj0ypD51d3x0q0r+WKVH/xdhNUjsdFkYFPR+DIL4aHhlmh1HCmITg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935175; b=LNp4qjJ5otgSbMCyg7n5YSWark96LwSLk/8h6GSWzcz4+97ZvPr75p95NsR7g//LwvD4/d 4wDkcOWxr7YH2BHPMkG5XSuq0/ph5ri6c/olgES26wx9/Dsu3sxgRCGzKWlejZII54gSY9 0p85OCJ3d+LIklKg5Brk/zewBCzN8XiVAALDtqvA0dM+6uSsQFnqgsuu3TAYXvrrs+XBtJ Iz7ofRgFitkTRPqDF3botfDGVIHajC3JqgXtobgsOUq94P7EvPn/fPw3xHPkaxf/gD4Fca +yAA4HINVlo7wzcquycsosOWFlyEqQ6VdI/jMx6oK6nuMwKQtgl31HzStgCA8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Hww1iPf7Zxzx2kW50dyzsdPDBh/y7fc1JxsCTm2Apzk=; b=IZRb5fRTJuErSkcHvR59LjOdmZVkZ8uk8d95CRmw5TJ0hibSdpsiv3sWXUkPTb6hI4AYzL KYMnfaoJkb54dziPOWqSf9CmIx0lkckjkyL/fS/uRp1b2R6vXCwaMrmzEQ9WhU5cAtnnZX Cs/iGx+DmbrBWTFkk4sCRhPmZdk56M7HsVy3qE2VcKo2qMNko2jlS5sIqu6HosbokJkobs 4eQpM4IJhhS0U4QG8YgGPn1PtEq7duNUI44UbeEdtAru1kBc7Z4Ka1iSb+E8VZsRHCStj+ kx/7KcxiCZhMOIjWhy8EPExcInDI6CY+3rkxhFfVI1m9wSDmN1Bmlp+BCvCviA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWN7222hzrhG for ; Tue, 17 Nov 2026 17:06:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d3ca by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:06:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Konstantin Belousov From: Mark Johnston Subject: git: a95917bab311 - stable/15 - fdescfs: add VOP_ACCESS() implementation List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: a95917bab31131e65c71b32be80363a94a9cb509 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:06:15 +0000 Message-Id: <6afc8987.1d3ca.5b4d3dea@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=a95917bab31131e65c71b32be80363a94a9cb509 commit a95917bab31131e65c71b32be80363a94a9cb509 Author: Konstantin Belousov AuthorDate: 2026-11-06 00:00:19 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 16:57:23 +0000 fdescfs: add VOP_ACCESS() implementation kern_truncate() checks VWRITE only through VOP_ACCESS() on the fdescfs vnode, which always succeeded until now. So a file opened read-only could be truncated, even if the caller has no write permission for it. Note that reopen on mounts without nodup already performs the permission checks in dupfdopen(). For nodup mounts, the VOP_ACCESS() implementation of the real filesystem is used. Approved by: so Security: FreeBSD-SA-26:91.fdescfs Security: CVE-2026-127745 Reported by: Kevin Day Sponsored by: The FreeBSD Foundation --- sys/fs/fdescfs/fdesc_vnops.c | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/sys/fs/fdescfs/fdesc_vnops.c b/sys/fs/fdescfs/fdesc_vnops.c index 0ff11591cabf..d29ce4236eac 100644 --- a/sys/fs/fdescfs/fdesc_vnops.c +++ b/sys/fs/fdescfs/fdesc_vnops.c @@ -73,11 +73,12 @@ static vop_readdir_t fdesc_readdir; static vop_readlink_t fdesc_readlink; static vop_reclaim_t fdesc_reclaim; static vop_setattr_t fdesc_setattr; +static vop_access_t fdesc_access; static struct vop_vector fdesc_vnodeops = { .vop_default = &default_vnodeops, - .vop_access = VOP_NULL, + .vop_access = fdesc_access, .vop_getattr = fdesc_getattr, .vop_lookup = fdesc_lookup, .vop_open = fdesc_open, @@ -704,3 +705,34 @@ out: vn_lock(vn, lockflags | LK_RETRY); return (error); } + +static int +fdesc_access(struct vop_access_args *va) +{ + struct vnode *vp; + struct fdescnode *fd; + struct file *fp; + int error, flags, locked; + + vp = va->a_vp; + fd = VTOFDESC(vp); + if (fd->fd_type == Froot) + return (0); + error = fget(va->a_td, fd->fd_fd, &cap_no_rights, &fp); + if (error != 0) + return (error); + flags = 0; + if ((va->a_accmode & VREAD) != 0) + flags |= FREAD; + if ((va->a_accmode & (VWRITE | VAPPEND)) != 0) + flags |= FWRITE; + if ((va->a_accmode & VEXEC) != 0) + flags |= FEXEC; + if ((flags & fp->f_flag) != flags) + error = EACCES; + locked = VOP_ISLOCKED(vp); + VOP_UNLOCK(vp); + fdrop(fp, va->a_td); + vn_lock(vp, locked | LK_RETRY); + return (error); +}