From nobody Tue Nov 17 17:06:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWN33mKPz71RxL for ; Tue, 17 Nov 2026 17:06:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWN30xmtz4JTH for ; Tue, 17 Nov 2026 17:06:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rvrEHnllsJ1/lFxRtwRpMBDojb6GlPHPAEU3VRXMiqM=; b=D190q0e1fwBbmIkIiaIqyZTFi0F8CvjAiU7H7s4ymdd8toCL+laQgvyGoACBnOS5JxLLdt zKEiUEzjI9FjBunpQFspvtQyHLDXiI1U51Thqq8d1nv1ajk2Va2asxE1hJlDxhtXmVlcM6 nRrhE1x/SCQDvwbJ3IUqsnq68POX8ZBw0X+Afn2snCArcBHv/dXTnImR5yypAVvQOvoK4c 72Dc+tCwn9nasEd2ZnpKza+UlczjI0aN4warFroyplQ0feJJY7XSG0sPIN7cLseXyxFeuC jxT1kN6AMau+NjH1DiD+z5+UPP6sSwVdb1w6qY5jGoiXulPXHJUb8TCKcHD6Mg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935171; b=wVsR5g/+ps0xAR7oiALKqzDTyCO3Fte8bWo4MJQrO7G8zXPLzXeFee1lGJHaGQB79EyjSm IQxMo7Wnjwj4W3Y8orc6VyPZFCsxSKefzca82LSy9mHUSVHtjgoeKSvKfaHIaLQ8LfiDS6 vBQljOyB7c1gAZR770rvBWvWn32s6d3gTuj5LvAl9K9SuQ2f2CNxFKV8uEGOeIWuos1gwD Yqt1GpsTnuBn2Z5zm9l3Yz8GmgY3TMtejkzv4sbCncAQaAAyd1nMVFt+M9jxuzDBSD4DM8 imfJZ8I+mgqWiYXOPYSl7KdkzrQOAymajhLQxSGC8MNXNXMDPcD7V8S/6fUnRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rvrEHnllsJ1/lFxRtwRpMBDojb6GlPHPAEU3VRXMiqM=; b=LTWwu7Dc63nMsShOzmMSfF6d9Ji4xdkpGTex7HXk7VECS1McseZvYhN7XlKv6a4zgLhXSw JB9N+5MaHHxqMiycqVec/Q3A3/63x5z/YobXXydGXBjoEkQRQbF5lEmFrUyW3haDkfr4JC tpiwtWOMzcLDAoLy/J2lCNSfrI6st52ZFCCfCLRAVuOEuAg+EZXz4sCzGKvBtR5FWtoNvx 7TVamepT2m11pKO8K0di8jJHWl/6YeBXsjwjuNU67KtdpMZSQ1a1fefuGH1k6sGgChgKnP BY8wV2BU3tyDkgSXTo6GttmpIj6eyV2rDNgW1zvErVbl7e+07AV6ubKHDT4YPw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWN30ZB2zrhC for ; Tue, 17 Nov 2026 17:06:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f568 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:06:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Maxim Konovalov From: Mark Johnston Subject: git: 34a446690f25 - stable/15 - bsnmp: reject an oversized vacmViewTreeFamilyMask List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 34a446690f256919559607fe763f7cb038dd9926 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:06:11 +0000 Message-Id: <6afc8983.1f568.3e4a81ba@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=34a446690f256919559607fe763f7cb038dd9926 commit 34a446690f256919559607fe763f7cb038dd9926 Author: Maxim Konovalov AuthorDate: 2026-11-13 03:07:48 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 16:57:23 +0000 bsnmp: reject an oversized vacmViewTreeFamilyMask The SET handler for vacmViewTreeFamilyMask compared the value length against the 16-byte view->mask, but the check had no statement of its own: it guarded the following malloc() instead of rejecting the request. A value longer than 16 bytes was therefore copied into view->mask with memcpy(), overflowing struct vacm_view. Add the missing return so an over-long value is refused with wrongValue. Approved by: so Security: FreeBSD-SA-26:89.bsnmp Security: CVE-2026-127743 Reviewed by: harti Fixes: 135f7de5ddb6 --- contrib/bsnmp/snmp_vacm/vacm_snmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/bsnmp/snmp_vacm/vacm_snmp.c b/contrib/bsnmp/snmp_vacm/vacm_snmp.c index 39371176e493..29d1b8ffcb1e 100644 --- a/contrib/bsnmp/snmp_vacm/vacm_snmp.c +++ b/contrib/bsnmp/snmp_vacm/vacm_snmp.c @@ -490,6 +490,7 @@ op_vacm_view(struct snmp_context *ctx, struct snmp_value *val, uint32_t sub, switch (val->var.subs[sub - 1]) { case LEAF_vacmViewTreeFamilyMask: if (val->v.octetstring.len > sizeof(view->mask)) + return (SNMP_ERR_WRONG_VALUE); ctx->scratch->ptr1 = malloc(sizeof(view->mask)); if (ctx->scratch->ptr1 == NULL) return (SNMP_ERR_GENERR);