From nobody Tue Nov 17 17:05:56 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWMm5nWJz71Rcg for ; Tue, 17 Nov 2026 17:05:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWMm2m6Xz4JJn for ; Tue, 17 Nov 2026 17:05:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y0AS4/2CGuNqXBhkxrcO7IM0XM3qqXxyYEgoLyaiEHc=; b=XyLxWxSFjVwnMPCR+MCEbVk88sy5Ad18iAfR7SMOK1Ltp1g43ZPKA3g82eG8BE/4yyMhPo 982cWlqv/+u82KeKL00WEc58Dte2f6XItRN0JHPCFc8WZJFXwdb3BbVXRWrj1AWWvROZCY hMq6GWjie6ljLCqsqKamPUK1HFybu6mlYDFeTCSjBSRPGEq8z4NMvMTDFFqonniZskwy8B Fm58hGzC4r09Vbo+qTe/qUWc1XHXeTrqNuoxQkBGTVjQXG1ZUy7gpmqRH0b+foQJB9bMCw xSc3CTMfXDJiyZpqmWtrGgaMFLq19iN2MLDXQExB8EpAsesgmdJ+At1kM9nNEg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935156; b=JwQAqVxXE1ZWRNJ059Xpk7MvCFuIlPmDusxplIH0VxywmJA8Iwbr2Uhx1uOktj+jtLSDtk miHzfVz21eZfXAD/WsrvaYWHXHHb7hdNiO1tvLRRKhxXLiRaUEFdaysMeC3Sl+LApHccXw bSyMBCBiIerZfnwCKftyqxhsotbE5FixelOJ3O//aWkoQdMdpjmkPL3Mfrx96mEoMgd+UE 8poFaSThEEvqq0PcOFhGE1bXnCMCAHxWGLSsJWgzgvUEZzrfWHnI/HZKwBFrUg38fw2py8 cr7B9n6a7ldFaS3sd5HWxzQCHBl2PCeTx/lc2qZKWyajAjyVmQsz71tUc/bC6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y0AS4/2CGuNqXBhkxrcO7IM0XM3qqXxyYEgoLyaiEHc=; b=UIgUoMLch0dPiamY8csFd2iIbSkMVZp6GddlExJnWRL+22xLo8ycwxRtR/8Xci3cSI9iWb EWmPyUd4R6YqprkUgJCPvC0couKuXVGxKsyaHARMrmRSsAsXoeUD6mISugztLJA7NdiAPU HqJxpscUn4O4xW9ZFGyTAl/urgr3JgqCywbckDPcQCumIkYsUOTSrnhrkvUgSQpxtt+oc8 SqhbnW7VfxtaKxmrRdnJUWNcAy1MeUCEwsm75OWUQBJnUgA3MYyF1d4zLgQ4V0tNYIdl1m XGqYmUbrqCiX7KxGO4BOx8ayR/F7n4LE72LZRWtSzbT4zi7mOuxTUkRXC4d8jQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWMm2QlDzr9G for ; Tue, 17 Nov 2026 17:05:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f7cc by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:05:56 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Konstantin Belousov From: Mark Johnston Subject: git: 3111810e08af - stable/15 - lookup: hold ni_rbeneath_dpp List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 3111810e08af18fd546cc0065c773e6ddb254270 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:05:56 +0000 Message-Id: <6afc8974.1f7cc.1730408d@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=3111810e08af18fd546cc0065c773e6ddb254270 commit 3111810e08af18fd546cc0065c773e6ddb254270 Author: Konstantin Belousov AuthorDate: 2026-10-23 03:59:15 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 16:57:22 +0000 lookup: hold ni_rbeneath_dpp The vnode is held to ensure the validity of the pointer. Approved by: so Security: FreeBSD-SA-26:81.vfs Reported by: pjd Sponsored by: The FreeBSD Foundation --- sys/kern/vfs_lookup.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sys/kern/vfs_lookup.c b/sys/kern/vfs_lookup.c index 9b000aeea65d..b1a39bf54bdb 100644 --- a/sys/kern/vfs_lookup.c +++ b/sys/kern/vfs_lookup.c @@ -261,6 +261,10 @@ nameicap_cleanup(struct nameidata *ndp, int error) vfs_rel(mp); ndp->ni_nctrack_mnt = NULL; } + if (ndp->ni_rbeneath_dpp != NULL) { + vdrop(ndp->ni_rbeneath_dpp); + ndp->ni_rbeneath_dpp = NULL; + } } /* @@ -422,8 +426,10 @@ namei_setup(struct nameidata *ndp, struct vnode **dpp, struct pwd **pwdp) NI_LCF_CAP_DOTDOT; } } - if (error == 0 && (ndp->ni_lcf & NI_LCF_STRICTREL) != 0) + if (error == 0 && (ndp->ni_lcf & NI_LCF_STRICTREL) != 0) { ndp->ni_rbeneath_dpp = *dpp; + vholdnz(*dpp); + } /* * If we are auditing the kernel pathname, save the user pathname.