From nobody Tue Nov 17 17:05:29 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWMG4Pw1z71RXC for ; Tue, 17 Nov 2026 17:05:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWMG0Czdz4HTk for ; Tue, 17 Nov 2026 17:05:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cnBj7sg8TyQ1VsxCbTqYaTNa+h0wkK0TUUqFCBbyLU4=; b=UG/T0/lbH6TM+4gxfLG9gahZEce8fE07JAmMh47IyutdpgH8kr7vwUp0uK1kIHn7omVv6L LYvieourjXWSfOmlbbMceAUOOk0NJtRKozIkNA6VYjBPc97lbTprueOzC/5K2sJz6aUvKp k6C2845YLQ7enGtX4GVU8gjRVB4TTO7ZnPWnVJmFRRrDSrEiY+Bd9dpx7WQezn46Wku/YB kbuUBrdAHUR2wsTZlg8vfyCNu4LEeOxlX1g5anDYYBNDGljNWvPw2u+JwJP0J1CJYGg4aj jeLPmoN4klEhHMvXwP03v6kG/pxbf5jTMuuzCeSchZbQRYkU93Drwy7nsPVMmA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935130; b=vIHsAozNI4/9RxA5dSiarP152tv0nUnsEp9g9CMlrxonUsSFnV3i2e7wMu2kk4M0iYDvfR G8cHUwMiIcgHAZVPwdnvYZdANS+IVfnWCyQZUDPml55z1UMQUDxxDEWrTDR06TlC/++Brp SyoOt3qSZGyxXaE0aGKasnLXs2Q/4+214uxjvXdh8dUIc2nBdmshGReL/4jzpYiV9cFjjt 6E3WbioW31uLF55csu2S4lv6n6dbYZA40EwyuDNmZHoIjyDGHdyCxKvTCZWxZjT95jizVB iz+9gteGXXS3kjUmEPIe+6flVXyJmtJqcbKjzFNnbuf8E1ma9GtYz4hYjqa2hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cnBj7sg8TyQ1VsxCbTqYaTNa+h0wkK0TUUqFCBbyLU4=; b=EZwm95g+Dl70ByKHv/349JwJvygE0nElBzQ+OjIz4O8KrJoKek8TXpAL53So5UibP5iYjB nMkcDZrWU8FaP17NDLkOUMXa65gL40WuKVfEYo6DcM1FcXcNEjmeUmU/NmuVBQ0OEneHqz SmBXilz2s/6zy1KPhzeVOTei5OBGIkxoSeVpN7/uoUcoWLHhB7OauWOOJW47vFT2ptQMWl kYZf9gtQUVUMQ045M8DIH3gJCARIf5C0n48GSqHd32lEIlbAtV0CQmkMlwL3NNcbpTlcvp ov9WPMWvOvix6lZrIbD5MhSC5ZOStotVmyccG/V3Lc2c1wyKRWGkg6OKqm6VUw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWMF6jCHzrh1 for ; Tue, 17 Nov 2026 17:05:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e4d6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:05:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Kevin Day From: Mark Johnston Subject: git: 36af45c63ddf - releng/14.5 - tmpfs: Clear setgid on creation by nonmembers List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.5 X-Git-Reftype: branch X-Git-Commit: 36af45c63ddfe4c56ec5c4aea4d33ea6d72be417 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:05:29 +0000 Message-Id: <6afc8959.1e4d6.66bbc8ee@gitrepo.freebsd.org> The branch releng/14.5 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=36af45c63ddfe4c56ec5c4aea4d33ea6d72be417 commit 36af45c63ddfe4c56ec5c4aea4d33ea6d72be417 Author: Kevin Day AuthorDate: 2026-11-14 01:40:14 +0000 Commit: Mark Johnston CommitDate: 2026-11-16 21:17:13 +0000 tmpfs: Clear setgid on creation by nonmembers New tmpfs nodes inherit their parent directory group. Clear S_ISGID when the creator is not a member of that group and lacks PRIV_VFS_SETGID, matching UFS and tmpfs chmod behavior. Approved by: so Security: FreeBSD-SA-26:94.tmpfs Security: CVE-2026-127749 Reviewed by: kib --- sys/fs/tmpfs/tmpfs_subr.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sys/fs/tmpfs/tmpfs_subr.c b/sys/fs/tmpfs/tmpfs_subr.c index bca6bf911eb1..40e242a07dd0 100644 --- a/sys/fs/tmpfs/tmpfs_subr.c +++ b/sys/fs/tmpfs/tmpfs_subr.c @@ -1164,6 +1164,7 @@ tmpfs_alloc_file(struct vnode *dvp, struct vnode **vpp, struct vattr *vap, struct componentname *cnp, const char *target) { int error; + mode_t mode; struct tmpfs_dirent *de; struct tmpfs_mount *tmp; struct tmpfs_node *dnode; @@ -1192,9 +1193,15 @@ tmpfs_alloc_file(struct vnode *dvp, struct vnode **vpp, struct vattr *vap, } else parent = NULL; + mode = vap->va_mode; + if ((mode & S_ISGID) != 0 && + !groupmember(dnode->tn_gid, cnp->cn_cred) && + priv_check_cred(cnp->cn_cred, PRIV_VFS_SETGID) != 0) + mode &= ~S_ISGID; + /* Allocate a node that represents the new file. */ error = tmpfs_alloc_node(dvp->v_mount, tmp, vap->va_type, - cnp->cn_cred->cr_uid, dnode->tn_gid, vap->va_mode, parent, + cnp->cn_cred->cr_uid, dnode->tn_gid, mode, parent, target, vap->va_rdev, &node); if (error != 0) return (error);