From nobody Tue Nov 17 17:05:24 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWM91hrVz71RT5 for ; Tue, 17 Nov 2026 17:05:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWM85X0xz4HBt for ; Tue, 17 Nov 2026 17:05:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+9+Ul2BZTH+Ub8/YuJmAp2xla933rOl5FOS26GunRUA=; b=Cwv0p/qvzdOcx6BlW1logE+siBRaljDqRYI8dtQVJJ2JdmqTzK0Ovq0uBz3FWuzD8CVd5P V0i/tLmEJFkGphn9iDclbFwc6au7QVdapuIUnsauSCVXH1uW1qKucE33VUSkPxtHDUWo4V 7FFEK3R7Y8Nzl+PIwjPYo7HUpBJvG+Zo0n7/8ulflJzzwfVLsCF5fTqw5Cpo75m7NAh5rQ kxw/jzut/cE7/BiNLZQdB6JOOiVL4dWJnKcOB3j4f8BE8VMkkEI0il65MxM9ZYGQwR/BXK zu7tlMwuDo0m29Kc47emsHV/WNJkjJad+wZ2H+WZfFM/Jg3ylFN0P/9dDsYI6g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935124; b=wZcsXBodkJsGsuJqaBOBYm6VXYC4tkADbS1/8hni2ksSmLmomJf1OeEJI4nDhvOMvMUYDs CAHjFcWGh5k1SYcgFdgz/AO34NdnV/yZJRtYAWJb2jKqZ1oswjqtWuF14U/2khkO98j3W9 1cX+q60sDlDLFdr18jvy9DeP+htUY5hzssC7l0HHcqbncb+ab1hzYYhGeaJjEZAG+lFENG mDEcotLiL9lX8ZlQLHSD3Dpm01JzkpSDiiSccbDsxXxLAMFnaBRpZz3BIX8yn5JzOJKFag kZyorhyG9yxJ0j1fYm4ueub1vjBOzjPtgZTp2BZ/70crGuDsB+j1O4fwUK7o/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+9+Ul2BZTH+Ub8/YuJmAp2xla933rOl5FOS26GunRUA=; b=OLhsUnU4xAH77T74p2sGaiGuMxIzbl5raaAEd7Q0jKML/fiIBwzoP6gjtPutcXCz31KwdG ncPySfwDf89pAm3l2mN2rp62aFpDDPlS+qNvHUs3+UA6qkXtq5guKfQmcsc+LSfmsYdeV7 8QOk7ieIBHe3yfZBrkOKMXMUV84K4gd14ybviS+Pj7Tq2Si156yUMtZyGlax4hb5kyXsud hnhR5CKDd1/VYgI6UXET9ZUE83Rr3186z2gmIucfwcn8Poq4dV7eDX8pEi6OYlaQ/PaUjZ XzzrTrS+0KnLsMSIcWxh5z2HNIlixgwFXos2F5eQBrBUcj52lO2nLzE283wbAw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWM84p1zzr7B for ; Tue, 17 Nov 2026 17:05:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f8fd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:05:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Konstantin Belousov From: Mark Johnston Subject: git: c7cc8cf78a7f - releng/14.5 - fdescfs: add VOP_ACCESS() implementation List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.5 X-Git-Reftype: branch X-Git-Commit: c7cc8cf78a7f3624431d41a50c80f7c9bd420cc4 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:05:24 +0000 Message-Id: <6afc8954.1f8fd.4424a159@gitrepo.freebsd.org> The branch releng/14.5 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=c7cc8cf78a7f3624431d41a50c80f7c9bd420cc4 commit c7cc8cf78a7f3624431d41a50c80f7c9bd420cc4 Author: Konstantin Belousov AuthorDate: 2026-11-06 00:00:19 +0000 Commit: Mark Johnston CommitDate: 2026-11-16 21:17:13 +0000 fdescfs: add VOP_ACCESS() implementation kern_truncate() checks VWRITE only through VOP_ACCESS() on the fdescfs vnode, which always succeeded until now. So a file opened read-only could be truncated, even if the caller has no write permission for it. Note that reopen on mounts without nodup already performs the permission checks in dupfdopen(). For nodup mounts, the VOP_ACCESS() implementation of the real filesystem is used. Approved by: so Security: FreeBSD-SA-26:91.fdescfs Security: CVE-2026-127745 Reported by: Kevin Day Sponsored by: The FreeBSD Foundation --- sys/fs/fdescfs/fdesc_vnops.c | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/sys/fs/fdescfs/fdesc_vnops.c b/sys/fs/fdescfs/fdesc_vnops.c index 7926395d6954..f1e204d9b2d0 100644 --- a/sys/fs/fdescfs/fdesc_vnops.c +++ b/sys/fs/fdescfs/fdesc_vnops.c @@ -75,11 +75,12 @@ static vop_readdir_t fdesc_readdir; static vop_readlink_t fdesc_readlink; static vop_reclaim_t fdesc_reclaim; static vop_setattr_t fdesc_setattr; +static vop_access_t fdesc_access; static struct vop_vector fdesc_vnodeops = { .vop_default = &default_vnodeops, - .vop_access = VOP_NULL, + .vop_access = fdesc_access, .vop_getattr = fdesc_getattr, .vop_lookup = fdesc_lookup, .vop_open = fdesc_open, @@ -706,3 +707,34 @@ out: vn_lock(vn, lockflags | LK_RETRY); return (error); } + +static int +fdesc_access(struct vop_access_args *va) +{ + struct vnode *vp; + struct fdescnode *fd; + struct file *fp; + int error, flags, locked; + + vp = va->a_vp; + fd = VTOFDESC(vp); + if (fd->fd_type == Froot) + return (0); + error = fget(va->a_td, fd->fd_fd, &cap_no_rights, &fp); + if (error != 0) + return (error); + flags = 0; + if ((va->a_accmode & VREAD) != 0) + flags |= FREAD; + if ((va->a_accmode & (VWRITE | VAPPEND)) != 0) + flags |= FWRITE; + if ((va->a_accmode & VEXEC) != 0) + flags |= FEXEC; + if ((flags & fp->f_flag) != flags) + error = EACCES; + locked = VOP_ISLOCKED(vp); + VOP_UNLOCK(vp); + fdrop(fp, va->a_td); + vn_lock(vp, locked | LK_RETRY); + return (error); +}