From nobody Tue Nov 17 17:04:33 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWL96P1Cz71RLY for ; Tue, 17 Nov 2026 17:04:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWL92z7hz4FtK for ; Tue, 17 Nov 2026 17:04:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CDgxallZd4DOndgOKVTgYZz3iqrkuWjkZyQ2+i1bAxM=; b=IoTEWMJXwLiJ9g3/v+2EpivdTARatNicp9Kg5Zh0KVopdR029IfMTSPzLGXX5vPAuEIMG2 /vq5mLz4qnkEYNdwA/de6f0QlcR2GjrD8JVuBB5pchH2zfQHnlha2t+FfDenRKoDa9cV+l vWNaYu5mu/7O6xYGPgooxSTP1fQguuRqCb84PO0EYdwiv6YnpWaDRgc7egUFXlG6qSoOKs Hl83HitJWHm6XSZLQh7ci75b3URCOunVQs7w6qa+fVOHI4Mr52Td1NqXe+zU/P6afPPqsY WzfBLSXHBYJIe0nbWy/l6Fw1/532AlG8NGtxll5onAIP8JKXlx3fH1x6mbzQOA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935073; b=V+AurGbVfN1JxYqZQLj8UEijFDtDFmzrJs6Vc9Qh6OVKt+04eG5uSDhXAZuC1lOi1Sy6t9 Vsa4UNiKOSJlFexwsqcx0QVNyU7/X19+TyoY6T0lAtecFSfp31wanhg9sbhz3Mbi51W2bK +p1esE/RSvw1Dbo9sLw5hLsGdoJoM9JYhfLDN+8cYBchP8mzf7YhCOGj3y+7kPwzUv6Ywc 6DFfENrmm7XLTCXhNZmfQkQrz+O7Z0s/K2a2u5o3g2ktUjAcEs6m3uMANL6Isw3z02otAS 3YWRoPiGcjCqlV8SbLSzz4pu30rxB16nc52S2xuu+tY06dvWan38jVkE8cz0Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CDgxallZd4DOndgOKVTgYZz3iqrkuWjkZyQ2+i1bAxM=; b=Zn0t67dmhHGFdnArIjjXmGHqYeToEj2jQApwpFV8KhbpkkECj2vBPtJqPzKF76IqDWIog0 nT24tnmLwqt7HdwBjteRi9O6K+jL3V0D6K5qUeoR20v+vrhzXLN8cvCvxFaabg5E31skNC UFwMhipk5X/77UfteFrUGrESbUAFB7xuAdAtCGEuFbX1kWt98zezdxzUBeRtmRYhMHOQ6p +rn0bdBGq/pl/zHh6+wOSHYKJPm8972tOUBHaSI3DDmu6/DZYYqqFH4L/fgZtdC/toJq9r 1iV3gfMooUeu+4yxzHCe4jMje8lyiwd4ABhB/AqHw9RKU5exSyE+RsNDEUnIOA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWL91bFWzrfl for ; Tue, 17 Nov 2026 17:04:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d15a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:04:33 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 27ce018206b2 - releng/14.4 - tmpfs tests: Add regression tests for setgid handling List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.4 X-Git-Reftype: branch X-Git-Commit: 27ce018206b2ad368ea73e64c86ed365e03654ec Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:04:33 +0000 Message-Id: <6afc8921.1d15a.2bd4dfcb@gitrepo.freebsd.org> The branch releng/14.4 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=27ce018206b2ad368ea73e64c86ed365e03654ec commit 27ce018206b2ad368ea73e64c86ed365e03654ec Author: Mark Johnston AuthorDate: 2026-11-15 16:03:13 +0000 Commit: Mark Johnston CommitDate: 2026-11-16 21:16:23 +0000 tmpfs tests: Add regression tests for setgid handling Approved by: so Security: FreeBSD-SA-26:94.tmpfs Sponsored by: The FreeBSD Foundation --- tests/sys/fs/tmpfs/Makefile | 3 + tests/sys/fs/tmpfs/setgid_test.c | 258 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 261 insertions(+) diff --git a/tests/sys/fs/tmpfs/Makefile b/tests/sys/fs/tmpfs/Makefile index 106b28c7c463..b5f600c420a5 100644 --- a/tests/sys/fs/tmpfs/Makefile +++ b/tests/sys/fs/tmpfs/Makefile @@ -7,6 +7,9 @@ TESTSDIR= ${TESTSBASE}/sys/fs/${FILESYSTEM} TESTSRC= ${SRCTOP}/contrib/netbsd-tests/fs/${FILESYSTEM} +ATF_TESTS_C+= setgid_test +LIBADD.setgid_test+= util + # XXX: uses /dev/MAKEDEV to create pseudo /dev/{null,zero} character devices #NETBSD_ATF_TESTS_SH+= devices_test NETBSD_ATF_TESTS_SH+= create_test diff --git a/tests/sys/fs/tmpfs/setgid_test.c b/tests/sys/fs/tmpfs/setgid_test.c new file mode 100644 index 000000000000..ef26288eba94 --- /dev/null +++ b/tests/sys/fs/tmpfs/setgid_test.c @@ -0,0 +1,258 @@ +/* + * Copyright (c) 2026 Mark Johnston + * + * This software was written by Mark Johnston under sponsorship from + * the FreeBSD Foundation. + * + * SPDX-License-Identifier: BSD-2-Clause + */ + +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include + +#define DIR_GID 54320 /* group owning the test directory */ +#define TEST_UID 54321 +#define TEST_GID 54322 + +#define TESTDIR "mnt/dir" +#define TESTPATH TESTDIR "/node" + +enum nodetype { + NODE_FILE, + NODE_FIFO, +}; + +static void +build_iovec(struct iovec **iov, int *iovlen, const char *name, void *val, + size_t len) +{ + int i; + + if (*iovlen < 0) + return; + i = *iovlen; + *iov = realloc(*iov, sizeof **iov * (i + 2)); + if (*iov == NULL) { + *iovlen = -1; + return; + } + (*iov)[i].iov_base = strdup(name); + (*iov)[i].iov_len = strlen(name) + 1; + i++; + (*iov)[i].iov_base = val; + if (len == (size_t)-1) { + if (val != NULL) + len = strlen(val) + 1; + else + len = 0; + } + (*iov)[i].iov_len = (int)len; + *iovlen = ++i; +} + +static void +free_iovec(struct iovec **iov, int *iovlen) +{ + int i; + + for (i = 0; i < *iovlen; i += 2) + free((*iov)[i].iov_base); + free(*iov); +} + +/* + * Mount tmpfs and make a world-writeable directory. + */ +static void +mount_tmpfs(void) +{ + struct iovec *iov; + char errmsg[256]; + int error, iovlen; + + iov = NULL; + iovlen = 0; + + ATF_REQUIRE(mkdir("mnt", 0755) == 0); + build_iovec(&iov, &iovlen, "fstype", __DECONST(char *, "tmpfs"), + (size_t)-1); + build_iovec(&iov, &iovlen, "fspath", __DECONST(char *, "mnt"), + (size_t)-1); + build_iovec(&iov, &iovlen, "errmsg", errmsg, sizeof(errmsg)); + errmsg[0] = '\0'; + error = nmount(iov, iovlen, 0); + ATF_REQUIRE_MSG(error == 0, "nmount: %s", + errmsg[0] != '\0' ? errmsg : strerror(errno)); + free_iovec(&iov, &iovlen); + + ATF_REQUIRE(mkdir("mnt/dir", 0777) == 0); + ATF_REQUIRE(chown("mnt/dir", 0, DIR_GID) == 0); + ATF_REQUIRE(chmod("mnt/dir", 0777) == 0); +} + +static void +unmount_tmpfs(void) +{ + int error; + + error = unmount("mnt", MNT_FORCE); + if (error != 0) + warn("unmount"); +} + +/* + * Try to create a setgid file, and return true if the setgid bit was applied. + */ +static bool +create_setgid(enum nodetype type, uid_t uid, gid_t gid, const gid_t *groups, + int ngroups) +{ + struct stat sb; + pid_t pid; + int fd, status; + + pid = fork(); + ATF_REQUIRE(pid != -1); + if (pid == 0) { + if (setgroups(ngroups, groups) != 0 || + setgid(gid) != 0 || + setuid(uid) != 0) + _exit(errno); + (void)umask(0); + switch (type) { + case NODE_FILE: + fd = open("mnt/dir/a", O_WRONLY | O_CREAT | O_EXCL, + 02755); + if (fd < 0) + _exit(errno); + (void)close(fd); + break; + case NODE_FIFO: + if (mkfifo("mnt/dir/a", 02644) != 0) + _exit(errno); + break; + } + _exit(0); + } + ATF_REQUIRE(waitpid(pid, &status, 0) == pid); + ATF_REQUIRE_MSG(WIFEXITED(status), "status %#x", status); + ATF_REQUIRE_MSG(WEXITSTATUS(status) == 0, "child failed: %d", + WEXITSTATUS(status)); + + ATF_REQUIRE(stat("mnt/dir/a", &sb) == 0); + ATF_REQUIRE_EQ(uid, sb.st_uid); + ATF_REQUIRE_EQ(DIR_GID, sb.st_gid); + return ((sb.st_mode & S_ISGID) != 0); +} + +ATF_TC_WITH_CLEANUP(nonmember_file); +ATF_TC_HEAD(nonmember_file, tc) +{ + atf_tc_set_md_var(tc, "require.user", "root"); +} +ATF_TC_BODY(nonmember_file, tc) +{ + const gid_t groups[] = { TEST_GID }; + + mount_tmpfs(); + ATF_REQUIRE_MSG(!create_setgid(NODE_FILE, TEST_UID, TEST_GID, groups, + nitems(groups)), "S_ISGID was not cleared"); +} +ATF_TC_CLEANUP(nonmember_file, tc) +{ + unmount_tmpfs(); +} + +ATF_TC_WITH_CLEANUP(nonmember_fifo); +ATF_TC_HEAD(nonmember_fifo, tc) +{ + atf_tc_set_md_var(tc, "require.user", "root"); +} +ATF_TC_BODY(nonmember_fifo, tc) +{ + const gid_t groups[] = { TEST_GID }; + + mount_tmpfs(); + ATF_REQUIRE_MSG(!create_setgid(NODE_FIFO, TEST_UID, TEST_GID, groups, + nitems(groups)), "S_ISGID was not cleared"); +} +ATF_TC_CLEANUP(nonmember_fifo, tc) +{ + unmount_tmpfs(); +} + +ATF_TC_WITH_CLEANUP(member_file); +ATF_TC_HEAD(member_file, tc) +{ + atf_tc_set_md_var(tc, "require.user", "root"); +} +ATF_TC_BODY(member_file, tc) +{ + const gid_t groups[] = { DIR_GID }; + + mount_tmpfs(); + ATF_REQUIRE_MSG(create_setgid(NODE_FILE, TEST_UID, DIR_GID, groups, + nitems(groups)), "S_ISGID was cleared"); +} +ATF_TC_CLEANUP(member_file, tc) +{ + unmount_tmpfs(); +} + +ATF_TC_WITH_CLEANUP(supplementary_member_file); +ATF_TC_HEAD(supplementary_member_file, tc) +{ + atf_tc_set_md_var(tc, "require.user", "root"); +} +ATF_TC_BODY(supplementary_member_file, tc) +{ + const gid_t groups[] = { DIR_GID }; + + mount_tmpfs(); + ATF_REQUIRE_MSG(create_setgid(NODE_FILE, TEST_UID, TEST_GID, groups, + nitems(groups)), "S_ISGID was cleared"); +} +ATF_TC_CLEANUP(supplementary_member_file, tc) +{ + unmount_tmpfs(); +} + +ATF_TC_WITH_CLEANUP(privileged_file); +ATF_TC_HEAD(privileged_file, tc) +{ + atf_tc_set_md_var(tc, "require.user", "root"); +} +ATF_TC_BODY(privileged_file, tc) +{ + const gid_t groups[] = { TEST_GID }; + + mount_tmpfs(); + ATF_REQUIRE_MSG(create_setgid(NODE_FILE, 0, TEST_GID, groups, + nitems(groups)), "S_ISGID was cleared"); +} +ATF_TC_CLEANUP(privileged_file, tc) +{ + unmount_tmpfs(); +} + +ATF_TP_ADD_TCS(tp) +{ + ATF_TP_ADD_TC(tp, nonmember_file); + ATF_TP_ADD_TC(tp, nonmember_fifo); + ATF_TP_ADD_TC(tp, member_file); + ATF_TP_ADD_TC(tp, supplementary_member_file); + ATF_TP_ADD_TC(tp, privileged_file); + return (atf_no_error()); +}