From nobody Tue Nov 17 17:04:30 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWL671CLz71R7G for ; Tue, 17 Nov 2026 17:04:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWL60zXqz4FqW for ; Tue, 17 Nov 2026 17:04:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SiI0eeOqNlXPSTDLed/sKxLw3bbV6K0peNjwEp0CVLE=; b=M+SHUkfBoscuN5TofXvfJbGbqiuyvAunLcY/1KbgpCzAgIApHON3qN7e2pmhmgRWMmhlTG MNttTaZkz7NF0Owz9OQDcM4QjfJiKKMT6QM9ahRDTsvvfikOKEYU7xBb4MiPBxrkEtYtuF B691j0nNNSEgBVuBJHVkeeba8CXKj0RL9DdqOU/HP31783KFWVl8a3hQP+xdI9Blpc64NS iBd0v0dX+M9kKuJY4KTtqvu2yqLypT/QENktD6iAb9nDFyHSI83AwPT+Ixm42gfddUcSqg h7igsGREwkMW0cy2a/anRO8t3E5Uzo+L3FbDXbR4DVgTvqLfa01PeIzdinaO6Q== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935070; b=DFl7IpyRR23augwqmPR36H+nNxo/HRB/yG8Tlxg/Zleb33GcIfeQ/yFs20Hl6RDOmf0kAx kvzyIE+SLO4wp+2csG8BoayWYQX+6mjT+7nLtDlypZ6KL7SE/1+Oq8kSNvcstXZrHNO43L UMGAdjqHcwifK6xQljxVUJJkspRjqy6kF8CXXg8GJj+YwyTh0DVzBdEm0KPNnr+DlYvoPv Gi1YmNx7hR+rk/vqPFgfYWnu1UBwQ6D7dsN2OUus269COaVZQu3xDCxl5Na0zjOiUXkIlT w79HigIzvdOIoumUI7DKmM++gduqVKVnAHb+pRouK6057/daRaF6Tejde7BRHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SiI0eeOqNlXPSTDLed/sKxLw3bbV6K0peNjwEp0CVLE=; b=ID/ZQyfQ4+h4uejZXywwaxXEe9XHrT+YQas5OiS+73u3f905x+eK9pGhj1a1o3jnRbGF9o TzYWXUAkqSsFwlEfVluJNbKN30BPdaXz9cLJVJPqdV7OXGnsSXcQpa3Kb8lVvMNf50F+jH sD7bgCi8WN3td5b4Y0n65l1kCPHsAEj/t9j1GDJoDSKCV1KX4hwxCzBb0bj0slXvxw9nlp L9vvoPoHN4HCwebzlipZFC8UD1/wpuVSjBQDTs1WMhJa4HLWFngZ5/a5U7/dKbQ+ynpLeh 7d+is1U2Lyx0eV8FhIOiMZehEwd8GeCvQ64pobgwgVz9hFbvkbup4Ii1oVU8dQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWL60HHkzrVQ for ; Tue, 17 Nov 2026 17:04:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e517 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:04:30 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Kevin Day From: Mark Johnston Subject: git: a855ef4061f5 - releng/14.4 - vfs: Check access for O_CREAT directory opens List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.4 X-Git-Reftype: branch X-Git-Commit: a855ef4061f507f13cfe28a452468563c2cf8e03 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:04:30 +0000 Message-Id: <6afc891e.1e517.7fc2e48d@gitrepo.freebsd.org> The branch releng/14.4 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=a855ef4061f507f13cfe28a452468563c2cf8e03 commit a855ef4061f507f13cfe28a452468563c2cf8e03 Author: Kevin Day AuthorDate: 2026-11-13 19:49:13 +0000 Commit: Mark Johnston CommitDate: 2026-11-16 21:16:23 +0000 vfs: Check access for O_CREAT directory opens O_CREAT with O_DIRECTORY takes LOOKUP without creating a vnode. Clear O_CREAT there so vn_open_vnode checks read or search access. Add an unprivileged regression test for denied and permitted opens. Approved by: so Security: FreeBSD-SA-26:92.vfs Security: CVE-2026-127746 Reviewed by: kib Fixes: 9e18c9eb27cd --- sys/kern/vfs_vnops.c | 1 + tests/sys/file/fcntlflags_test.c | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index 3ce2ba0542f4..265c94bc4fe5 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -331,6 +331,7 @@ restart: fmode &= ~O_CREAT; } } else { + fmode &= ~O_CREAT; ndp->ni_cnd.cn_nameiop = LOOKUP; ndp->ni_cnd.cn_flags = open2nameif(fmode, vn_open_flags, ndp->ni_cnd.cn_flags); diff --git a/tests/sys/file/fcntlflags_test.c b/tests/sys/file/fcntlflags_test.c index 15a18c113c4a..15bf460a5887 100644 --- a/tests/sys/file/fcntlflags_test.c +++ b/tests/sys/file/fcntlflags_test.c @@ -25,6 +25,7 @@ */ #include +#include #include #include #include @@ -96,6 +97,37 @@ ATF_TC_BODY(exec_only_sh, tc) basic_tests("/bin/sh", O_EXEC, "O_EXEC"); } +ATF_TC_WITH_CLEANUP(creat_directory_permissions); +ATF_TC_HEAD(creat_directory_permissions, tc) +{ + atf_tc_set_md_var(tc, "require.user", "unprivileged"); +} +ATF_TC_BODY(creat_directory_permissions, tc) +{ + const char *dir = "creat_directory_permissions"; + int fd; + + ATF_REQUIRE(mkdir(dir, 0700) == 0); + ATF_REQUIRE(chmod(dir, 0300) == 0); + ATF_REQUIRE_ERRNO(EACCES, + open(dir, O_RDONLY | O_CREAT | O_DIRECTORY, 0) == -1); + fd = open(dir, O_SEARCH | O_CREAT | O_DIRECTORY, 0); + ATF_REQUIRE(fd >= 0); + ATF_REQUIRE(close(fd) == 0); + + ATF_REQUIRE(chmod(dir, 0400) == 0); + ATF_REQUIRE_ERRNO(EACCES, + open(dir, O_SEARCH | O_CREAT | O_DIRECTORY, 0) == -1); + fd = open(dir, O_RDONLY | O_CREAT | O_DIRECTORY, 0); + ATF_REQUIRE(fd >= 0); + ATF_REQUIRE(close(fd) == 0); +} +ATF_TC_CLEANUP(creat_directory_permissions, tc) +{ + (void)chmod("creat_directory_permissions", 0700); + (void)rmdir("creat_directory_permissions"); +} + ATF_TC_WITHOUT_HEAD(fioasync_dev_null); ATF_TC_BODY(fioasync_dev_null, tc) { @@ -127,6 +159,7 @@ ATF_TP_ADD_TCS(tp) ATF_TP_ADD_TC(tp, write_only_null); ATF_TP_ADD_TC(tp, read_write_null); ATF_TP_ADD_TC(tp, exec_only_sh); + ATF_TP_ADD_TC(tp, creat_directory_permissions); ATF_TP_ADD_TC(tp, fioasync_dev_null); return (atf_no_error());