From nobody Tue Nov 17 17:04:22 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWKz1DQmz71Qwt for ; Tue, 17 Nov 2026 17:04:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWKy58RQz4FZy for ; Tue, 17 Nov 2026 17:04:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KcABSrBjofXIEidyE9DGCTNvbwOyjxebsE/ujN5y3rQ=; b=M3SlQcQiyL9/rs7kj42iWybwLDJ4xOx2Eu3QQfNUanKXsu3fAvYfTI3NX9HXFUdbVzk5ha xHEbVTNMX2Un0sZOQZCaXwcKlKf5OKpzTsNteORVMpaqclC/djRIO9z0Hdn3meyIZdf9VZ Cq6PTeTK7VrctEKVRvKBOFFzlwUCKz+8/qyOlsqsJdhoeADPz5pHjjGFIxWPl0on6ICkIO 4Bg73CI9513GmQ9fRRjepgsezacNgpdJYNO4RQae+sfYwGK9uBWXfHJP3j5p+IDZqpGtyG TbHZGGG/xFYkxx4iNtWK+H2N5dW60VRlYGEAnhuKQqXf4nHowJ3XAgiZWomVHA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794935062; b=PMUSiHw4G9c4k3MYwSCmEbK6cco7qmZAke9tU5vFOu2ThA2mossBAuhEvOtWZpXpgef6hF v1hyL/wuZYuncnSiiZCZfmzBO+yl/jGP193OeSHwBjut0dGGqWFSAuIc4lZ9SGV3WxtlI6 r/IQfRno7QIIY0lecvoHTT3QhVASrRoK32AyhGMyZy8aeR2WxLvkOtxpDMkMhSp67k8UuF Xchn+s+duyiFGob+H6sYzZ/6+foIYrIm8/+yJMPgtd91wbjRColSOem9axz+5Kp5Lova2J juxb6pGyo/AQGLX9QraI47PMvjmZNjK8p/Thi1a8FtzUjKnK698BdnFj/rFOjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794935062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KcABSrBjofXIEidyE9DGCTNvbwOyjxebsE/ujN5y3rQ=; b=jbuLXg52peKeW7jSal4kQvBcgPFXVI4h2O90Tx1PuuJFVz742exqtIi8F3Ix6UnFImSGgk NEi0z3x60HM+D/USzCaeIsUpF3b+Wsp2oV1aV5hFQCdOFVJMubG7polYTfkWqMNLKDF+d9 m3vygw1BKolNcRv7SPWAUgpsTSCCniM0Qts86xoplSS8hkYkoJteidcTXR8N2BJJwt4pzt oMDKo515JjbZlURsY/UyjekLrUSc0rv7dydPMMzA1WAy4JcwaEAY3MddNJG+D0i9Bt4SY+ bqRL6hHyB1FkE6D/455tpmtOVYR84cqV4tGNA7TfRes7N3sSh3PNtHN9nGH8WQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWKy4kL7zr6k for ; Tue, 17 Nov 2026 17:04:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f82c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:04:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Maxim Konovalov From: Mark Johnston Subject: git: c201af9c01cd - releng/14.4 - bsnmp: reject an oversized vacmViewTreeFamilyMask List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.4 X-Git-Reftype: branch X-Git-Commit: c201af9c01cdcabd0a3b9be4eefb68b525640a59 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:04:22 +0000 Message-Id: <6afc8916.1f82c.62da06a6@gitrepo.freebsd.org> The branch releng/14.4 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=c201af9c01cdcabd0a3b9be4eefb68b525640a59 commit c201af9c01cdcabd0a3b9be4eefb68b525640a59 Author: Maxim Konovalov AuthorDate: 2026-11-13 03:07:48 +0000 Commit: Mark Johnston CommitDate: 2026-11-16 21:16:22 +0000 bsnmp: reject an oversized vacmViewTreeFamilyMask The SET handler for vacmViewTreeFamilyMask compared the value length against the 16-byte view->mask, but the check had no statement of its own: it guarded the following malloc() instead of rejecting the request. A value longer than 16 bytes was therefore copied into view->mask with memcpy(), overflowing struct vacm_view. Add the missing return so an over-long value is refused with wrongValue. Approved by: so Security: FreeBSD-SA-26:89.bsnmp Security: CVE-2026-127743 Reviewed by: harti Fixes: 135f7de5ddb6 --- contrib/bsnmp/snmp_vacm/vacm_snmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/bsnmp/snmp_vacm/vacm_snmp.c b/contrib/bsnmp/snmp_vacm/vacm_snmp.c index 39371176e493..29d1b8ffcb1e 100644 --- a/contrib/bsnmp/snmp_vacm/vacm_snmp.c +++ b/contrib/bsnmp/snmp_vacm/vacm_snmp.c @@ -490,6 +490,7 @@ op_vacm_view(struct snmp_context *ctx, struct snmp_value *val, uint32_t sub, switch (val->var.subs[sub - 1]) { case LEAF_vacmViewTreeFamilyMask: if (val->v.octetstring.len > sizeof(view->mask)) + return (SNMP_ERR_WRONG_VALUE); ctx->scratch->ptr1 = malloc(sizeof(view->mask)); if (ctx->scratch->ptr1 == NULL) return (SNMP_ERR_GENERR);