From nobody Tue Nov 17 17:03:07 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWJX049rz71R10 for ; Tue, 17 Nov 2026 17:03:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWJW47Fwz4CZm for ; Tue, 17 Nov 2026 17:03:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EjLz10FA74knMj91iZcj5Qk4pJ8rRE/XEY65V+pvZ8k=; b=yYRKeozlprk7zazTHvLsz6zojGhbY+9R2zXoyuvhww7sQ+WrNdTTtKltk7OlIVruH0dt7W eH1hveZ2OZd4ojBuVT0d68EzXizw32BboCyjXVA16dlLHDgFkk0y46NmFVJ/PWS39EsA3t XIH7TyKHx/tOF2+WMAR+5N1xmsErkA9zX6kKhkiK8TTtAdDNEEBfPFlVv0Qg24AQzgouF2 iB+TRiONTbHzYt7jaJi54ySxpf15StISGm8B0l3lYPDrYDg4Yq85STp+WWo5Wo3I6fCFYu /rffbGSkmWuXmXExgCPtBj6q5vwcr4CTTCVcVy/FUNncCqPLBXicOBt02n24zg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794934987; b=KpdUd/Qq2aVxrP47ebXzBBqHwootXZ1l/Q7vn1m6nME/fhmez/RivQX301u3P/I+5URMd4 ZL5RuHSZhd5FJwe1tBaBKwVeJ8uJBA685mCgJ9/ETM8V2H2hpzid9DAs6HQMbfIVm4d5dv U5fjSsZ5OFBN8vHwdzdl7Lm0tOxvMxDrxMSyrwdrTWw7sdzq0n1z4KK7TgEoEnS1YRtpV3 qwgHP2qrrZ1KoxaqEUjkk4xV84FvBq7J0DT8GZm5B4bL+W8fWJYMjr0bmBlgDd/K8pTNAm Mr3JQiWjkFpew1Mrdtma4U0sSBi2y9/IZ01p15MMuZveUd4LfIBaN+uSWuK9PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EjLz10FA74knMj91iZcj5Qk4pJ8rRE/XEY65V+pvZ8k=; b=NEWcmm/LhgIlDsFDRzwmmc/tyHP7siD+xQLyRUklUMEYRcruzv0mGYkH9mFxn89LAJbc/A MjnviiW8rvTc1HQUo/GMhbvA7HLNyd3hWEuzrRSkLzZ5h7D0apU80GwXJmEczFNpRUG3e7 3J54tvhB+/aGJyIlV7Es4/E35I1wKrIIAuWdEyP8u/v7OpM0YfXKcQATg1otFO2hHz2OHc Dp/NQmTFvAZUBwUcCieoj7DzIzP0wW5Gd7B5SwgJ1abQalicJzfTRoQZJUAHRzugYQKWzE E11WmsAYNaM6tI5cGRjLjx4pl1E0uNXPdsKsEtRGIkswMZW+to7D12I7u/3RpQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWJW3cGWzrMN for ; Tue, 17 Nov 2026 17:03:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d3b1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:03:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Kevin Day From: Mark Johnston Subject: git: 7bb0841ad213 - stable/14 - tmpfs: Clear setgid on creation by nonmembers List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 7bb0841ad2133255f8f195bfdeaf27374ce0fac6 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:03:07 +0000 Message-Id: <6afc88cb.1d3b1.219b8ae5@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=7bb0841ad2133255f8f195bfdeaf27374ce0fac6 commit 7bb0841ad2133255f8f195bfdeaf27374ce0fac6 Author: Kevin Day AuthorDate: 2026-11-14 01:40:14 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 13:24:11 +0000 tmpfs: Clear setgid on creation by nonmembers New tmpfs nodes inherit their parent directory group. Clear S_ISGID when the creator is not a member of that group and lacks PRIV_VFS_SETGID, matching UFS and tmpfs chmod behavior. Approved by: so Security: FreeBSD-SA-26:94.tmpfs Security: CVE-2026-127749 Reviewed by: kib --- sys/fs/tmpfs/tmpfs_subr.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sys/fs/tmpfs/tmpfs_subr.c b/sys/fs/tmpfs/tmpfs_subr.c index bca6bf911eb1..40e242a07dd0 100644 --- a/sys/fs/tmpfs/tmpfs_subr.c +++ b/sys/fs/tmpfs/tmpfs_subr.c @@ -1164,6 +1164,7 @@ tmpfs_alloc_file(struct vnode *dvp, struct vnode **vpp, struct vattr *vap, struct componentname *cnp, const char *target) { int error; + mode_t mode; struct tmpfs_dirent *de; struct tmpfs_mount *tmp; struct tmpfs_node *dnode; @@ -1192,9 +1193,15 @@ tmpfs_alloc_file(struct vnode *dvp, struct vnode **vpp, struct vattr *vap, } else parent = NULL; + mode = vap->va_mode; + if ((mode & S_ISGID) != 0 && + !groupmember(dnode->tn_gid, cnp->cn_cred) && + priv_check_cred(cnp->cn_cred, PRIV_VFS_SETGID) != 0) + mode &= ~S_ISGID; + /* Allocate a node that represents the new file. */ error = tmpfs_alloc_node(dvp->v_mount, tmp, vap->va_type, - cnp->cn_cred->cr_uid, dnode->tn_gid, vap->va_mode, parent, + cnp->cn_cred->cr_uid, dnode->tn_gid, mode, parent, target, vap->va_rdev, &node); if (error != 0) return (error);