From nobody Tue Nov 17 17:03:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWJQ6Qy0z71Qlk for ; Tue, 17 Nov 2026 17:03:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWJQ25v1z4CQB for ; Tue, 17 Nov 2026 17:03:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5n86Afw3YborY9JAVXzb4bLHh9+tu3V51HFgCmqRhbs=; b=logFsU9JLLcBuorM9peiWe98IpGtVD3CPmgqYId8a14uHgqNtqv9HnRUqwN12iIJXzEaPt clY79vdDajTIj2ZLIqDuDQ9l8+QxmQatWSFd0KzV0S4tnmjFsb4MSdQEnYHThAPxdSjYdB jXFHfY46d4G4zmJfAq21gJrINwWIj7RJF9H7AWwnE1gyNBupvx6RUjLHBSDrOMfSsMt6mK WjMlDc7N/TfCiWr+Otg0iVeUtAsY9mRjZ6nA6Hh4QIHn8DPPzoDlV0bKLI/u7WXRlF05Al etiLbEQAQXLad642GfB+/SiQXvxauY8+6XnhZxZ6u6UVcxui39bhcPpNKT+M/A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794934982; b=f9hqcC9lgGtjuZ01Rh82o9lgxmoPpoOh0RKZxRtPxGX+iUjYBh064l4FCR6mp5IhBujviT C5H7OxDHErnHSzoSqxAaU3nJTBbeT98EPyQ1F6OhxzQoMyR1FWaZOa84iLJPEPrMiT4frE hACou5hyDZcPXBkTBC4e+MUI+OphN0kVbPWNTvJwNQd1zyq36+j3qCpdCbvAjMQMmwkyeF l8AxovxB1OCbYiFl6LijWK82rD3F/qv6yoS0k7Bp1Mf7FEgyKKPqD3ptf2Pna0Ws0eHCJK eBULmyoefiUmzF/YSMbcVreWu3R6rRZbCJoOJFrm8wVnoGcKt9vmiXUavxPdhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5n86Afw3YborY9JAVXzb4bLHh9+tu3V51HFgCmqRhbs=; b=ZRFXoqhNKWGLvYoxkYNWfx63oUAq0CQnaz9JeTKk56B3S0bkGky4qB576r6N2RuH+bB0hX C7h9D68SuiJdpVYm2bVb/OfoMJPZtoey5S1T2UHA/iPUw53SIfgFwlGVihQV5AV1VKDrHj dKyZoWABv3jnkt3IPAZhQDiKoMyKn/XBFfpnZpChybuVvaexY5kIdx8Kim8Rw45LOVMTVK st5Ga+j2COAjQBjfkjEXji2FkxHlbgF+dcSTgqal8nzJL6vaUzu7FrKrq0C6PV1PJJLqMO IQ9Xrse/EzJ5NwnQqA6lt7oKXuZpa14Kp/ZJWE+XQ+GVd4IC/kqhG59C++cVGQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWJQ1l20zrfS for ; Tue, 17 Nov 2026 17:03:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e9a8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:03:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Konstantin Belousov From: Mark Johnston Subject: git: 947d644c55a7 - stable/14 - fdescfs: add VOP_ACCESS() implementation List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 947d644c55a7a34832e3f7bea90e63173603a1d7 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:03:02 +0000 Message-Id: <6afc88c6.1e9a8.13fbe9fb@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=947d644c55a7a34832e3f7bea90e63173603a1d7 commit 947d644c55a7a34832e3f7bea90e63173603a1d7 Author: Konstantin Belousov AuthorDate: 2026-11-06 00:00:19 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 13:24:11 +0000 fdescfs: add VOP_ACCESS() implementation kern_truncate() checks VWRITE only through VOP_ACCESS() on the fdescfs vnode, which always succeeded until now. So a file opened read-only could be truncated, even if the caller has no write permission for it. Note that reopen on mounts without nodup already performs the permission checks in dupfdopen(). For nodup mounts, the VOP_ACCESS() implementation of the real filesystem is used. Approved by: so Security: FreeBSD-SA-26:91.fdescfs Security: CVE-2026-127745 Reported by: Kevin Day Sponsored by: The FreeBSD Foundation --- sys/fs/fdescfs/fdesc_vnops.c | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/sys/fs/fdescfs/fdesc_vnops.c b/sys/fs/fdescfs/fdesc_vnops.c index 7926395d6954..f1e204d9b2d0 100644 --- a/sys/fs/fdescfs/fdesc_vnops.c +++ b/sys/fs/fdescfs/fdesc_vnops.c @@ -75,11 +75,12 @@ static vop_readdir_t fdesc_readdir; static vop_readlink_t fdesc_readlink; static vop_reclaim_t fdesc_reclaim; static vop_setattr_t fdesc_setattr; +static vop_access_t fdesc_access; static struct vop_vector fdesc_vnodeops = { .vop_default = &default_vnodeops, - .vop_access = VOP_NULL, + .vop_access = fdesc_access, .vop_getattr = fdesc_getattr, .vop_lookup = fdesc_lookup, .vop_open = fdesc_open, @@ -706,3 +707,34 @@ out: vn_lock(vn, lockflags | LK_RETRY); return (error); } + +static int +fdesc_access(struct vop_access_args *va) +{ + struct vnode *vp; + struct fdescnode *fd; + struct file *fp; + int error, flags, locked; + + vp = va->a_vp; + fd = VTOFDESC(vp); + if (fd->fd_type == Froot) + return (0); + error = fget(va->a_td, fd->fd_fd, &cap_no_rights, &fp); + if (error != 0) + return (error); + flags = 0; + if ((va->a_accmode & VREAD) != 0) + flags |= FREAD; + if ((va->a_accmode & (VWRITE | VAPPEND)) != 0) + flags |= FWRITE; + if ((va->a_accmode & VEXEC) != 0) + flags |= FEXEC; + if ((flags & fp->f_flag) != flags) + error = EACCES; + locked = VOP_ISLOCKED(vp); + VOP_UNLOCK(vp); + fdrop(fp, va->a_td); + vn_lock(vp, locked | LK_RETRY); + return (error); +}