From nobody Tue Nov 17 17:03:00 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWJN3Bt2z71Ql7 for ; Tue, 17 Nov 2026 17:03:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWJN1LYNz4CM2 for ; Tue, 17 Nov 2026 17:03:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eGaQYVTn0je/kb5k3eEU1yJgfGii++S0ngZ32TogOtE=; b=ba/Ref9etjxc4q/g89pH/Clku5nBS7KaJOBuKoILFYghUu6/I7Y7vtfOR79VaGL9TWLkJn SFC8jjQjEdy5UO+e1pNgISe5fFRzWMBPHMyPWswiuvIH354FIwJ7TN4271Mvn6xR+UbQwB kZ7XOEmK/9WM5RnDACwc2k4/TDHB5J3ltGsisH+URZbI6I3JHXgoWP5glOIPldR9R+YJVB 9/M42S2GxMsnY0Z9gXkwQ9Q2pfXQxFb9lizk6Yh4p2ElnGzNfcHm7NlCwTGEJD0MEIO6vt pMSDAyXtKbAVB2smMwDTCMyQQvCJx3tJCHB9TIXm9E4nOh+FjcwFbStSuS8EhQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794934980; b=bg5MNhuLCcgN2DOS+YqoUzzKx4fHaGK/XzGe7IBYvyEXwwze2aV6p6BUl78PqYSio/wxvU HAH+NJJlM9EOb94vaPPnOydDg+CXxWHkjroASRqvh0N02LMsAfiDSDYlNWLdlGg61Xx111 E2zp/Ie1VnYddOq56o+oFn7fbCxwhVTxfGA0nhKlqrcMMylggsMnfVpXZACkwYj6sP6QP0 DH1zhBo0VCIIyjGmJ4jY4MwIv6hO9UtzLH1uJdQBboGMGnS5ToGhu9kSw0BFPQ0umjYlHo Tk57ag4grL/zWPZMU3VDm403hqY/aKl2C+2t/Z0RuIwh8XEMwnIKpzS8J6t2HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eGaQYVTn0je/kb5k3eEU1yJgfGii++S0ngZ32TogOtE=; b=kW1ElxoqEYnjW697o2Ot2w49PwCfSniVEWSHFawZdmz7kuHKsideDSUY/9MxPgUIpv3Znd gQRO7Sa4JHMxyCDSoNpQLrnBx/iOpoGmJmKuVUcwHbV4tj0IuCsnohfNMtto1EFutv/hEH tBxjExVsYASianyylpRrcEyYYpinCALdrE2yjwHyHeZSeLg/sgD5UUkki7hxYIi8sYl6fv j0jXmDf2kSqTiMHvOzDjpOSrZZrZXdp3FQd7wMgFZlCsCHUJKuwtuoZVv/K6tcK1zFo7FF oYa3QpALyaUj2WCEtb9tW7fxMZ0XDCi1d4VtlpINq9P+HeWzmmHoyP7Gx5KpQA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWJN10rhzrMJ for ; Tue, 17 Nov 2026 17:03:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e316 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:03:00 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Maxim Konovalov From: Mark Johnston Subject: git: 0efa7dd6ada1 - stable/14 - bsnmp: let an SNMPv3 discovery message elicit only a Report List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0efa7dd6ada120ed2d1e79944d0da89cdafc1260 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:03:00 +0000 Message-Id: <6afc88c4.1e316.7503b2d6@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=0efa7dd6ada120ed2d1e79944d0da89cdafc1260 commit 0efa7dd6ada120ed2d1e79944d0da89cdafc1260 Author: Maxim Konovalov AuthorDate: 2026-11-12 00:43:06 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 13:24:11 +0000 bsnmp: let an SNMPv3 discovery message elicit only a Report An SNMPv3 message with no variable bindings is treated as RFC 3414 engineID (or time-window) discovery: snmp_input_start() appends a single usmStats counter to the request, and snmp_pdu_auth_access() skips the VACM check because the AUTODISCOVER flag is set. The request's verb was then still dispatched by type. A genuine discovery is a GET and simply reads that counter back -- the intended Report -- but a zero-binding GETNEXT or GETBULK instead walks forward from the appended OID, and with VACM skipped it returns the next registered object(s): an unauthenticated read of the agent's USM and VACM configuration (objects at or after 1.3.6.1.6.3.15). Force the verb of a discovery message to GET, so the appended counter is read as-is and no walk (or SET) can run under the skipped-VACM state. Genuine discovery, which already uses GET, is unaffected. This complements the earlier change that rejects an AUTODISCOVER message carrying its own bindings; that guard is never reached on this path, because the offending binding is appended by the agent after the zero-binding test. Approved by: so Security: FreeBSD-SA-26:89.bsnmp Reviewed by: harti Fixes: 135f7de5ddb6 --- contrib/bsnmp/snmpd/main.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/contrib/bsnmp/snmpd/main.c b/contrib/bsnmp/snmpd/main.c index d1377756b64e..18e27695cf52 100644 --- a/contrib/bsnmp/snmpd/main.c +++ b/contrib/bsnmp/snmpd/main.c @@ -644,6 +644,15 @@ decoded: pdu->engine.engine_boots = snmpd_engine.engine_boots; pdu->engine.engine_time = snmpd_engine.engine_time; } + /* + * A discovery message may only elicit a Report. Force GET + * so the appended usmStats counter is read back as-is: a + * GETNEXT or GETBULK would otherwise walk forward from it, + * and a SET act on it, all with VACM skipped for the + * AUTODISCOVER flag. + */ + if ((pdu->flags & SNMP_MSG_AUTODISCOVER) != 0) + pdu->type = SNMP_PDU_GET; } else if (pdu->user.auth_proto != SNMP_AUTH_NOAUTH && (pdu->engine.engine_boots == 0 || pdu->engine.engine_time == 0)) { snmpd_usmstats.not_in_time_windows++;