From nobody Tue Nov 17 17:02:07 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWHM6jR6z71QcP for ; Tue, 17 Nov 2026 17:02:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWHM4GbBz3QLL for ; Tue, 17 Nov 2026 17:02:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HVtdvBZPjkaN6UVYR1+JTihA5ibUyzm+fDkM2i/hhiQ=; b=BvsUhA2CwqFQeBYV9Z9Oe3LADW4zhMJYFgstSG92QUPgpKx/o9zXrTsYCYvyP2HDJ88Xse Zp6CE/5kxsCy+u3jigU299FRVJAYjaLNj5FRYV0Nr+dMgCnMYsityH5/b2NYFQXJXDRDBA 8r/P/kD1jKJMsPLYIVcFQF/dkenedCwH72EbG12kshHZeiP2XTOejE/WNw9AMrQftJQ2M6 KuzFdaoj/FZEHpS7FC4eijjuLc5dDQ8kAk8UUz7Gly3JIyFAe/lxA+M/SOb5tqyMw2O4fw jLlAX4GFozbX90Fuj5dB+M3XJLKxOOlJGCTfNRHlOqPaV2PKQvEv699r8V2gGg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794934927; b=LExEznQOWLXOBF+vvp1gLP2VJbxeO8fZegGkHVxUNWBvAax5MUMpUOlZyrKVt48OBjZEmh FtB3d/q3I5/H/Wft83V2w0PjjJ5vrgFJweRLDBJnwEa9Ln+uu1Bnn/cQByjyAYs7ibvaBj oN6xIfKuzLcUdDO/k9EdpXs7LUXyi2ymy4V8yYLvWTFkV70xFY3yo3n+gYRPhC3izoDMmz sFjyqRs2CTFCVvnmNvhzu92ECpDMvVuIPEWt59R1itNrxSRKCm4djdreTqIjpU+4KMi0LQ oQ6w+iORZqaLOq3fdF6S2imWNmf65CDvPH8WkmoppFjuRDuJRN9U8dRoCGFgzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HVtdvBZPjkaN6UVYR1+JTihA5ibUyzm+fDkM2i/hhiQ=; b=Uzvcz7wZNajzNu49p7Ynwift1ohV3EDsHEteVKKjGonbe34aMI+VOU0+7Vuu0tZoJtPEpN GyK9E5PEhwCkdoAf4OU+awsvne4R+hzGHeq7RVDjijp8dwoybpILNFuNVNjBQwrmg0tw7t 123IB9Yp7yJLh6jtJm6GLowNhnp41F7SZlSy9iVOW6YWiP7BGCrbbpOgwvlZz4VY0oitp7 LStgMm/eTLdZj9RV0cd6Pt14uUFlOMRqIZLq6fv7F7NINoctGzcn3SRYwiuOrGPNDqYZr0 7OBhHoMYHNqE++4aN+1NVgDgNeTtCc44Wdcj5PqbtWNXsSB5wVQtlKUjRAy/tA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWHM3wszzrLn for ; Tue, 17 Nov 2026 17:02:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1ea2d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:02:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Kevin Day From: Mark Johnston Subject: git: 32e5e83527e4 - main - tmpfs: Clear setgid on creation by nonmembers List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 32e5e83527e4d3f8a6f954512ae30fdd64bd7383 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:02:07 +0000 Message-Id: <6afc888f.1ea2d.5a3a0bcc@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=32e5e83527e4d3f8a6f954512ae30fdd64bd7383 commit 32e5e83527e4d3f8a6f954512ae30fdd64bd7383 Author: Kevin Day AuthorDate: 2026-11-14 01:40:14 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 16:57:01 +0000 tmpfs: Clear setgid on creation by nonmembers New tmpfs nodes inherit their parent directory group. Clear S_ISGID when the creator is not a member of that group and lacks PRIV_VFS_SETGID, matching UFS and tmpfs chmod behavior. Approved by: so Security: FreeBSD-SA-26:94.tmpfs Security: CVE-2026-127749 Reviewed by: kib --- sys/fs/tmpfs/tmpfs_subr.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sys/fs/tmpfs/tmpfs_subr.c b/sys/fs/tmpfs/tmpfs_subr.c index 113a985c0b30..cfdd5cd1f973 100644 --- a/sys/fs/tmpfs/tmpfs_subr.c +++ b/sys/fs/tmpfs/tmpfs_subr.c @@ -1167,6 +1167,7 @@ tmpfs_alloc_file(struct vnode *dvp, struct vnode **vpp, struct vattr *vap, struct componentname *cnp, const char *target) { int error; + mode_t mode; struct tmpfs_dirent *de; struct tmpfs_mount *tmp; struct tmpfs_node *dnode; @@ -1195,9 +1196,15 @@ tmpfs_alloc_file(struct vnode *dvp, struct vnode **vpp, struct vattr *vap, } else parent = NULL; + mode = vap->va_mode; + if ((mode & S_ISGID) != 0 && + !groupmember(dnode->tn_gid, cnp->cn_cred) && + priv_check_cred(cnp->cn_cred, PRIV_VFS_SETGID) != 0) + mode &= ~S_ISGID; + /* Allocate a node that represents the new file. */ error = tmpfs_alloc_node(dvp->v_mount, tmp, vap->va_type, - cnp->cn_cred->cr_uid, dnode->tn_gid, vap->va_mode, parent, + cnp->cn_cred->cr_uid, dnode->tn_gid, mode, parent, target, vap->va_rdev, &node); if (error != 0) return (error);