From nobody Tue Nov 17 17:02:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWHL0stVz71QcK for ; Tue, 17 Nov 2026 17:02:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWHK4jSbz3QCk for ; Tue, 17 Nov 2026 17:02:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1zxk/Zw0RqqWw+Tm2kq2y1q7G06EY2MgSOwaZJ+5Vyo=; b=xuY5zKtA9KGKq95LnS47udPiVhAJ60BsivKRvvuzMTXA7t0RYWB9FepM+7fygCeqGXqO+a gLU3pViEtvLLJRk4rebw3g0vqa2Qhi/VZWbNPv9oYI5sh2rWxsquYcVlAmyw0ZdCBR0y4p MMB7NJ3mTtVit5HKaUOxhaVTc+oXWGNmIvOVGb1HUIDx+RatH6tfcA8pOG1n/1g1Gr+Oal /cTKIj4YCZtQsLVyg4b3LgQUG1iVgiXSI+kxCCXnaT9Jyp2OwJPMSD2hdBhPzcuo2WDdR0 ya2MouhaYiYkksv2lwGhKEHEXTKB0y0YHGKKhlDOE3mo1hmNLs5kk1Cu9g0fEA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794934925; b=dOiRmkOeCZ/W7eALRuVtnTlyQlcWxMdGfDhz6ND22keTV2cVsZRYGyGWsL4a7lmRmIW+ZT mWyfDinOch+lNk7FhpYu7oJbJAe7ZoUr2BLKCp6MyHQrrrCfjQced+7QQM07FnFk87DcqD VMyUhMHCA4QvFxWSlNgGwDa5dYqzeVlWZU0ertkSbuCBRQMKYLHxFJk10FbtC01VfWutm7 C2sxN91YwAXtuEU3la+XN9X2QVuvGWLF7oO4szIz3xdVEBzxilWoUw6aBfQZdPApp2wzgR MrvoUPxzaxpwSioZeepEnk4p/DsyYqVXz1+zGCWhTI0y+CiSm3r9rdM2XtY7fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1zxk/Zw0RqqWw+Tm2kq2y1q7G06EY2MgSOwaZJ+5Vyo=; b=MEQmihz2negIF6Jckem0TjFRTqMo9e6ZEEKDGtazihbx5dEbTIRB7PxwfhaGY+heMMxppO dvOM/TGF1SmolVnM5qZMn2LCAwcaEey5BIpBeLz2ftmQKBeNhfzr9qWRe3eOU4Cd8dmk1k v/5EICs8aUsoXsXHYyLxIL6k6VvRWSWfhr1ddj/IL36/Rewq0MAi5RBFuf8O9gGulMmJS6 dEFFDb6M18qzkjr9l1cbnr1F70rqRf/mqIdq21HDngB+2QVKSlVU50R2JeXYJp0IV/RqKM Q+zN7i7GT/Q9180MDziQz7AIYhDf1r6xAJ8cW9/7Ie0rnwCns+Yx2idtxaRbmA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWHK3CSJzrg7 for ; Tue, 17 Nov 2026 17:02:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e264 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:02:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Kevin Day From: Mark Johnston Subject: git: 5ad2cb236e59 - main - vfs: Check access for O_CREAT directory opens List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5ad2cb236e59204cec63e30dd726b7e2194a6544 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:02:05 +0000 Message-Id: <6afc888d.1e264.5b06e8e7@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=5ad2cb236e59204cec63e30dd726b7e2194a6544 commit 5ad2cb236e59204cec63e30dd726b7e2194a6544 Author: Kevin Day AuthorDate: 2026-11-13 19:49:13 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 16:57:01 +0000 vfs: Check access for O_CREAT directory opens O_CREAT with O_DIRECTORY takes LOOKUP without creating a vnode. Clear O_CREAT there so vn_open_vnode checks read or search access. Add an unprivileged regression test for denied and permitted opens. Approved by: so Security: FreeBSD-SA-26:92.vfs Security: CVE-2026-127746 Reviewed by: kib Fixes: 9e18c9eb27cd --- sys/kern/vfs_vnops.c | 1 + tests/sys/file/fcntlflags_test.c | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index 78c13bb6e033..88de7ac5b4c0 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -405,6 +405,7 @@ restart: fmode &= ~O_CREAT; } } else { + fmode &= ~O_CREAT; ndp->ni_cnd.cn_nameiop = LOOKUP; ndp->ni_cnd.cn_flags = open2nameif(fmode, vn_open_flags, ndp->ni_cnd.cn_flags); diff --git a/tests/sys/file/fcntlflags_test.c b/tests/sys/file/fcntlflags_test.c index 15a18c113c4a..15bf460a5887 100644 --- a/tests/sys/file/fcntlflags_test.c +++ b/tests/sys/file/fcntlflags_test.c @@ -25,6 +25,7 @@ */ #include +#include #include #include #include @@ -96,6 +97,37 @@ ATF_TC_BODY(exec_only_sh, tc) basic_tests("/bin/sh", O_EXEC, "O_EXEC"); } +ATF_TC_WITH_CLEANUP(creat_directory_permissions); +ATF_TC_HEAD(creat_directory_permissions, tc) +{ + atf_tc_set_md_var(tc, "require.user", "unprivileged"); +} +ATF_TC_BODY(creat_directory_permissions, tc) +{ + const char *dir = "creat_directory_permissions"; + int fd; + + ATF_REQUIRE(mkdir(dir, 0700) == 0); + ATF_REQUIRE(chmod(dir, 0300) == 0); + ATF_REQUIRE_ERRNO(EACCES, + open(dir, O_RDONLY | O_CREAT | O_DIRECTORY, 0) == -1); + fd = open(dir, O_SEARCH | O_CREAT | O_DIRECTORY, 0); + ATF_REQUIRE(fd >= 0); + ATF_REQUIRE(close(fd) == 0); + + ATF_REQUIRE(chmod(dir, 0400) == 0); + ATF_REQUIRE_ERRNO(EACCES, + open(dir, O_SEARCH | O_CREAT | O_DIRECTORY, 0) == -1); + fd = open(dir, O_RDONLY | O_CREAT | O_DIRECTORY, 0); + ATF_REQUIRE(fd >= 0); + ATF_REQUIRE(close(fd) == 0); +} +ATF_TC_CLEANUP(creat_directory_permissions, tc) +{ + (void)chmod("creat_directory_permissions", 0700); + (void)rmdir("creat_directory_permissions"); +} + ATF_TC_WITHOUT_HEAD(fioasync_dev_null); ATF_TC_BODY(fioasync_dev_null, tc) { @@ -127,6 +159,7 @@ ATF_TP_ADD_TCS(tp) ATF_TP_ADD_TC(tp, write_only_null); ATF_TP_ADD_TC(tp, read_write_null); ATF_TP_ADD_TC(tp, exec_only_sh); + ATF_TP_ADD_TC(tp, creat_directory_permissions); ATF_TP_ADD_TC(tp, fioasync_dev_null); return (atf_no_error());