From nobody Tue Nov 17 17:01:58 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWHB5RjDz71QTQ for ; Tue, 17 Nov 2026 17:01:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWHB11Lmz3Q1m for ; Tue, 17 Nov 2026 17:01:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7v+534F5zNT2bxXvX1Cbm3II9QpsGK1akrvMSrWLZ/o=; b=B3EJ/he1fqD7kj3hsNbEh7xex/GhXYbCncbwJdk9g+VvE+zpilxeqvlea/6iD1zt/K3mdp ZePsxs7M8tAa6WX54oBNj7Hnj/oy4Jg1/PmnYl6KyJPruhOBqFTvtQCBswUv5xS2nqSomC 3Rc6Crb0vjxRSU/7BweuDsH+rAc3r4c3951oNqC3CUmBFgInQH13Y4Zn0xSh85xukLpHq7 UxtdwbnZI4yRJXywivQPrrf1aMiAaz1JLwOeKTlEhNcNMUi8XaQzkkBvN92sErzkBC2Xby bqzihaB8UrdotZH146fjKbCvojwiwIEHtgOy5XzST7eLajhX7sWLctwBd7L6+g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794934918; b=VE0fxv9LnOrHTX/9GIeNpyGvwqjLn5NCsM+szrSYrHM5WbEhlIMeh/4buu0NOJ+d69BhQs 0t8kVuWnz9LRjR1+02+AtC3vEtkLYr3cIkPJfGaa6cJeNjtcQZp9RyuECHKsjbi3OtlVIK rsfStXIV4jDmmIy72MRdqJA7++om8IGRSFNS1cMHaMQ6xt6M3bN0qPVPyxNH/nUcaaRL8D 2T2W/YnZgUncOP0mcEnalebyFnqViTTed61kzL5MfkJ6jlQCqo9FgDdZyq0mKh/l+iX1gt Jy2gRpfcYVywpSZPA2y9whA17prGqtTz8mt1P08UvOHdq6iXA6XJ7vzZSycxQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7v+534F5zNT2bxXvX1Cbm3II9QpsGK1akrvMSrWLZ/o=; b=QLflKA/fat9KRdqDqrlECl6dBq7DB5SBoK5jKz8e+vxabOdFimey0pwtNxFtRMgnNQ8OZo stQcrzkI4AtEqvx6yivFO63Ux7pIdFI1u6lj+gauoCDgGdyZu2t7hyX6uCrO1hU3DFFd6V 4QJvsExEVen79cNP/YikKvTdPDgBLL4L54+DQXpXROACI/hNRWBnfYi0zMxwBdgv1EimJf N5Iz7NLJllSDFdlR93M59YKfnhFeH+JgMBpQer5wFtsO4MpKrPyCfyvD8UGFIO7WkGHbgM wii1DLCRud+esQLAJvZmTnl7sVx2PLu/eT3T+jAIEXXsMCw/J4iWFmdzAQrCwA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWHB0hLjzrTn for ; Tue, 17 Nov 2026 17:01:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f016 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:01:58 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Maxim Konovalov From: Mark Johnston Subject: git: 85533cf8f2ea - main - bsnmp: reject an oversized vacmViewTreeFamilyMask List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 85533cf8f2ea9af93bf9550a1a165b99ba451fc8 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:01:58 +0000 Message-Id: <6afc8886.1f016.3846e1d9@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=85533cf8f2ea9af93bf9550a1a165b99ba451fc8 commit 85533cf8f2ea9af93bf9550a1a165b99ba451fc8 Author: Maxim Konovalov AuthorDate: 2026-11-13 03:07:48 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 16:57:01 +0000 bsnmp: reject an oversized vacmViewTreeFamilyMask The SET handler for vacmViewTreeFamilyMask compared the value length against the 16-byte view->mask, but the check had no statement of its own: it guarded the following malloc() instead of rejecting the request. A value longer than 16 bytes was therefore copied into view->mask with memcpy(), overflowing struct vacm_view. Add the missing return so an over-long value is refused with wrongValue. Approved by: so Security: FreeBSD-SA-26:89.bsnmp Security: CVE-2026-127743 Reviewed by: harti Fixes: 135f7de5ddb6 --- contrib/bsnmp/snmp_vacm/vacm_snmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/bsnmp/snmp_vacm/vacm_snmp.c b/contrib/bsnmp/snmp_vacm/vacm_snmp.c index 39371176e493..29d1b8ffcb1e 100644 --- a/contrib/bsnmp/snmp_vacm/vacm_snmp.c +++ b/contrib/bsnmp/snmp_vacm/vacm_snmp.c @@ -490,6 +490,7 @@ op_vacm_view(struct snmp_context *ctx, struct snmp_value *val, uint32_t sub, switch (val->var.subs[sub - 1]) { case LEAF_vacmViewTreeFamilyMask: if (val->v.octetstring.len > sizeof(view->mask)) + return (SNMP_ERR_WRONG_VALUE); ctx->scratch->ptr1 = malloc(sizeof(view->mask)); if (ctx->scratch->ptr1 == NULL) return (SNMP_ERR_GENERR);