From nobody Tue Nov 17 17:01:39 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTWGq2X5Jz71QSP for ; Tue, 17 Nov 2026 17:01:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTWGq1ypVz3PPb for ; Tue, 17 Nov 2026 17:01:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hds6XrwbuZ64/cXGllWRWK4bSsWdkbHsyP5qzVWPbeY=; b=t7l4s9ZuRfLVR1Ex/j0SdKP0TfDLqsEo2RfIgCwBEmeKrZOU7awbFnMnnQ8oueAyTAtXOM gtzJF8OLpUUqeVwBYJY1qUQ4UseF+cBy1bO52wiw4xiCwOz221T3GwSNNKjcJg7M66jiyu Cw3NTlL4B/wdkqVrlQErSop2ayqPNM9NCsUfjp7WUabDLyb3aatgGXwcy4Lnyz/Ex/BbvQ 1NGoO8n38lqFQVoydMIP0YIyGKGeKFd/mjJieGNc5k5Bj4rUVDAAcx9AJjTwvb9FT58mN6 POLj7MPovcAQ2u+dGs7w8+Kw0H/ChRaxpwvO6WxovOBQlHouLnSrf1Z87OjuSQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794934899; b=gq4Sb73cDN45nfOmSoQnSI1R2OhMzqVZboFsW8wjuEtXKRV59XBaU89T6aihdITE7cKSwM FTIwHPAGIt0Ns8ClqQ/LoLqf1XsMtGbiyMIHbHTK/DALQR0bYUxCQzyYYoBsI0r00+i1wd 64r1NhBQs/K4RY6YtiArB7au+5f7ctAveRGGJhIjSW0QgFn9T1jtHpAv22qm1HYcOQcvka 1Bi9cTzyfXA9GOKYXDa9V3EwfnbkJUB24G5xJNADdN4l7OJem91rdYuahpTbNaT25M6gZ2 P7rxXs/DfN63hHwBB4vbOSKQFwIbuwsEIfxheWt8oW8tl8luaF6/h+zgMzQ3fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794934899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hds6XrwbuZ64/cXGllWRWK4bSsWdkbHsyP5qzVWPbeY=; b=mNUB3/vT2IH8le3QGRrr99mMCQ7Nhhor4ZldO9VPIPR403+PG6O1qYHDkEGJA9sIfS7XRf 7J/q3sRwvFduuL6kZtDHuDx4Ak/No+mGg2t3kJND9z2P07Ku+EX/V+MnnPwJif3XfnmjgJ 4CUMmoK0AX6JrHDrNm9SB+2AgD8zRVuVr5Y8dLXUlZKSY9WZMv9sKTna19Un1nSTJztVKW P2wNfYMgA7z9I3iaNedFVh+Gz3JavjNIjfUAffS8LZDDwNCcYgY6+nDNcWfIS9yT2tjcIp n7SigInRbH6G5LS9O8mkLEQH6Qo5S4lqHn2SkSDcgJpO2IM3lx+X36Z7jUHBeg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTWGq1LlczrTW for ; Tue, 17 Nov 2026 17:01:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d1b4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 17:01:39 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 0ac384ad6b58 - main - gssd: Fix unix credential squashing when accepting a context List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0ac384ad6b5886f50f952acc4d5ff06a25bc1ac2 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 17:01:39 +0000 Message-Id: <6afc8873.1d1b4.4274b650@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=0ac384ad6b5886f50f952acc4d5ff06a25bc1ac2 commit 0ac384ad6b5886f50f952acc4d5ff06a25bc1ac2 Author: Mark Johnston AuthorDate: 2026-10-27 14:31:32 +0000 Commit: Mark Johnston CommitDate: 2026-11-17 16:57:00 +0000 gssd: Fix unix credential squashing when accepting a context gssd_accept_sec_context_lucid_v1_1_svc() handles context acceptance when MIT Kerberos is in use. Its last operation is to map the Kerberos principal to a local credential subsequently used by the NFS server for the authenticated session. If it fails to resolve the principal to a local user, it is supposed to squash the client's credentials. However, it failed to set the UID field, which will end up set to zero, corresponding to the root user on the server. As a result, an authenticated principal that doesn't map to a local user ends up being treated as UID 0. Fix this. Use names for the nobody user and group. Approved by: so Security: FreeBSD-SA-26:78.gssd Security: CVE-2026-101315 Reported by: Erik Power Reported by: SecBuddyF, Tencent KeenLab Reviewed by: rmacklem, cy Fixes: e3ac01e18eb3 ("kgssapi: Fix the kgssapi so that it can use MIT Kerberos") Sponsored by: The FreeBSD Foundation --- usr.sbin/gssd/gssd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/usr.sbin/gssd/gssd.c b/usr.sbin/gssd/gssd.c index 5a00dbdd7c97..711e10624155 100644 --- a/usr.sbin/gssd/gssd.c +++ b/usr.sbin/gssd/gssd.c @@ -28,6 +28,7 @@ */ #include +#include #include #include #include @@ -939,7 +940,8 @@ gssd_accept_sec_context_lucid_v1_1_svc(accept_sec_context_lucid_v1_args *argp, result->gidlist.gidlist_val[i] = groups[i]; } else { - result->gid = 65534; + result->uid = UID_NOBODY; + result->gid = GID_NOBODY; result->gidlist.gidlist_len = 0; result->gidlist.gidlist_val = NULL; gssd_verbose_out("gssd_pname_to_uid: mapped" @@ -1172,7 +1174,7 @@ gssd_pname_to_uid_1_svc(pname_to_uid_args *argp, pname_to_uid_res *result, struc " to uid=%d, gid=%d\n", (int)result->uid, (int)result->gid); } else { - result->gid = 65534; + result->gid = GID_NOBODY; result->gidlist.gidlist_len = 0; result->gidlist.gidlist_val = NULL; gssd_verbose_out("gssd_pname_to_uid: mapped"