From nobody Tue Nov 17 15:18:56 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTT0J4pxpz71DVX for ; Tue, 17 Nov 2026 15:18:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTT0J4Cpkz4skZ for ; Tue, 17 Nov 2026 15:18:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794928736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+/4/gEW3B0XI69e9eR9TzvGB8lTAvf5B9zIOPQh+9fQ=; b=AwARxnsZtgx9SXD5xlA4DVoc1P/lcG4YtzYitmbJRregdB34bQf31e0A2gYgfjW9b8DwRQ Z31cR8f1A4damHUVN9qMpM0mMChKk+m7q6lT42PZ1EEzQeoBPNNyc6BPI+QgApL3nBkqXe xxE8aGd/ocYKCJOi1qS4UfFPGEbLco3nR5Xn5io/X4I/5019XY4QMmdW7RwaXymdlkCOVE sIs7nVN8rqacd5ckw26EDwjB2WQWS1ChqyK4iFHrrrLiIW0ADfzCYFZJdluo5CNmgufIHp Ma21cb6fgkIlmJyFmDl/7m330FwwD6VHULIXOdld56OdkdHNHgqkgfLb8GT9tQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794928736; b=d3S+UN6+eXKtoA/nBZhku6V7OopFXV2TpU9WRuwkMmjeY/CPmEUnERbRqvwZJTsdl8lsQB 45JLoskwS/I/6cR8iIUfDuJZ1E490+eWypXbqRtElbB5rx6uoqICSI9co3tprgDLDnayZg QkWmQT1kRtzgDO7ZWbiXH/PyXORWzLCjBNFnbiNePv++kozAjX72BRYbia8jGbf4SZlMoy oSrgxrfefg+F3WP2RPRrnS8hxChDgLA6MooIpgEsdJ/aE7E4TaiRddntzuQQlyrbsXyz/T s07x0P36HRw7UeX2pMGQmJURYqpU/rTCR4dyq2GUZsXasOcX8KTKleOLflD7dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794928736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+/4/gEW3B0XI69e9eR9TzvGB8lTAvf5B9zIOPQh+9fQ=; b=wc0EuYpKOSkwKvSgOheGmwLmrKmzDHrZbq1us4tS9zr4WbrwJxwv9QyFAA5Yng/LzHiQ50 aCmHM65IPSYjQ+IMOpd2lot+fsg57q73+u4iEHzupQ0Yxsdq3/2QWIZeISM0bYiavT1whP ledIJdW/hl89Cjglco/4d6vaHiRuC8KSmHUZQpto3RMTzfRXe+kzw9rvYQ2l1gGGZm/tiI 1ttVgxV/5IkPVfdwTsrM6R2wCmrjpC6lBBFejTkO3YP4isd1RgT24doCx8OB+PsrlVGktw YcpgUpEqMUMWVZ7NgAAyXWXkZ5PCMmFrx7MhwYLCJp3pTZWTTOPD+q5XzSJXNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTT0J3t9mzn6b for ; Tue, 17 Nov 2026 15:18:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 120f9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 15:18:56 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Baptiste Daroussin Subject: git: 4a2340ccd44f - main - pkg-serve: fix stack leak on read() error List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bapt X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4a2340ccd44f8fb3edac8f63e6b0a8e657a2fd64 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 15:18:56 +0000 Message-Id: <6afc7060.120f9.16a89332@gitrepo.freebsd.org> The branch main has been updated by bapt: URL: https://cgit.FreeBSD.org/src/commit/?id=4a2340ccd44f8fb3edac8f63e6b0a8e657a2fd64 commit 4a2340ccd44f8fb3edac8f63e6b0a8e657a2fd64 Author: Baptiste Daroussin AuthorDate: 2026-11-17 15:17:52 +0000 Commit: Baptiste Daroussin CommitDate: 2026-11-17 15:18:42 +0000 pkg-serve: fix stack leak on read() error read() returns ssize_t; stored in a size_t, an error became SIZE_MAX, so the r <= 0 test missed it and fwrite() sent SIZE_MAX bytes from the stack buffer to the client. Use ssize_t and cast for fwrite(). Reported by: llm-postcr --- libexec/pkg-serve/pkg-serve.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libexec/pkg-serve/pkg-serve.c b/libexec/pkg-serve/pkg-serve.c index b087f9971c3f..5fda81d689e7 100644 --- a/libexec/pkg-serve/pkg-serve.c +++ b/libexec/pkg-serve/pkg-serve.c @@ -68,8 +68,8 @@ main(int argc, char *argv[]) cap_rights_t rights, ffdrights; char line[MAXLINE]; char *file, *age; - size_t r, toread; - ssize_t linelen; + size_t toread; + ssize_t r, linelen; off_t remaining; time_t mtime; char *end; @@ -204,7 +204,7 @@ main(int argc, char *argv[]) r = read(ffd, buf, toread); if (r <= 0) break; - if (fwrite(buf, 1, r, stdout) != r) + if (fwrite(buf, 1, (size_t)r, stdout) != (size_t)r) break; remaining -= r; }