From nobody Tue Nov 17 13:52:18 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTR4M6CcTz713sQ; Tue, 17 Nov 2026 13:52:19 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTR4M5b0mz4bjr; Tue, 17 Nov 2026 13:52:19 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794923539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rBblPS+j5uiFyj927JRQMWK6IdlpSy++rKeq2qAK2iw=; b=thjuFwb+zNktFmDNq1NYSRXcpw5Jk6yfMKKTuZRe8xhnsCrBjKbSLymqatUxZ+cYQmhFVT rLQnbbyvqtgJqWG5+mXoSA5TxDWCBz/eh+Tp5aQ9cQCEug7zRwTBbTyekyY74zeBDL0cpu N3EKbQDWnQrFCuuMI5ZogqmusFm7W21wyydbxS5VsgAcCazK7GjfGOYT3bw8EJmpPv34rw +bWoyPEZ8yg/Q6Vk6YqsHXhMYKUN5TNwwOjj1UykEIHEJBgBZ9rSgIMDNw+CF45YfIZlMt Mz0K3ECaj4aOWiZo+EgR3cxoliCx8qbfhJwoPnZydoO33zz+RObt2HHwknfSXg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794923539; b=XSO2+l4s1Yj5m3FUJPZ/w2UNM5lqeBK3j61cL4aMqSNoh4+wMcRqlMbORqvD6YEqCJJ1O+ 5mdS/oINrmrUambzozT0xxv0xCxDovjajjjsFCbFH+Ow9HF6F+gW0ifKVwC130gGolUtwS bmddhrC7EOQ0TXisLHW7NMbt9yHQzrDSvDvKAWnCbTPHqYZXl3HpRzsy/HdJAF6mOuz/uw fRnAE3SQKAgRVR3b7IphH7WHFviMnJSq4XrzQdhkc/bLiS31l4esRNuFjPjYirHSymp5w3 B7jfU5+UrwguKP/CLZnjl69cP7STmpmX/2LAQfH01lqAJs791nPRKwns2cueKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794923539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rBblPS+j5uiFyj927JRQMWK6IdlpSy++rKeq2qAK2iw=; b=p5P4znPo/Fdk3Ww/3uIaJRtT5KenfkwlmruFepCP8x6JEPDyE0DqddALnzbY4aD5MSw/Ym cIsvoLm3/2DYnuAzLnEueYMamzRqWqpWvUH5X+ckge5veYmZBpF2oGf8KuvpOab2yISiaM 0jSEhON+mnhkAzpnmQrzzgSWQCYGb2zfwUXNz6cjxgPNDHXRYLX9sQGOUgD2g4CjU+U/Qx 102p3mj+gWzq0vBvVtjyWbxr+7uMial24yXsiVwbW7KSUrxQhhgtXN/FVvBtUAgvXPEyrT qIKxqqK5gKbXVB1VbItalQRp44IQ9lzNXxyHQJ2pWRk0FHj8uedP60f3vxFR0g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4jTR4M55rTz1Mvh; Tue, 17 Nov 2026 13:52:19 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id A7B493C01A0; Tue, 17 Nov 2026 13:52:18 +0000 (UTC) Date: Tue, 17 Nov 2026 13:52:18 +0000 From: Brooks Davis To: John Baldwin Cc: Olivier Certner , Konstantin Belousov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 3a1f5a28f007 - main - proc.h: Order thread_lock*() functions more logically Message-ID: References: <6af88c7a.1655d.45212520@gitrepo.freebsd.org> <2634373.0dHE6SNnxz@ravel> <15663fe6-a938-489a-9c9d-c9514c8b6781@FreeBSD.org> List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15663fe6-a938-489a-9c9d-c9514c8b6781@FreeBSD.org> On Mon, Nov 16, 2026 at 02:08:35PM -0500, John Baldwin wrote: > On 11/16/26 03:14, Olivier Certner wrote: > > > The functions were ordered alphabetically, as it should be. > > > > No, they do not need to. In some places they are, mostly because of history or because nobody bothered to classify them. It is generally much more useful to group them by usage/category. Typically, functions that must be paired should be adjacent. > > Hmm, my understanding of style(9) from bde matches kib@ which is > to sort alphabetically. That said, in practice I tend to do that > within groups, that is if there is a group of related functions, > I sort them alphabetically, but may use separate groups instead of > one giant group if there are comments for the groups. IMO the important thing is that it's entierly clear where to put the next thing. The easiest way to do that is to sort things. (If you see me sorting lists before insertion it's because I can't figure it out so I've given up and sorted them.) If you're going to group them, I highly recommmend blank lines or comments to break the groups up. -- Brooks