From nobody Tue Nov 17 13:49:13 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTR0n4kGVz713Ht for ; Tue, 17 Nov 2026 13:49:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTR0n423sz4ZJN for ; Tue, 17 Nov 2026 13:49:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794923353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4XCmIZb3mT5XZxYrl9qrLNN26uDqJ/Zf4zwcAIlIiiw=; b=d/OPSLiE6WEaHgb72JoPnTBsSOyP22lN30qkRPG93GKwtaveXCWbXI1O3sts/4bcayMkZ5 TmTHCT530vpLW9CfuY/z9kz8tGoaIU86RnTSzwJmWox7wEoNhXuTD2f5XZHFMy5cPvO5FG qKkWrDQELmmJIt8FLG6riqrN7K426vPtgUVhBxytQVELCD//f78n0RY1oSkY+Oeog2LvgT B7X41tvOWo1Wjt7fr31EuRos6CF1HX19mEemqR/gC/kG2e6oiAY80BJNkRZH9I0YyYYYXN aWIqca1YYafZe02wZZQiZi+za8/PJmGkqTMwwepRfFykk49FugX9NOYPiCFsmQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794923353; b=jjPehUt9/FYD/E1UlrpVEzrH4sLabG69qVVsvabfIzEamN3ti1J6vMdGk+91FvKEQZD/L3 29DmcmpgGvEeAZB6EoLAEgmEG50nWXOYowci2TGn2nQGxs+JkyN+PdTyLRc+/Buj40pz0U R1+j3/iv688Fp5H9/qw8K1CP9LYqS6Ymiw5dUfcb9u08mlXMOzPBd6FDYIwZ28P7yXKYZk +ZKjESRhEBWzKlFrTv9mg1+pWsv/iMFUXFq+owQNnpuwkM3GUVlR3zTQM4eKkwlJlPbq5I jHlF/tl7PzrvWPpKD2olOy2oFJ3BEJHiBb8fCojSGToaB8NJdY+3AqgGf5XSsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794923353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4XCmIZb3mT5XZxYrl9qrLNN26uDqJ/Zf4zwcAIlIiiw=; b=q2mDoc2jTe1F5jAcn3WX6Uj5u5xIfeH/rN1nqzTNTTCvsJK0l19LpzEVIUUlRCD1km/n3M jOWCwTGYbueqo8tqV7kWd8mc/L4+bs/29rPj8oejzN3ud48xmbrtTHicvC4sx8053X1rjQ 0vb7HU6Ik/ss2bieeK/gG2+WKudQmOkN3alBDMy0NDxFOowgH3cpGJ7d2hQgmbQrMLBEkE pr0q2pKt5A4ijv2wBnl7ClbZyTJPk4np5qZG9RX7mkNbpRWDYqmGzO5Y71Wcd/5kygdfP/ V+Qp42vR+ZFSwV0ieXZL4egc+7KP3clAzYyWzci8+FqvA9952p9v5oL80n4CSA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTR0n3j1yzkt8 for ; Tue, 17 Nov 2026 13:49:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 9ca0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 13:49:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Osvaldo Janeri Filho From: Mitchell Horne Subject: git: 98b0b0a08d89 - main - tests/sys/pmc: Pass pmcstat -n before -P in pmc_callchain_ur_test List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 98b0b0a08d896f74b7f630145592c489fe14c987 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 13:49:13 +0000 Message-Id: <6afc5b59.9ca0.523ceea3@gitrepo.freebsd.org> The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=98b0b0a08d896f74b7f630145592c489fe14c987 commit 98b0b0a08d896f74b7f630145592c489fe14c987 Author: Osvaldo Janeri Filho AuthorDate: 2026-11-17 13:40:38 +0000 Commit: Mitchell Horne CommitDate: 2026-11-17 13:49:08 +0000 tests/sys/pmc: Pass pmcstat -n before -P in pmc_callchain_ur_test pmcstat -n sets the sampling rate only for the sampling PMCs that follow it on the command line. pmc_callchain_ur_test passed it after -P, so UR_RATE was never applied and the PMC sampled at the default rate from pmc_pmu_sample_rate_get(): 65536 on AMD, and 2000003 for inst_retired.any on Intel, about 20 times fewer samples than intended. Move -n ahead of -P in both pmcstat invocations. Reported by: llm-postcr Reviewed by: mhorne Fixes: 546a76463123 Sponsored by: Advanced Micro Devices, Inc. Signed-off-by: Osvaldo Janeri Filho Differential Revision: https://reviews.freebsd.org/D61458 --- tests/sys/pmc/pmc_callchain_ur_test.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/sys/pmc/pmc_callchain_ur_test.sh b/tests/sys/pmc/pmc_callchain_ur_test.sh index eb4dafe8ce5d..489c6f3185a9 100644 --- a/tests/sys/pmc/pmc_callchain_ur_test.sh +++ b/tests/sys/pmc/pmc_callchain_ur_test.sh @@ -54,7 +54,7 @@ ur_pick_event() local ev for ev in $UR_EVENTS; do - if pmcstat -P "$ev" -n "$UR_RATE" -O ur_probe.pmc \ + if pmcstat -n "$UR_RATE" -P "$ev" -O ur_probe.pmc \ -- /usr/bin/true >/dev/null 2>&1; then printf '%s\n' "$ev" return 0 @@ -85,7 +85,7 @@ pmcstat_U_survives_and_samples_body() "(tried: $UR_EVENTS)" atf_check -s exit:0 -o ignore -e ignore \ - pmcstat -U -P "$ev" -n "$UR_RATE" -O ur_capture.pmc \ + pmcstat -U -n "$UR_RATE" -P "$ev" -O ur_capture.pmc \ -- ./ur_load.sh 4 after=$(sysctl -n kern.hwpmc.stats.merges)