From nobody Tue Nov 17 08:15:27 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jTHbg4FCzz70sn8 for ; Tue, 17 Nov 2026 08:15:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jTHbg2N7sz4qGn for ; Tue, 17 Nov 2026 08:15:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794903327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uoVb6DWhkXAtH9m/xEZ5m+1CgwhqhUZihqpykSkVuz8=; b=ApFV3sUQBjBcrTBpy33qaLkkfT+6ptLm28/WnJFFZkByVAFA9oZOHwBDC8QMCxHSBBwGlz vbReul9mDpsO2u33C1J+1lGoTTFw5FMtw2EUoL4uW2D0bNwYD5E1SGjcNk7pZps0DsgToZ GtMRbpO8q9xrZl3uOrKhkJCGIeb+StpJ1HDQMkrQnIusnMa3ltGIwR2QjcsnEUJDt6uz0i 9ue8e1SWXzZ6xiAEvVDa8kebi+085SaJpcecKVPENwMfH6CJ8hC9+ujKc+nTuP27Nk5dPc J73z2aO18zifoLRoglRMRk97pIS5hLkLVZVbUXohz5fKsVqBglwhKmzqyRnOUQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794903327; b=PEbop+MrpYWdse4+Jn3eYA/NYDhLnf1ZLCYUb5IF9y6oqM3ttkR2NyTMUjSm3ZbSqgyvFc rG927MRoC/KY1lvP43dz6rAZEr6JANVuvu0srfzQpxUC3Kcft7JwIksXH+a/YEuHXoA/AU w6SnnbR+cuhM/Uu9OfWKRuwgOKrV34G1zTfmkDi/0oYSVw8yzvg77iYmZj2CDJZ/pQJczt wF3hq+kJZzub5O0cf31X9t459rf2PjtNOdoL1GmxPHmBWhAHqnghMkxoVoG9Jw7oAdvj1u ydeeTHt42kLjlw1XVCtYS1hFglPY2QIWeEiSVarRwaZtFjlSTbFyG5PNV1xLMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794903327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uoVb6DWhkXAtH9m/xEZ5m+1CgwhqhUZihqpykSkVuz8=; b=THFTQwXv8yPrVUX7Nzbvkpi7mfBhDA14CKJDXD9lJmPY2flmxKGTYPkj7GKUqEpBSidw0E XO91wehFDPhpab1md/ANcV73MdXP38VPsnzKzyyoSpENrHiAnEk21OJbIl8fbt23/ehOhp dOCfSAvWtu98fRBkajLfcjo1s18qow1HnKcKg1HayCSGWVQgr1/wGs+d2FmZ/Nhor6pyNQ jpl0MHPIO1cRhIIs/WCh/TVAUJ3U86wkxX3jKbQM/mjXsP8VUZbUDK6dt/szHu2Ca+Tex2 0dzx7u2UWq/E3vr07y0JtqBk0MMNSAkWligzaLTNj7X1N/9QJny/F9KjlrWxSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jTHbg1NZYzZCY for ; Tue, 17 Nov 2026 08:15:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 82e1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Nov 2026 08:15:27 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: f58613868b50 - main - snd_uaudio: Fix the MIDI TX round-robin List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f58613868b50dfd6c2adc7128ea60d7b276fdbf1 Auto-Submitted: auto-generated Date: Tue, 17 Nov 2026 08:15:27 +0000 Message-Id: <6afc0d1f.82e1.57f7910b@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=f58613868b50dfd6c2adc7128ea60d7b276fdbf1 commit f58613868b50dfd6c2adc7128ea60d7b276fdbf1 Author: Christos Margiolis AuthorDate: 2026-11-17 08:12:28 +0000 Commit: Christos Margiolis CommitDate: 2026-11-17 08:15:07 +0000 snd_uaudio: Fix the MIDI TX round-robin Nothing advances curr_cable, so umidi_bulk_write_callback() only services cable 0, which is a problem on MIDI devices with more than one jack. Fixes: 039477d3e7e7 ("snd_uaudio: Simplify chan->curr_cable calculation in uaudio_bulk_write_callback()") Sponsored by: The FreeBSD Foundation MFC after: 1 day --- sys/dev/sound/usb/uaudio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/sound/usb/uaudio.c b/sys/dev/sound/usb/uaudio.c index f918e1245c47..331cbf68d1b9 100644 --- a/sys/dev/sound/usb/uaudio.c +++ b/sys/dev/sound/usb/uaudio.c @@ -5945,7 +5945,8 @@ tr_setup: } } - chan->curr_cable %= chan->max_emb_jack; + chan->curr_cable = (chan->curr_cable + 1) % + chan->max_emb_jack; if (chan->curr_cable == start_cable) { if (tr_any == 0)