From nobody Mon Nov 16 21:01:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jT0dd1f1Yz70wVT for ; Mon, 16 Nov 2026 21:01:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jT0dd06Jxz4DDK for ; Mon, 16 Nov 2026 21:01:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794862869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wfLcX+OhhZZ0bx//DkK7mZxXP6PDfoKHq+IiBRRZld4=; b=wXkVAqyRk4SXGtzBbIlyhYCIrY5E0AB/UwD0c3w7XImbFUFGBTlAdO8LQd3fMOtzGz31q5 npSDc5rbfK1nn4XK3HqaOYIh2k7opSfhkCrtrjU2AxYpzcfjgcfjrVKgjkUgQrHrFoVLBs c5V2pDQ5MyJwkP2WEJp93kFWP0ceQjkm/PLmvRCy0Ibl/nRnumGRRdM8QOdj3qQKNWIRL2 x0qrHDbA5Z8ZxmBfep265W9pXa92yKUMe43fRcpgXsXg8kreiiLHuGMw35TDJcH1MmvUKJ b6durAEmHReefcbH+knAqnhAL1BArLFKAKVnTG7sDoh3PwmKlEYBzoY25KR+nw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794862869; b=Om7UbLaXFsH91e4PsAQKatj2QRr5DaXBpPZhe7FHs9uNefh/7l9wJxPYVLZNBo0JsfMqwJ rRic6lrf0aRYNhoCEUAhAcu+tYIXs99Nv6gQi11xISw3xtHJ5E2H5ZQ+eowmZoboU+M9HA D6KULyQ1YHcCOYa161mXcOnS4yzVbgpErXCBCmhDCGDO7KeoDu3vp8jT8P/XcdfLc9x/79 2vlLtLmnWGhiGfn37eJFZsDqCJKawPV/wY6MQZqcXPY2XbCQ1Yb6vrmZGSkbIJC0JUPpl3 Aw7ExC++F2FjJwSatOSlwxO+REzvYn/Agxz1ByryFgZS/YhOpvRZTbJ0hMJ3Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794862869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wfLcX+OhhZZ0bx//DkK7mZxXP6PDfoKHq+IiBRRZld4=; b=hA3QhRLb8ObY8CR5R7vRuu8hons5OUMPwfK5skhFLhqRVhCZOVoKHtpwjOY/6/Bcxd7glX efJX9fnCoPn/CGw3s7Xx8Wnh4GOoWKPZ0mJyjbN3c/whVzoit5kUioTprkhqzoqwMRxjuD bRYnKuHkckMz2P8+iXXVZwMBD2mdC+z97T/wl+Q6BCnZhEfk+/L0gz/e5awV2hTvyOH9vW i88ILpxkM9k3vel+TJEwHsXMhG/HYRXMyzLMwyBbD8uuvql4K+DAkLrQQvHQUpFu3/MZxs yUC2bbx7gb6Ht+fG9A29/c9pN8AWclgJOQ2wJcSUdtmo1pgrWl1/1PqblXN+lQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jT0dc6C7Sz19ZJ for ; Mon, 16 Nov 2026 21:01:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 9e00 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 16 Nov 2026 21:01:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kenneth D. Merry Subject: git: 6a901f5e3686 - stable/14 - nvme: Fix the data length in the Reservation Report command builder List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ken X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 6a901f5e36869c71b3ffbbea13fdc34cb7716e5d Auto-Submitted: auto-generated Date: Mon, 16 Nov 2026 21:01:08 +0000 Message-Id: <6afb6f14.9e00.1df9d514@gitrepo.freebsd.org> The branch stable/14 has been updated by ken: URL: https://cgit.FreeBSD.org/src/commit/?id=6a901f5e36869c71b3ffbbea13fdc34cb7716e5d commit 6a901f5e36869c71b3ffbbea13fdc34cb7716e5d Author: Kenneth D. Merry AuthorDate: 2026-11-09 18:46:58 +0000 Commit: Kenneth D. Merry CommitDate: 2026-11-16 21:00:06 +0000 nvme: Fix the data length in the Reservation Report command builder nvme_ns_resv_report_cmd() put its length argument, which callers supply in bytes, directly into cdw10. The NUMD field is a 0's based count of dwords, so the command asked the controller to transfer nearly four times the size of the supplied data buffer. In practice controllers limit the transfer to the length described by the PRP entries, which is why this worked in testing, but the command was incorrect. Convert the byte count to a 0's based dword count in the builder. Reported by: llm-postcr Fixes: 7a9e4375316b MFC after: 1 week Sponsored by: Spectra Logic Co-authored-by: Claude Fable 5 (cherry picked from commit 86b9d629c68f6dc63543b9c0a6da6c96c857f3bc) --- sys/dev/nvme/nvme.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/nvme/nvme.h b/sys/dev/nvme/nvme.h index 658461096b0a..350c7502259d 100644 --- a/sys/dev/nvme/nvme.h +++ b/sys/dev/nvme/nvme.h @@ -2121,7 +2121,8 @@ void nvme_ns_resv_report_cmd(struct nvme_command *cmd, uint32_t nsid, { cmd->opc = NVME_OPC_RESERVATION_REPORT; cmd->nsid = htole32(nsid); - cmd->cdw10 = htole32(length); + /* NUMD is a 0's based count of dwords; length is in bytes. */ + cmd->cdw10 = htole32(length / 4 - 1); cmd->cdw11 = htole32(report_type); }