From nobody Mon Nov 16 18:33:41 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jSxMT19lqz70XG2 for ; Mon, 16 Nov 2026 18:33:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jSxMT0X1yz4Msg for ; Mon, 16 Nov 2026 18:33:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794854021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WG6KVa2i1iM9CFKAPk7AMlBjNGEoi96ktpmhyger+nY=; b=FJqrkznaVxRNr00IRd4zFHj1G6peSJm1R3FZ3/r/SgavGVK7rI3ml677CALjmMS8G2m3Fm asGf1ccP2oZ4w8l0kdnJEzwxcoPDSWTJgmjr7+ikllk5zh7zvwz/UbsTOAQ0Iapd8s84aO LII7vH6/c+n35Jd71LFWJ8JmyWYK/hkP0Zt4pUTjcCt4zvsitTqT59uOUlmJhmwNYb1fmD FWCGkAOH8uTf6COuBRus1+O7/LzTlsVlqWa2iqSpVJAese3li465+hgrun0y+4D4t6uq+Q BQrMlO9B/XDz29vNz1wvLZFQ0ZJwPz0/oVOQd73Rlq7sQWMqb09R+D51Epyjeg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794854021; b=EFg6rwyZp1WXH0a6QkHe1yo2Kbwp0i5yev5pE9g1KShmqrxy1oBizJdM1jKq0OFswP6fgh Ygr1UfA9Tig+f79SHyr2kaFve3oqEP+ViYZ1WJKYQ6RYH4o8FQyNeKxXtX+MXdNbPtCluY P7ss9b+9umYCxUfc2vy9880aqzaj9p1CgwZS8+6RM550eXK32+GjI4e60L363aH5y2t2vl eMDnKLxrG/qhqQS8M9TfkaVoU/WfPZq9eYdMBUE8zSVXrNXQaqj5QuP0v8WfgiQ7IcGRIx gUZPbYA1K9LCXv4Y8wUJ8A2t4M9HJ6HiV20U5gZMsTvPdpFpzAhw8E/76UomVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794854021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WG6KVa2i1iM9CFKAPk7AMlBjNGEoi96ktpmhyger+nY=; b=jfLYc0iFu/jrk0del6S+nv8Br5EDW8lQ7z8J5rvFcQeTGXokXY2ls97nPZKsqZGjaE+oXQ hqk0ByrFQ+Prnghe4NKhjZYd60xTAqJNh4hzeiQ5FVFg23WQnFaN2GPiYFEMywC6poNHjl VMp6L2m7yYJbIbp540Q0cStfFMukiEk9LWgKcmDyDYYa1s0ANGMGJ50N/xsjcxW4/14C9i SrKqef7/DzZa6+4QEOpHLE9oIIz0Q2WmUOkwdqR/jmSgIzFKGoFOfTNOgww5JXIB1idUiP djY1pmJDH3B/P1XS1j8j2fqN1xNSTuNmRoL92sH69eya4wUEKA0j9auVtTpmmw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jSxMT0C9Qz15KQ for ; Mon, 16 Nov 2026 18:33:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 191f6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 16 Nov 2026 18:33:41 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Wanpeng Qian From: John Baldwin Subject: git: 596a470a1baa - main - bhyve: e82545: deassert the interrupt when its last cause is masked List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 596a470a1baa5c828ab78918ce4301a96a057f4c Auto-Submitted: auto-generated Date: Mon, 16 Nov 2026 18:33:41 +0000 Message-Id: <6afb4c85.191f6.2d709831@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=596a470a1baa5c828ab78918ce4301a96a057f4c commit 596a470a1baa5c828ab78918ce4301a96a057f4c Author: Wanpeng Qian AuthorDate: 2026-11-16 17:52:42 +0000 Commit: John Baldwin CommitDate: 2026-11-16 17:54:46 +0000 bhyve: e82545: deassert the interrupt when its last cause is masked A write to IMC only cleared the bits in the mask. If the device was asserting INTx for a cause that the write masked, the line stayed up until the guest cleared the cause in ICR. The hardware deasserts INTx as soon as no unmasked cause is left, and a guest may rely on that: Windows masks all causes and unloads its driver when it shuts down, and then spends its time in the handlers of whatever shares the interrupt. Do what the comment in the code asked for. Signed-off-by: Wanpeng Qian Reviewed by: jhb Sponsored by: keelos.dev Differential Revision: https://reviews.freebsd.org/D60230 --- usr.sbin/bhyve/pci_e82545.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/usr.sbin/bhyve/pci_e82545.c b/usr.sbin/bhyve/pci_e82545.c index 1afcb559f2bb..b893c4e1b9c5 100644 --- a/usr.sbin/bhyve/pci_e82545.c +++ b/usr.sbin/bhyve/pci_e82545.c @@ -671,8 +671,9 @@ e82545_intr_write(struct e82545_softc *sc, uint32_t offset, uint32_t value) case E1000_IMC: sc->esc_IMC = value; /* for debug */ sc->esc_IMS &= ~value; - // XXX clear interrupts if all ICR bits now masked - // and interrupt was pending ? + + /* Clear the interrupt if no unmasked source is left. */ + e82545_icr_deassert(sc, 0); break; default: break;