From nobody Mon Nov 16 18:12:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jSwvP186qz70Tl1 for ; Mon, 16 Nov 2026 18:12:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jSwvN6QG6z4HpJ for ; Mon, 16 Nov 2026 18:12:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794852768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/wpXM5bahY3GNs9XMp4N87ouP4m4DoGd68+HYCzQtpI=; b=cNckXfsmyNTs1X1rO6qcREMZK+92LKMUwP9d1B8OrVZt9EEEYpDdcwwpKIq3Mfd3Sx0+BB F0YUK+8uyUclmRvovzU2fFjNfXBQRhxe1fcnyvZ4nqHbmSRa+i8yR+aklU2YxWNwKLmOdy ea1a7FlK5brQ0l1XeojktGkcamosqaeEi+9K9/C3P2RtS3V38yBVxnqmF0QPvBJPJ1Omzq 4l9nQwB1/iBIB38q/Yj5vwdgxDap1YZzBbXwjetboymLgyUCulc5FBI+1obhm2lqt/wd7B bqtpCC+ztwzyHMZL+CHdziqL1rBsMoasK3nAU/e+IxWEwc9T1hfIxgl2dVh2rQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794852768; b=NEwAz+5OT9vM/xCKc8YDq+1GuixN48J8CmJS2I6lQQpgGQBAKobMSm4sNDXe9Qcqlluhj5 XQxyXMu3Xj4EBn5S/cLaOtFKghI7dHZufnkg9BmnWix8uOzyEMQHvUyiKcypviFnHOrxOO jekWJdiXIa8ZffEbsGG7f4+X19xEM0StO8HaPE6h3TyF1QFfxhJ/kj7xeh/Nz1aG8w+l2p Jx4sOYqtljALSYqbQUJOKBEecm6npidESYa3vn4zusAtgstfRQsv8CUGoYJ4q4LzNpyNHQ Yo6O4jAcrbS03DoIz0s7O4Kf/DuXfP+1c+cFeyPT3R4OsH4/WkctVia99v14Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794852768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/wpXM5bahY3GNs9XMp4N87ouP4m4DoGd68+HYCzQtpI=; b=KZ5eGzyQ2xeBMUcOFRj6PaTRXc8NUXnMdakBWScFB0ArU/ZONrEXAhBcC5ZjSEKXyidQTP uDiF3YXZL0ajDQER8InCqwGo0bZbbxFlX6UEFK3KriDEoX+rvVpo2FmLlV+StDJcC47zo9 PP2lobSMFG6UI4CjPkAtXwOXklkxT5cqcwnFf+nxPh5lGkpg4+vWs3JTDYVtdP9rrcw/yE vDciEYp1cZXOnI8A8BHZWwuPkVamNdIxjn6a9KHKavuLKMlnGrFbYQ1FX0Osfa4g7Skbrf eH+K4dkMijV+bP9Opk1sgbHyzMbta7k9QCGyHDUxO++GnE4A5k46qIaPsAqszg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jSwvN5l36z15Hs for ; Mon, 16 Nov 2026 18:12:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 173b4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 16 Nov 2026 18:12:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Brooks Davis Subject: git: a04f2d46dda2 - stable/14 - extattr_list*: avoid panic with absurd buffer lengths List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brooks X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a04f2d46dda2d9f3b9ef9409d47dbc097cfb9b3f Auto-Submitted: auto-generated Date: Mon, 16 Nov 2026 18:12:48 +0000 Message-Id: <6afb47a0.173b4.3ddc968f@gitrepo.freebsd.org> The branch stable/14 has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=a04f2d46dda2d9f3b9ef9409d47dbc097cfb9b3f commit a04f2d46dda2d9f3b9ef9409d47dbc097cfb9b3f Author: Brooks Davis AuthorDate: 2026-11-13 10:06:52 +0000 Commit: Brooks Davis CommitDate: 2026-11-16 15:57:41 +0000 extattr_list*: avoid panic with absurd buffer lengths Apply a layered defence: - Reject nbytes > IOSIZE_MAX in user_extattr_list_fd and user_extattr_list_path. - In extattr_list_vp require auiop->uio_resid to be non-negative. Effort: CHERI upstreaming Reviewed by: markj Reported by: llm-postcr MFC after: 3 days Sponsored by: Innovate UK Fixes: 6453d4240f6b ("vfs: Export exattr methods to reuse by Linuxulator") Differential Revision: https://reviews.freebsd.org/D61461 (cherry picked from commit 118067f51c111390dbc54760d781cd14a10c499e) --- sys/kern/vfs_extattr.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sys/kern/vfs_extattr.c b/sys/kern/vfs_extattr.c index 831090f02f90..9241e0984559 100644 --- a/sys/kern/vfs_extattr.c +++ b/sys/kern/vfs_extattr.c @@ -694,7 +694,7 @@ extattr_list_vp(struct vnode *vp, int attrnamespace, struct uio *auiop, sizep = NULL; cnt = 0; if (auiop != NULL) { - if (auiop->uio_resid > IOSIZE_MAX) + if (auiop->uio_resid < 0 || auiop->uio_resid > IOSIZE_MAX) return (EINVAL); cnt = auiop->uio_resid; } else @@ -736,6 +736,9 @@ sys_extattr_list_fd(struct thread *td, struct extattr_list_fd_args *uap) struct uio auio, *auiop; struct iovec aiov; + if (uap->nbytes > IOSIZE_MAX) + return (EINVAL); + if (uap->data != NULL) { aiov.iov_base = uap->data; aiov.iov_len = uap->nbytes; @@ -814,6 +817,9 @@ user_extattr_list_path(struct thread *td, const char *path, int attrnamespace, struct uio auio, *auiop; struct iovec aiov; + if (nbytes > IOSIZE_MAX) + return (EINVAL); + if (data != NULL) { aiov.iov_base = data; aiov.iov_len = nbytes;