From nobody Mon Nov 16 18:12:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jSwvT37Y3z70VJn for ; Mon, 16 Nov 2026 18:12:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jSwvS2XDxz4HgR for ; Mon, 16 Nov 2026 18:12:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794852772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R/Iy4k1FHAr+uWFYG5pSHmdn6goLmFOukcyn4NgFoRA=; b=abjV41AZ8bfR739lgnrjgNDGoyS51Q2yoU9CR0R9Pj0eI5X+xa7p9JdPoDZ0LfgjR9lv5k GR/LBHf0ZhOpx97Pbw6Lr2sRGtwnBO6egpW48Y7nt/ebu9gC9clK+QtHAifFXEwmNlmOcX CvlHHa4mhvTRQnchwuVwVNYnC1nelFxjYgCmB9zXMSj4PQEddar5GeHnUqp/AOJZ1lGcnB JK1uj8moN8GA+exRcPQTPjpZmGtJSbI29BYcyZ8JpgeqUVgqvnT2A29f3W1T8BCQFlpOe1 tG/rppQgTeHQoQqHO8zHq1NYsKQt9YX1pOx1BldbCPlHgA+t4dlXkjS0ZJcB+Q== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794852772; b=iptEyU0Ujiinbc7zUTMeTJotBFv9/CtUdWutm5dj+HzajXMapLlqeabkRYm6/eiaB2SF0M JDElD+p1hHXbiwz+iRjgE4FCb6Le8ZN9987Bu0KG5idsCpSZR+rqshgVMPXSF9glstkZFv fT3eSbV2wzYm2/ObEP+Zt/6zxLhrP0R2epwJ9m2JrjMLYCo69zZqKPK9DnsDZPRlsWtrAZ hljnRs9fzEfnwSxvZc6wlRGDmRKFl0UUT5X7eKVWW197E0e3LJGau9lTHImWzjAGVHIpA4 on6MqLIgxwymMbivgQAcq/6SOsniUSQOZszUFDEZIm1V+5zPEre2C7ZOVoY2AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794852772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R/Iy4k1FHAr+uWFYG5pSHmdn6goLmFOukcyn4NgFoRA=; b=kafPPU0RrXKNvBDMuVhRXD+RI4RLM65JEXcf1h9a6F9wjMG/vwZO/XfjhEut/5kRKQYFR3 mPs6mX6aYPbjSq41Nx4jUgmei/opq3uFQqhY/uA1MgKD0Pvt0q6n9Io38F05d2u5G1+R+O E/OYh50Z62Nf/0u9m9UlDHHrpP9DAPerjaIkLypgRw9VdBOSGISTWzUv2ALglKfKtJGzg7 E6Qdck6XDh2TkYihgD7EwrlDqm13dzC9ozuVtqs8QfDdX6bDp10gdN8RMSwu67kIk6F+TN 9iM1Jm+Rc1Sdk0SzseQUrMg5/EWOWOM1dELCFJ+Nq0lNtN8hPxCayQ6+2uSKfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jSwvR6jvbz14pJ for ; Mon, 16 Nov 2026 18:12:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1737c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 16 Nov 2026 18:12:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Brooks Davis Subject: git: 3b321d5d6136 - stable/14 - modstat: don't copyout while holding a lock List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brooks X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 3b321d5d613616f50d5667eee6ebb9effd47f187 Auto-Submitted: auto-generated Date: Mon, 16 Nov 2026 18:12:51 +0000 Message-Id: <6afb47a3.1737c.4ede1da3@gitrepo.freebsd.org> The branch stable/14 has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=3b321d5d613616f50d5667eee6ebb9effd47f187 commit 3b321d5d613616f50d5667eee6ebb9effd47f187 Author: Brooks Davis AuthorDate: 2026-11-12 10:23:24 +0000 Commit: Brooks Davis CommitDate: 2026-11-16 15:57:42 +0000 modstat: don't copyout while holding a lock If a user arranges for a page fault to never be filled (e.g., via a FUSE file system), this can hold the shared lock forever. To make this all work, refactor kern_modstat and freebsd32_modstat to malloc a temporary buffer and fill it before copying it out rather than doing a bunch of copies. Add COMPAT_* ifdefs around compat code. The module_stat_v1 code is really for a.out binaries in practice and thus a bit questionable. Reviewed by: markj Reported by: llm-postcr Sponsored by: Innovate UK Fixes: 7f8c2056db1e ("modstat: avoid copying from freed memory") Differential Revision: https://reviews.freebsd.org/D61432 (cherry picked from commit 1ebf46ecb6278e31d7ae029b0f8af3d64e7bc1f9) --- sys/kern/kern_module.c | 259 +++++++++++++++++++++++++++++-------------------- 1 file changed, 152 insertions(+), 107 deletions(-) diff --git a/sys/kern/kern_module.c b/sys/kern/kern_module.c index 0f04deac16d4..7083a406daed 100644 --- a/sys/kern/kern_module.c +++ b/sys/kern/kern_module.c @@ -358,6 +358,7 @@ sys_modfnext(struct thread *td, struct modfnext_args *uap) return (error); } +#ifdef COMPAT_43 /* XXX - COMPAT_FREEBSD2 */ struct module_stat_v1 { int version; /* set to sizeof(struct module_stat) */ char name[MAXMODNAMEV1V2]; @@ -365,6 +366,18 @@ struct module_stat_v1 { int id; }; +static void +module2module_stat_v1(module_t mod, struct module_stat_v1 *stat) +{ + stat->version = sizeof(*stat); + /* Not necessarily NUL-terminated */ + strncpy(stat->name, mod->name, sizeof(stat->name)); + stat->refs = mod->refs; + stat->id = mod->id; +} +#endif + +#ifdef COMPAT_FREEBSD13 struct module_stat_v2 { int version; /* set to sizeof(struct module_stat) */ char name[MAXMODNAMEV1V2]; @@ -373,6 +386,29 @@ struct module_stat_v2 { modspecific_t data; }; +static void +module2module_stat_v2(module_t mod, struct module_stat_v2 *stat) +{ + stat->version = sizeof(*stat); + /* Not necessarily NUL-terminated */ + strncpy(stat->name, mod->name, sizeof(stat->name)); + stat->refs = mod->refs; + stat->id = mod->id; + stat->data = mod->data; +} +#endif + +static void +module2module_stat(module_t mod, struct module_stat *stat) +{ + stat->version = sizeof(*stat); + /* Not necessarily NUL-terminated */ + strncpy(stat->name, mod->name, sizeof(stat->name)); + stat->refs = mod->refs; + stat->id = mod->id; + stat->data = mod->data; +} + int sys_modstat(struct thread *td, struct modstat_args *uap) { @@ -383,76 +419,68 @@ int kern_modstat(struct thread *td, int modid, struct module_stat *stat) { module_t mod; - modspecific_t data; int error = 0; - int id, namelen, refs, version; - struct module_stat_v2 *stat_v2; - char *name, *user_namep; - bool is_v1v2; + int version; + void *statbuf; + /* Look up first to preserve historic error priority */ MOD_SLOCK; mod = module_lookupbyid(modid); - if (mod == NULL) { - error = ENOENT; - goto out; - } - id = mod->id; - refs = mod->refs; - name = mod->name; - data = mod->data; + MOD_SUNLOCK; + if (mod == NULL) + return (ENOENT); /* * Check the version of the user's structure. */ if ((error = copyin(&stat->version, &version, sizeof(version))) != 0) - goto out; - is_v1v2 = (version == sizeof(struct module_stat_v1) || - version == sizeof(struct module_stat_v2)); - if (!is_v1v2 && version != sizeof(struct module_stat)) { - error = EINVAL; - goto out; + return (error); + + switch (version) { + case sizeof(struct module_stat): +#ifdef COMPAT_FREEBSD13 + case sizeof(struct module_stat_v2): +#endif +#ifdef COMPAT_43 /* XXX - COMPAT_FREEBSD2 */ + case sizeof(struct module_stat_v1): +#endif + statbuf = malloc(version, M_TEMP, M_WAITOK | M_ZERO); + break; + default: + return (EINVAL); } - if (is_v1v2) - user_namep = ((struct module_stat_v1 *)stat)->name; - else - user_namep = stat->name; - namelen = strlen(mod->name) + 1; - if (is_v1v2 && namelen > MAXMODNAMEV1V2) - namelen = MAXMODNAMEV1V2; - else if (namelen > MAXMODNAMEV3) - namelen = MAXMODNAMEV3; - if ((error = copyout(name, user_namep, namelen)) != 0) - goto out; - /* Extending MAXMODNAME gives an offset change for v3. */ - if (is_v1v2) { - stat_v2 = (struct module_stat_v2 *)stat; - if ((error = copyout(&refs, &stat_v2->refs, sizeof(int))) != 0) - goto out; - if ((error = copyout(&id, &stat_v2->id, sizeof(int))) != 0) - goto out; - } else { - if ((error = copyout(&refs, &stat->refs, sizeof(int))) != 0) - goto out; - if ((error = copyout(&id, &stat->id, sizeof(int))) != 0) - goto out; + MOD_SLOCK; + mod = module_lookupbyid(modid); + if (mod == NULL) { + MOD_SUNLOCK; + error = ENOENT; + goto out; } - /* - * >v1 stat includes module data. - */ - if (version == sizeof(struct module_stat_v2)) { - if ((error = copyout(&data, &stat_v2->data, - sizeof(data))) != 0) - goto out; - } else if (version == sizeof(struct module_stat)) { - if ((error = copyout(&data, &stat->data, - sizeof(data))) != 0) - goto out; + switch (version) { + case sizeof(struct module_stat): + module2module_stat(mod, statbuf); + break; +#ifdef COMPAT_FREEBSD13 + case sizeof(struct module_stat_v2): + module2module_stat_v2(mod, statbuf); + break; +#endif +#ifdef COMPAT_43 /* XXX - COMPAT_FREEBSD2 */ + case sizeof(struct module_stat_v1): + module2module_stat_v1(mod, statbuf); + break; +#endif } + MOD_SUNLOCK; + + if ((error = copyout(statbuf, stat, version)) != 0) + goto out; + td->td_retval[0] = 0; out: - MOD_SUNLOCK; + free(statbuf, M_TEMP); return (error); } @@ -498,6 +526,7 @@ typedef union modspecific32 { uint32_t ulongval; } modspecific32_t; +#ifdef COMPAT_FREEBSD13 struct module_stat32_v2 { int version; char name[MAXMODNAMEV1V2]; @@ -506,6 +535,18 @@ struct module_stat32_v2 { modspecific32_t data; }; +static void +module2module_stat32_v2(module_t mod, struct module_stat32_v2 *stat) +{ + stat->version = sizeof(*stat); + /* Not necessarily NUL-terminated */ + strncpy(stat->name, mod->name, sizeof(stat->name)); + stat->refs = mod->refs; + stat->id = mod->id; + stat->data.uintval = mod->data.uintval; +} +#endif + struct module_stat32 { int version; char name[MAXMODNAME]; @@ -514,78 +555,82 @@ struct module_stat32 { modspecific32_t data; }; +static void +module2module_stat32(module_t mod, struct module_stat32 *stat) +{ + stat->version = sizeof(*stat); + /* Not necessarily NUL-terminated */ + strncpy(stat->name, mod->name, sizeof(stat->name)); + stat->refs = mod->refs; + stat->id = mod->id; + stat->data.uintval = mod->data.uintval; +} + int freebsd32_modstat(struct thread *td, struct freebsd32_modstat_args *uap) { module_t mod; - modspecific32_t data32; int error = 0; - int id, namelen, refs, version; + int version; + void *statbuf; struct module_stat32 *stat32; - struct module_stat32_v2 *stat32_v2; - char *name; - bool is_v1v2; + /* Look up first to preserve historic error priority */ MOD_SLOCK; mod = module_lookupbyid(uap->modid); - if (mod == NULL) { - error = ENOENT; - goto out; - } + MOD_SUNLOCK; + if (mod == NULL) + return (ENOENT); - id = mod->id; - refs = mod->refs; - name = mod->name; - _Static_assert(sizeof(data32) == sizeof(data32.uintval), - "bad modspecific32_t size"); - CP(mod->data, data32, uintval); stat32 = uap->stat; - if ((error = copyin(&stat32->version, &version, sizeof(version))) != 0) - goto out; - is_v1v2 = (version == sizeof(struct module_stat_v1) || - version == sizeof(struct module_stat32_v2)); - if (!is_v1v2 && version != sizeof(struct module_stat32)) { - error = EINVAL; - goto out; + return (error); + + switch (version) { + case sizeof(struct module_stat32): +#ifdef COMPAT_FREEBSD13 + case sizeof(struct module_stat32_v2): +#endif +#ifdef COMPAT_43 /* XXX - COMPAT_FREEBSD2 */ + case sizeof(struct module_stat_v1): +#endif + statbuf = malloc(version, M_TEMP, M_WAITOK | M_ZERO); + break; + default: + return (EINVAL); } - namelen = strlen(mod->name) + 1; - if (is_v1v2 && namelen > MAXMODNAMEV1V2) - namelen = MAXMODNAMEV1V2; - else if (namelen > MAXMODNAMEV3) - namelen = MAXMODNAMEV3; - if ((error = copyout(name, &stat32->name[0], namelen)) != 0) - goto out; - /* Extending MAXMODNAME gives an offset change for v3. */ - if (is_v1v2) { - stat32_v2 = (struct module_stat32_v2 *)stat32; - if ((error = copyout(&refs, &stat32_v2->refs, sizeof(int))) != 0) - goto out; - if ((error = copyout(&id, &stat32_v2->id, sizeof(int))) != 0) - goto out; - } else { - if ((error = copyout(&refs, &stat32->refs, sizeof(int))) != 0) - goto out; - if ((error = copyout(&id, &stat32->id, sizeof(int))) != 0) - goto out; + MOD_SLOCK; + mod = module_lookupbyid(uap->modid); + if (mod == NULL) { + MOD_SUNLOCK; + error = ENOENT; + goto out; } - /* - * >v1 stat includes module data. - */ - if (version == sizeof(struct module_stat32_v2)) { - if ((error = copyout(&data32, &stat32_v2->data, - sizeof(data32))) != 0) - goto out; - } else if (version == sizeof(struct module_stat32)) { - if ((error = copyout(&data32, &stat32->data, - sizeof(data32))) != 0) - goto out; + switch (version) { + case sizeof(struct module_stat32): + module2module_stat32(mod, statbuf); + break; +#ifdef COMPAT_FREEBSD13 + case sizeof(struct module_stat32_v2): + module2module_stat32_v2(mod, statbuf); + break; +#endif +#ifdef COMPAT_43 /* XXX - COMPAT_FREEBSD2 */ + case sizeof(struct module_stat_v1): + module2module_stat_v1(mod, statbuf); + break; +#endif } + MOD_SUNLOCK; + + if ((error = copyout(statbuf, stat32, version)) != 0) + goto out; + td->td_retval[0] = 0; out: - MOD_SUNLOCK; + free(statbuf, M_TEMP); return (error); } #endif