From nobody Mon Nov 16 15:17:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jSs1d6k99z70rLZ for ; Mon, 16 Nov 2026 15:17:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jSs1d3pGhz4RK8 for ; Mon, 16 Nov 2026 15:17:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794842277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W3yj62enkV0egrKVIqrgiGFebCvwtvRNCVa6AZBIVn4=; b=dYXsL95T3Isj201EfINIVvAKJCcplwZ+c+YfRG5wdMbaWXCypCu/7PQjG69LRjRpdjDsyv FYA09Sv7OwIz//WrRJAltoA8qRIYfOMXbLUbofIBmJ8oHIOms0bKkC4QR5sEFUx1T2QlqA JKKRhP2uxWePfuYPHbHieFoHgBF/uvf/6m+JZrrOwhJGPpjTFzn93R39SDF+0TajQigw/8 MbBb7eXKO5FfvU5m0XXvMhPukTrf3Kg+DfL3UCWJvvB+Jo1KPq2525jPr5wTzNqKt1xQiB /vO+LV5gEjbRRI/kBPmqH6NfQSfWnGip/2D1rWmD+ayHJsethuyUqFgSSyr9HQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794842277; b=F9wov+0AHcbJ5nTmAJPyWh7P+c85/p+ucxi9+GZRbXwrb7nTu75anCDgny3XsaPDQCGuJL w2Juo8oOIiZOdDeTRTzFExjTqzQy5hyqVnbobia12A9jrS5FkPg8o5g/CfnexRAW9uRUl7 y/oakMkMf2/oNT6SgoMcfjYPwZarvPBFDf09PPXrsC1HWHUP1VnFTc+BxN10vZAyylFk3z 7mgdf6q9gmWch0GDv4VD4vwvQeglkzbwlNR0n40Bqc8E1QNfbNJ4XG66zDBe3Foxz/a9s2 P+A/NPTYYMCUaHZ4oiY+T10x1+Z6+pOItqAVZenLFokQlpctMKog3bN6e5vaXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794842277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W3yj62enkV0egrKVIqrgiGFebCvwtvRNCVa6AZBIVn4=; b=PdBXTXOBK6l4unzY5mSdv8wOA5VSwaVbjStp/RFN44UEBWRIXOCCqAG6BvF5KLQ8Hrgr+b x8IO7PYi3xvjlZz7zOw0JIhgILG7HhwY+VesVp1JwN/aF2gzvVT1TmU/o7dSQVXvdaVN5M BG1C29D++LoBDNJHouG38DYl/KNUl9bU5UYJ40wJet19u3VvNheqpx+YxzQ86xREMFg3ad PkiG1jt9StyrKR41ttMt7Dfvn5UCXticv4e2zP2Hoa1czLJ86WB6VoQzf6PLNzUuQ4UFof Q3yTRyLDeLdgEINCHaDNjA21abADk/vaEX/G2lwsauh7oYytcYVhn2oIU1IT3A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jSs1d3Q5Szym0 for ; Mon, 16 Nov 2026 15:17:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4416 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 16 Nov 2026 15:17:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Osvaldo Janeri Filho From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 6d18a7077def - stable/14 - su, login: fix heap over-read in environment export filter List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 6d18a7077defe108f8e345fa7c8017b5efa8112f Auto-Submitted: auto-generated Date: Mon, 16 Nov 2026 15:17:57 +0000 Message-Id: <6afb1ea5.4416.42984c2a@gitrepo.freebsd.org> The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=6d18a7077defe108f8e345fa7c8017b5efa8112f commit 6d18a7077defe108f8e345fa7c8017b5efa8112f Author: Osvaldo Janeri Filho AuthorDate: 2026-11-12 14:23:56 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-11-16 14:52:04 +0000 su, login: fix heap over-read in environment export filter ok_to_export() (su.c) and export() (login.c) read s[n] before strncmp(s, *pp, n) confirms s is at least n bytes long, where n is the length of the blocked variable name. A PAM environment entry shorter than that name over-reads past its heap allocation. Check strncmp() first; it stops at s's NUL terminator and never reads past the boundary that guarded the s[n] access. MFC after: 1 week Sponsored by: Advanced Micro Devices, Inc. Signed-off-by: Osvaldo Janeri Filho Reviewed by: des, markj Differential Revision: https://reviews.freebsd.org/D61420 (cherry picked from commit e1b5e1f9ddac43ed669a44cfdbba1b394d144c6b) --- usr.bin/login/login.c | 2 +- usr.bin/su/su.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.bin/login/login.c b/usr.bin/login/login.c index d0d4bb4a2394..cc62e50e4e0c 100644 --- a/usr.bin/login/login.c +++ b/usr.bin/login/login.c @@ -803,7 +803,7 @@ export(const char *s) return (0); for (pp = noexport; *pp != NULL; pp++) { n = strlen(*pp); - if (s[n] == '=' && strncmp(s, *pp, n) == 0) + if (strncmp(s, *pp, n) == 0 && s[n] == '=') return (0); } *p = '\0'; diff --git a/usr.bin/su/su.c b/usr.bin/su/su.c index 3d97ab8deb30..1ce0e9b8fba9 100644 --- a/usr.bin/su/su.c +++ b/usr.bin/su/su.c @@ -599,7 +599,7 @@ ok_to_export(const char *s) return 0; for (pp = noexport; *pp != NULL; pp++) { n = strlen(*pp); - if (s[n] == '=' && strncmp(s, *pp, n) == 0) + if (strncmp(s, *pp, n) == 0 && s[n] == '=') return 0; } return 1;