From nobody Mon Nov 16 10:45:50 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jSkzf484zz7032X for ; Mon, 16 Nov 2026 10:45:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jSkzf3fGHz4kn2 for ; Mon, 16 Nov 2026 10:45:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794825950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LAswuhgIWCWG+RkaMW3pVW7Tj5jvhKPD/W2syRA/z/A=; b=yklUCSnrFlfubwJgG2UcJHrw6UwAFBCDFTapLzx0w5QiavMeUf9sA3Mh1l9e4m6ntSn/Ly Vj1IwIKcJhoafFEomNOoZm6r2NxEBw/PTS+fcRsW7qAQM6BFCWvoEu4UITaBwnziu54b1d RngDOUvA5NhPG5dqhutkYkBDuvbsb4SJpN5ivjcUbziSVFh1wP30vLf0oQ1v1WUoskWPps 6AzHYgFya/MMtwnkw8x+psZkb2aN69Wb/+YV7kMTrtzXpOIk2E/THB0gmTbf2rFsNL00+M 8qFcWxV4ycyCkfLprvXoEGmlc9yxlQNNnsCxTzvRIbI6jo9zvJN01I230D9ZYw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794825950; b=CqyOF9lJP9Cj2qtU9dUfLbEuXeoJ4H/Zm8tFaxADMuT3cUpaoRk6T7aVuFRtbLc4cEp4Pk WGFonHSJT4vzSGr1SwxiFX+jvDSL0SJzV+jFT7wMEC7abWNZ1ETNiaqKL/rWOhWVYqPhP9 1a64MmUrBBzLMcDaoLctkVl1bBtvgFhwrehJzVoIy5YtrbyVWYr7X6/LiGdDbIcF1HLHn8 NTXlFyo29g6OasI915WhevNObmsVhui799NpOnuTEQD+xfIIUvgef4IIzmXRCoAw/53ZrG KxEam8NNxv6zH22kubfiuc0sou/Ik49wo5lJuZmTSbQIWmybcKR/CJoqOlbiyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794825950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LAswuhgIWCWG+RkaMW3pVW7Tj5jvhKPD/W2syRA/z/A=; b=suMpHwp7nZFkTsBfSNcQSyD9Gl44kHbefVcDDV2I/G08BpF+MEtDZ/Ww6yfopyPpnvatxU n+roHP6criZNP5UaYjddxjsc0Xt4bLIh98aqqxXbiT4/x664GCT8l1ZFO8Wpoj9E9XEw0x 18X7qCSJ3hhtS7EAIyugka234zjKSEr9iSFsMULzfhF2mSWdPqrwNPsEt5Lyi02FkL5uIi Lfa1hJHF399R1TDXQtprlVNOaiiFMmhalBpRNgUC8rw1/DemqAQd7xG4j2t2eHd5aWp5PG kiehdxTBR7UUCWnrG0Wmm4UQqN9OzJ2t9oQVczJeAgaPJB5HL5O2cTdnEF4JEw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jSkzf2nyszrFP for ; Mon, 16 Nov 2026 10:45:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id e860 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 16 Nov 2026 10:45:50 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Brooks Davis Subject: git: 0967b36fe783 - stable/15 - extattr_list*: avoid panic with absurd buffer lengths List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brooks X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 0967b36fe7837e4b1727ec1230ef1ee28ea6db8c Auto-Submitted: auto-generated Date: Mon, 16 Nov 2026 10:45:50 +0000 Message-Id: <6afadede.e860.3a06e04@gitrepo.freebsd.org> The branch stable/15 has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=0967b36fe7837e4b1727ec1230ef1ee28ea6db8c commit 0967b36fe7837e4b1727ec1230ef1ee28ea6db8c Author: Brooks Davis AuthorDate: 2026-11-13 10:06:52 +0000 Commit: Brooks Davis CommitDate: 2026-11-16 10:45:15 +0000 extattr_list*: avoid panic with absurd buffer lengths Apply a layered defence: - Reject nbytes > IOSIZE_MAX in user_extattr_list_fd and user_extattr_list_path. - In extattr_list_vp require auiop->uio_resid to be non-negative. Effort: CHERI upstreaming Reviewed by: markj Reported by: llm-postcr MFC after: 3 days Sponsored by: Innovate UK Fixes: 6453d4240f6b ("vfs: Export exattr methods to reuse by Linuxulator") Differential Revision: https://reviews.freebsd.org/D61461 (cherry picked from commit 118067f51c111390dbc54760d781cd14a10c499e) --- sys/kern/vfs_extattr.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sys/kern/vfs_extattr.c b/sys/kern/vfs_extattr.c index 1fe7494f3998..1614b15db553 100644 --- a/sys/kern/vfs_extattr.c +++ b/sys/kern/vfs_extattr.c @@ -693,7 +693,7 @@ extattr_list_vp(struct vnode *vp, int attrnamespace, struct uio *auiop, sizep = NULL; cnt = 0; if (auiop != NULL) { - if (auiop->uio_resid > IOSIZE_MAX) + if (auiop->uio_resid < 0 || auiop->uio_resid > IOSIZE_MAX) return (EINVAL); cnt = auiop->uio_resid; } else @@ -735,6 +735,9 @@ sys_extattr_list_fd(struct thread *td, struct extattr_list_fd_args *uap) struct uio auio, *auiop; struct iovec aiov; + if (uap->nbytes > IOSIZE_MAX) + return (EINVAL); + if (uap->data != NULL) { aiov.iov_base = uap->data; aiov.iov_len = uap->nbytes; @@ -813,6 +816,9 @@ user_extattr_list_path(struct thread *td, const char *path, int attrnamespace, struct uio auio, *auiop; struct iovec aiov; + if (nbytes > IOSIZE_MAX) + return (EINVAL); + if (data != NULL) { aiov.iov_base = data; aiov.iov_len = nbytes;