From nobody Mon Nov 16 08:50:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jShR53xkBz71Xmv; Mon, 16 Nov 2026 08:50:57 +0000 (UTC) (envelope-from gordon@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jShR53KtWz4Pw9; Mon, 16 Nov 2026 08:50:57 +0000 (UTC) (envelope-from gordon@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794819057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wgQehL82UWm3Jrs8bdqALQEWaiD0iGNnjeGfcpVKUbo=; b=LTrqlwMiD4t5+OtYQHkqmUpxONQSTUFe+7XT7/nlXA/SY8x0e2jZW7DsQbzBivjR0/PYnd BswO2l+AlpBlmL36xPyiB2sWO11/Vdd90bgngbbAeqL4eYybaVQQawIqwhzBGt0gMvqWj5 giOf6qtfwfABgZqonSMcpeVZDvm/IBUVSlkjpMc0Hki4JjGBcKnK2nR25N8AbHNLj9cEZr EZ4x7Hc0tsg19lskT01ZMpBedLfoXK5plOaAEJlkUN7tGeqJE5C5j2a+FG31HjSnCHrrqu bJlZ83covwF1LdfcXaSq/ecBshr4NvkeEtGpcCn0KHZRIq5u9KdPwenEjf8fNA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794819057; b=rOBsdK9sQ5D7U0qnHdNOuZFS2srYDHGsOS12zyW6dAlRifWGmN9DK3sVB54vsqSw1XmS90 URIatj18t+XxUDzhEnEPUm5lNFh1gAOt2flvxKq6VJMkAVhh/cElxrh1Ar+ivHlWBg4zW/ OjkOOKJtSpLLmwchEpe8Bo/p+zaUggdGdy5Ze6S2wfUonPxyQeSlws75R+J2CTUYxACLMs HpocFRBByJYqTdcabTqJKwZqDFpUVHTYYJAJsJTFZEueITQOQva1xCejm95ZSVDbKzi70Y 1dgMv/m8U+iWo3SYQnSxJHBsnhf7jxKShxbsvB+C5KpmzMUrLAP0H4uRr8F4gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794819057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wgQehL82UWm3Jrs8bdqALQEWaiD0iGNnjeGfcpVKUbo=; b=PukvZLM+2jPEdMn9xhkz318zENHrv2z+n8Wvo0P+QgK8W37/Xd590hl6vwUWEvyuE0ivrh UiuYqKQwgYPkS93wiGrm+Si2iSxTtvzgqFoAxUrnUzEJ3KRq2Hk3Y6mvoNN8AdbSLv9ZOr XormFYcqqqYyYA1ZHFLEWu29ggwT5jzXGteUT0qLzsTyTFE0nfYV0yH4heZN6ALK9hjPIL mkVa+P5oKfYwJk1hEZRAGUNsyeuNhYHGB6z1Jefc+wSB+ABfqyOsKcMI3syj8NHg4ItMeJ KmN7/ag/qtErhsbixVXr4ygaqQu5DeGhiATTz5rK+uXNkoeDtt62utqrQEcGMQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from smtpclient.apple (unknown [IPv6:2603:8003:6d00:7e00:b97a:c278:51f4:8653]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gordon/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4jShR524cgzhZ3; Mon, 16 Nov 2026 08:50:57 +0000 (UTC) (envelope-from gordon@freebsd.org) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Gordon Tetlow List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (1.0) Subject: Re: git: f0798d084392 - stable/15 - openssl: build legacy provider as upstream does Date: Mon, 16 Nov 2026 00:50:42 -0800 Message-Id: <329BB996-B7C1-4833-ACDD-4632F01D6D15@freebsd.org> References: <202611160737.6AG7b4jU055051@mp80.oldach.net> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org In-Reply-To: <202611160737.6AG7b4jU055051@mp80.oldach.net> To: freebsd@oldach.net X-Mailer: iPhone Mail (24B156) Odd. I did a buildworld against both amd64 and aarch64 without any issue. It= also ran in main without issue. Can you see if a clean build reproduces it?= Gordon > On Nov 15, 2026, at 23:37, freebsd@oldach.net wrote: >=20 > =EF=BB=BFGordon Tetlow wrote on Mon, 16 Nov 2026 07:33:19 +0100 (CET): >> The branch stable/15 has been updated by gordon: >>=20 >> URL: https://cgit.FreeBSD.org/src/commit/?id=3Df0798d0843924389f4da582697= c31c3af6aaa802 >>=20 >> commit f0798d0843924389f4da582697c31c3af6aaa802 >> Author: Gordon Tetlow >> AuthorDate: 2026-11-06 18:42:45 +0000 >> Commit: Gordon Tetlow >> CommitDate: 2026-11-16 06:22:19 +0000 >>=20 >> openssl: build legacy provider as upstream does >>=20 >> - Build with libcrypto's compile flags: modules/Makefile.inc now >> includes libcrypto's Makefile.inc, which brings in Makefile.common >> (NDEBUG, the asm dispatch defines, OPENSSL_PIC, the directory >> defines). Before this change, assertions were enabled in legacy.so.= >> - Use upstream's per-architecture source list: the provider's own CPU >> capability code (cpuid asm and armcap.c/ppccap.c, or mem_clr.c >> without asm), and the MD5, RC4 and DES asm where upstream uses it. >> The provider no longer uses libcrypto's exported RC4, SHA1 and >> CRYPTO_*128 functions. >> - Drop the objects that upstream's linker leaves out of legacy.so >> (fcrypt_b.c, md5_one.c, md5_sha1.c, provider_err.c and >> ciphercommon_{ccm,gcm}*.c / ciphercommon_hw.c). Without them, >> params_idx.c is not needed either. >> - Add a version script, a copy of upstream's providers/legacy.ld, so >> that only OSSL_provider_init is exported. Around 209 symbols were >> exported before. >>=20 >> Reviewed by: ngie >> Event: FreeBSD Vendor Summit 2026 >> Differential Revision: https://reviews.freebsd.org/D60398 >>=20 >> (cherry picked from commit 46453f0abb85c1c93dce7139950c6343a6cf04df) >> --- >> secure/lib/libcrypto/modules/Makefile.inc | 12 ++--- >> secure/lib/libcrypto/modules/legacy/Makefile | 67 ++++++++++++++++++--= ----- >> secure/lib/libcrypto/modules/legacy/Version.map | 5 ++ >> 3 files changed, 57 insertions(+), 27 deletions(-) >=20 > This seems to break buildworld (seen on both amd64 and aarch64): >=20 > Building shared library legacy.so > cc -march=3Di686 -mmmx -msse -msse2 -m32 -target x86_64-unknown-freebsd15.= 2 -DCOMPAT_LIBCOMPAT=3D\"32\" -DCOMPAT_libcompat=3D\"32\" -DCOMPAT_LIB32 --s= ysroot=3D/usr/obj/usr/src/amd64.amd64/tmp -B/usr/obj/usr/src/amd64.amd64/tmp= /usr/bin -B/usr/obj/usr/src/amd64.amd64/tmp/usr/lib32 -Wl,-zrelro -Wl,--ver= sion-script=3D/usr/src/secure/lib/libcrypto/modules/legacy/Version.map -Wl,-= -no-undefined-version -fstack-protector-strong -shared -Wl,-x -Wl,--fatal= -warnings -Wl,--warn-shared-textrel -o legacy.so -Wl,-soname,legacy.so lega= cyprov.pico prov_running.pico ciphercommon.pico ciphercommon_block.pico ciph= er_desx.pico cipher_desx_hw.pico cipher_des.pico cipher_des_hw.pico cipher_t= des_common.pico cipher_blowfish.pico cipher_blowfish_hw.pico cipher_cast5.pi= co cipher_cast5_hw.pico cipher_rc2.pico cipher_rc2_hw.pico cipher_rc4.pico c= ipher_rc4_hw.pico cipher_rc4_hmac_md5.pico cipher_rc4_hmac_md5_hw.pico ciphe= r_seed.pico cipher_seed_hw.pico cpuid.pico ctype.pico x86cpuid.pico crypt586= .pico des-586.pico md5_dgst.pico md5-586.pico rc4-586.pico digestcommon.pico= md4_prov.pico wp_prov.pico ripemd_prov.pico pbkdf1.pico pvkkdf.pico provide= r_ctx.pico provider_util.pico tls_pad.pico -lcrypto > ld.lld: error: duplicate symbol: OPENSSL_rdtsc >>>> defined at cpuid.c >>>> cpuid.pico:(OPENSSL_rdtsc) >>>> defined at x86cpuid.pico:(.text+0x1e0) >=20 > ld.lld: error: duplicate symbol: CRYPTO_memcmp >>>> defined at cpuid.c >>>> cpuid.pico:(CRYPTO_memcmp) >>>> defined at x86cpuid.pico:(.text+0x340) >=20 > ld.lld: error: duplicate symbol: OPENSSL_instrument_bus >>>> defined at cpuid.c >>>> cpuid.pico:(OPENSSL_instrument_bus) >>>> defined at x86cpuid.pico:(.text+0x370) >=20 > ld.lld: error: duplicate symbol: OPENSSL_instrument_bus2 >>>> defined at cpuid.c >>>> cpuid.pico:(OPENSSL_instrument_bus2) >>>> defined at x86cpuid.pico:(.text+0x3e0) > cc: error: linker command failed with exit code 1 (use -v to see invocatio= n) >=20 >=20