From nobody Sun Nov 15 21:21:58 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jSP871kNjz71Bhs for ; Sun, 15 Nov 2026 21:21:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jSP870159z4D2h for ; Sun, 15 Nov 2026 21:21:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794777719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jjH4T+IDUy8WeX/rHaaVwX+oJjiOvQAjdvfaZtLsAeo=; b=XDP5KM2DKoIiv7Ofuyu5WEp7cbmDzoFexyFrkCKt4vNPosLox5BWwnLPloA5CBkAAFLof8 bzzOcsN5jWCz5vLIeUXB+RaOSjT9fSCbXg3xhOFZUXA+tIHia+xvKF8AYVMxk90r8ccHDN JTo695dkJm7Ss9Bx8NZXMxwHLRO9dR1Kt9+ZS4mG4X4J091fMUlMCezvbLBS4hcCR2oJSa MBSVqbSZWt5p37NC2e7XuhL/+9dAxT35pDAozMUJ8EHZtDE4EYTyYx5joyOSjgKIgMD1ip avqicMY3a56NdLLT/hDIHlQz8kg/DXOBy22cxOlZA9My/oijDEOcjbTXUDx4Zw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794777719; b=PhEr94A69Iteg2os3LrSJ2WtoWEv8x3kDN0HSkPn82m6QYKJnZEXV2/3RFDtL2YRoC6m22 jw/OebEyTwyEcVa3POweJxCj6SannTnn3eyjlISOa1Mh3kd6RxU/xpd+7CYCK7VPYuQw/Z YbD/QBLUswrg+JO3RYogCsC7FVSA0qwpVJorf+p+jCPuoGTtEDJ7A+O0s2m2iB+2fwb2XB VwJZ8LNP58+OjHHGAbi0fuGs4/3gug6S1vsZBYjpJ87L/lyi/xWgMdVWBDMurNFS0RET7I dw964LBDgV842QN1aO9L8senrc7eOxE3LGGUzNfmK9iw54GegdWO27sErF2D6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794777719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jjH4T+IDUy8WeX/rHaaVwX+oJjiOvQAjdvfaZtLsAeo=; b=jtCziEvcfQ8Zib3Yj6AfN7Up2TugkhsxrJcXadckG2eNuMHnz5WXBsSD7UeAxZ2pqRq9/9 QGaCF0PXkDI0ei6XyH3fV+msw6Zwm5Cd8CxXPAy7CkEJa4ZaQnMBAGut9XYkNlj9aUpbjw ZPW/+sWczoFSj3IYTCMCXgf/gHfYik2KsTipRyYS1AK94PcXGAE8pKlDwWE3Glg2s+TioD MgWMa90ZTcVUxMvZszjFW4uesxKANH8grNKDVPMB3AP8IBWg5FIfp1jicT+82AsNTZwqzZ WjYpBdOuhBe0HD8pqtcMK+ici6lbPFsIMt6M79obzn5Nt55gbywckWWPMrrGmQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jSP866WBHzP6t for ; Sun, 15 Nov 2026 21:21:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 248e4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 15 Nov 2026 21:21:58 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Abdelkader Boudih Subject: git: 93451769fc6e - main - asmc: make asmc_sysctl_add_system() void List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: seuros X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 93451769fc6eae77ed3cfb0f6f508ca82e9eab96 Auto-Submitted: auto-generated Date: Sun, 15 Nov 2026 21:21:58 +0000 Message-Id: <6afa2276.248e4.35666dc0@gitrepo.freebsd.org> The branch main has been updated by seuros: URL: https://cgit.FreeBSD.org/src/commit/?id=93451769fc6eae77ed3cfb0f6f508ca82e9eab96 commit 93451769fc6eae77ed3cfb0f6f508ca82e9eab96 Author: Abdelkader Boudih AuthorDate: 2026-11-15 21:12:57 +0000 Commit: Abdelkader Boudih CommitDate: 2026-11-15 21:12:57 +0000 asmc: make asmc_sysctl_add_system() void Its only caller already discarded the return value with (void). Match the other sysctl subtree builders. Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D61537 --- sys/dev/asmc/asmc.c | 2 +- sys/dev/asmc/asmc_sysctl.c | 6 ++---- sys/dev/asmc/asmc_sysctl.h | 6 +++--- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/sys/dev/asmc/asmc.c b/sys/dev/asmc/asmc.c index 03d5bb920bb0..edff84428607 100644 --- a/sys/dev/asmc/asmc.c +++ b/sys/dev/asmc/asmc.c @@ -281,7 +281,7 @@ asmc_attach(device_t dev) asmc_shutdown, dev, SHUTDOWN_PRI_FIRST); /* System state / board identity subtree. */ - (void)asmc_sysctl_add_system(dev, sysctlctx); + asmc_sysctl_add_system(dev, sysctlctx); if (!sc->sc_has_sms) goto nosms; diff --git a/sys/dev/asmc/asmc_sysctl.c b/sys/dev/asmc/asmc_sysctl.c index ff562eb76894..8a5df89f5d9b 100644 --- a/sys/dev/asmc/asmc_sysctl.c +++ b/sys/dev/asmc/asmc_sysctl.c @@ -542,7 +542,7 @@ static const struct { "IU", CTLTYPE_UINT | CTLFLAG_RD, 0, asmc_rgen_sysctl, 0, 0 }, }; -int +void asmc_sysctl_add_system(device_t dev, struct sysctl_ctx_list *ctx) { struct sysctl_oid *sys_tree; @@ -553,7 +553,7 @@ asmc_sysctl_add_system(device_t dev, struct sysctl_ctx_list *ctx) "System state and board identity"); if (sys_tree == NULL) { device_printf(dev, "failed to create system sysctl node\n"); - return (ENXIO); + return; } for (unsigned int k = 0; k < nitems(asmc_system_sysctls); k++) { @@ -576,8 +576,6 @@ asmc_sysctl_add_system(device_t dev, struct sysctl_ctx_list *ctx) asmc_system_sysctls[k].fmt, asmc_system_sysctls[k].desc, NULL); } - - return (0); } /* Platform toggles under dev.asmc.n, each present only if its key reads. */ diff --git a/sys/dev/asmc/asmc_sysctl.h b/sys/dev/asmc/asmc_sysctl.h index 5fd7bd93eac4..4690d5801fc4 100644 --- a/sys/dev/asmc/asmc_sysctl.h +++ b/sys/dev/asmc/asmc_sysctl.h @@ -9,14 +9,14 @@ /* * Sysctl subtree builders, one per dev.asmc.N node. asmc_attach() calls these - * in registration order; only add_system can fail, and only because the key - * count it reads is what tells the rest of the driver the SMC is there. + * in registration order; a node that fails to create just leaves that subtree + * missing, so none of these are fatal to attach. */ void asmc_sysctl_add_fan(device_t dev, struct sysctl_ctx_list *ctx); void asmc_sysctl_add_temp(device_t dev, struct sysctl_ctx_list *ctx); void asmc_sysctl_add_light(device_t dev, struct sysctl_ctx_list *ctx); void asmc_sysctl_add_sms(device_t dev, struct sysctl_ctx_list *ctx); -int asmc_sysctl_add_system(device_t dev, struct sysctl_ctx_list *ctx); +void asmc_sysctl_add_system(device_t dev, struct sysctl_ctx_list *ctx); void asmc_sysctl_add_platform(device_t dev, struct sysctl_ctx_list *ctx); /* Registered by the core's sensor range scan, one OID per detected key. */