From nobody Sun Nov 15 21:21:52 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jSP805vxsz71Bdn for ; Sun, 15 Nov 2026 21:21:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jSP804pY9z4Cjl for ; Sun, 15 Nov 2026 21:21:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794777712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/11CsaLsN6hZ6xuRcQ6+NKRmkALESecaM7qdHuW/V7s=; b=r2yyWw06AFt943LCdrEk2mIyPP55XKfD+sO//N5MtTtOi2Evv4i21xOJy2O0krbGWxfJGt eXhaqBExpOxTG/oudzso35GTvZ0+mG1avRX02RyQAyL8r7oatNpPTqJwiKtVqkyjg5PVkr TM3rHptGv0BBFyapBqcMxbx6XOtgqd4v5b7cHinfsv8EdjxjVYKJ0DXpp3//rOr//LV0AK arJVgfo7g8qhkoIoICqPsdkFohLKFZwpkDINaMC7/2j5LuVoxCbaNqBwC9d7zKCFY+3DSz mLjci0Rrm4PGQ9HGHkjWiMdGdTO9ioxn73ocWl33nDo64UddImMGTJHhqjAysQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794777712; b=hmpUk1ahkxZGo4XeXD/rvfG0E9IoiRbs8wzxPYi5JWT19kXd1xkEDv59xm9iuYkrqjvyv4 vVGJ0ySJ6+swEf+ixGoAutA40JLcO5y9JSLgxt3XJZtCJpNUaJ+9bwEuA+Ge8SdNjcBm1R xxyiCHlsqLJQc+oHgx9X10sU2YX1d4TQTjp8pf5NQPR/Ip+j5w/JoWuyagpJ/StU1CkAog yYEta/yo1fdW2lXam25opgmmnfK8EVOCvoKoKjRbRISoCo5+i/7SKjlQ19KMobcQel75SI y+3qhRUiqbPXQLgGyUAzNVBO2PjsetAuJK28vDgL2bIX+UeIWsseRfiuGQHFBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794777712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/11CsaLsN6hZ6xuRcQ6+NKRmkALESecaM7qdHuW/V7s=; b=G8oWqy0eNjzpiVOSloROnK4kpeNy7kCgjrbrXhzAKIi96AKlu9nRuGSm2bRwX6gWNzKGaF SujG2L+xbwXF8V0Gv6VilFLeeqWRgOuppRzBka9AWoVu11DYCPweL0dPti3NdufM9HHQne XNheOQRDOfSlmad+o7xiQZCpzpfsUAC84csySf08bSG3ZPF04OzvPzsr852nkpgv3SSDPP 1uWouRAcOdyiiRpU7ROyRtIcwi/mPvBP+/pXUa1EuaEpTkMCeecgAknjj4+UShyyC4rtJg NBtAX1uVIGeyU7GBcdWRZiz5+5xgRL588rtDLaKKSANisQ7LvaeRXi1rtdt/Zw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jSP804RyGzNgm for ; Sun, 15 Nov 2026 21:21:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24f8a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 15 Nov 2026 21:21:52 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Abdelkader Boudih Subject: git: e029e26ca087 - main - asmc: register the fan id sysctl with a string format List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: seuros X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e029e26ca08744a4d50c29b3f7226bf0379be603 Auto-Submitted: auto-generated Date: Sun, 15 Nov 2026 21:21:52 +0000 Message-Id: <6afa2270.24f8a.487c9c44@gitrepo.freebsd.org> The branch main has been updated by seuros: URL: https://cgit.FreeBSD.org/src/commit/?id=e029e26ca08744a4d50c29b3f7226bf0379be603 commit e029e26ca08744a4d50c29b3f7226bf0379be603 Author: Abdelkader Boudih AuthorDate: 2026-11-15 21:12:47 +0000 Commit: Abdelkader Boudih CommitDate: 2026-11-15 21:12:47 +0000 asmc: register the fan id sysctl with a string format Every fan sysctl was registered with a hardcoded "I" format, but id is CTLTYPE_STRING. Carry the format in the table instead. MFC after: 3 days Reviewed by: ngie Differential Revision: https://reviews.freebsd.org/D61484 --- sys/dev/asmc/asmc_sysctl.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/sys/dev/asmc/asmc_sysctl.c b/sys/dev/asmc/asmc_sysctl.c index d832e717c83e..058280bd3fc7 100644 --- a/sys/dev/asmc/asmc_sysctl.c +++ b/sys/dev/asmc/asmc_sysctl.c @@ -366,24 +366,27 @@ static const struct { const char *name; const char *desc; int ctlflags; + const char *fmt; int (*handler)(SYSCTL_HANDLER_ARGS); int which; bool needs_safespeed; } asmc_fan_sysctls[] = { - { "id", "Fan ID", CTLTYPE_STRING | CTLFLAG_RD, + { "id", "Fan ID", CTLTYPE_STRING | CTLFLAG_RD, "A", asmc_mb_sysctl_fanid, 0, false }, - { "speed", "Fan speed in RPM", CTLTYPE_INT | CTLFLAG_RD, + { "speed", "Fan speed in RPM", CTLTYPE_INT | CTLFLAG_RD, "I", asmc_mb_sysctl_fanspeed, ASMC_FANSPEED_CUR, false }, - { "safespeed", "Fan safe speed in RPM", CTLTYPE_INT | CTLFLAG_RD, + { "safespeed", "Fan safe speed in RPM", CTLTYPE_INT | CTLFLAG_RD, "I", asmc_mb_sysctl_fanspeed, ASMC_FANSPEED_SAFE, true }, - { "minspeed", "Fan minimum speed in RPM", CTLTYPE_INT | CTLFLAG_RW, + { "minspeed", "Fan minimum speed in RPM", CTLTYPE_INT | CTLFLAG_RW, "I", asmc_mb_sysctl_fanspeed, ASMC_FANSPEED_MIN, false }, - { "maxspeed", "Fan maximum speed in RPM", CTLTYPE_INT | CTLFLAG_RW, + { "maxspeed", "Fan maximum speed in RPM", CTLTYPE_INT | CTLFLAG_RW, "I", asmc_mb_sysctl_fanspeed, ASMC_FANSPEED_MAX, false }, - { "targetspeed", "Fan target speed in RPM", CTLTYPE_INT | CTLFLAG_RW, + { "targetspeed", "Fan target speed in RPM", + CTLTYPE_INT | CTLFLAG_RW, "I", asmc_mb_sysctl_fanspeed, ASMC_FANSPEED_TARGET, false }, { "manual", "Fan manual mode (0=auto, 1=manual)", - CTLTYPE_INT | CTLFLAG_RW, asmc_mb_sysctl_fanmanual, 0, false }, + CTLTYPE_INT | CTLFLAG_RW, "I", + asmc_mb_sysctl_fanmanual, 0, false }, }; void @@ -416,7 +419,8 @@ asmc_sysctl_add_fan(device_t dev, struct sysctl_ctx_list *ctx) OID_AUTO, asmc_fan_sysctls[k].name, asmc_fan_sysctls[k].ctlflags | CTLFLAG_MPSAFE, dev, ASMC_FAN_ARG2(asmc_fan_sysctls[k].which, j), - asmc_fan_sysctls[k].handler, "I", + asmc_fan_sysctls[k].handler, + asmc_fan_sysctls[k].fmt, asmc_fan_sysctls[k].desc, NULL); } }