From nobody Sun Nov 15 21:21:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jSP7z6KMmz71BSh for ; Sun, 15 Nov 2026 21:21:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jSP7z4NC9z4CWR for ; Sun, 15 Nov 2026 21:21:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794777711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yEz5KGXTFkJWhTAO2NbDaPcJN5xX25vwZCYuFaMI5qk=; b=FYq7XQA7l1Fv02xsMNs+zWsyBPwF+4HJ5VYMq9RJhiAd4M+Qfcw7c6gsRqgdV7pNazg8Sr /P9mEiFxHikTLw2HjKbetNLQa8Rgqh4PM1K+h+SuYoXzIBArA7kMBHL/IJ0zIrgMkvbqFe gJe0ptOFjWAhi/OHCBHE4jOz5fgbsS4XGfSJpOI2EaUyYeciF52/EIef2RE58W4q5dNsMP 8QV+sXKUKYXN2kiQm+hNH2wg93x5aJDM3uFug7xSzU/d0AZjE+OXw74Iw0hHdkWAzqdFZ+ kthF8blgwgu+QM4Ie10bm6dJ9FJ3FqOkypDv9s1PJ4xiEb3zAuDdbdy0FxVQtQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794777711; b=Asv9PhrPA6fNqQcefkDXhm2k/1b6DYImB4vP+jnWiA3b1IscNWWPijEY2yC3uv31roI17M li8nACxT/uKQD7k8SfNMwL9wyzKKMU8TWtxze5Akp+gPmJCXwY8yXE1uM34nv6XQ5q9ZpZ CXBHsUzC6FUBJDaI2vO8+HgMkzMcrLMX7JYUqVnu4G2qKNg8US/6wdnE4TH3LIEO2or6WW burpCfC6XgoJeULzCsYu70PNGp3t+5Ly0cQauPGhPBK2GLwl3hhma9KkRU33hE2zaD5bgn 416YmkZeyC4c0dmsz30tfXAgyGYJZbAOOS7L6JedDus9Ohn5C+VQTV2iW8Bi8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794777711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yEz5KGXTFkJWhTAO2NbDaPcJN5xX25vwZCYuFaMI5qk=; b=vS9NUAIsLuhN0KwMFurTcqxyFrvbmNaU7swKvf0oQJxZzJ15G1mw2XY2Re2iHr/Yb4pRqr nTM/qSYladlkrUROcxqBSkrvcI+lzY+lVmmlXhDFW2JGeljQaAedWAfi6w3tIMAkSiWX7l DKMoN5mvWbHH1m8QIw6QX7MUPPnavqAuD5dH56jNrhjlApHRBiYNEeidrhpHZr+UA44pPT Novx92Ix4geA94pFCHGjvxqZkq3iXH93UbSw+e5HaEgYAeIKavH3dG8j3eTHxBeVwHqaH3 kno6zjW2gI3mxRNekzpIuet1JUzgiLuP53ds9ZkBfXj56ls/vtd7c3xCvXh5FQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jSP7z433wzNdc for ; Sun, 15 Nov 2026 21:21:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24a15 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 15 Nov 2026 21:21:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Abdelkader Boudih Subject: git: cf3e63b842f5 - main - asmc: clear the sensor counts in detach List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: seuros X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cf3e63b842f5e13dca93d8e218ef48892b358a71 Auto-Submitted: auto-generated Date: Sun, 15 Nov 2026 21:21:51 +0000 Message-Id: <6afa226f.24a15.76b78402@gitrepo.freebsd.org> The branch main has been updated by seuros: URL: https://cgit.FreeBSD.org/src/commit/?id=cf3e63b842f5e13dca93d8e218ef48892b358a71 commit cf3e63b842f5e13dca93d8e218ef48892b358a71 Author: Abdelkader Boudih AuthorDate: 2026-11-15 21:12:46 +0000 Commit: Abdelkader Boudih CommitDate: 2026-11-15 21:12:46 +0000 asmc: clear the sensor counts in detach The key arrays are freed but the counts were left set, leaving the softc describing freed memory. Reachable via the attach error path, which calls detach directly. MFC after: 3 days Reviewed by: ngie Differential Revision: https://reviews.freebsd.org/D61483 --- sys/dev/asmc/asmc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/dev/asmc/asmc.c b/sys/dev/asmc/asmc.c index f7635b4d7550..231006f63bb3 100644 --- a/sys/dev/asmc/asmc.c +++ b/sys/dev/asmc/asmc.c @@ -352,16 +352,21 @@ asmc_detach(device_t dev) /* Free temperature sensor key arrays */ for (int i = 0; i < sc->sc_temp_count; i++) free(sc->sc_temp_sensors[i], M_DEVBUF); + sc->sc_temp_count = 0; /* Free sensor key arrays */ for (int i = 0; i < sc->sc_voltage_count; i++) free(sc->sc_voltage_sensors[i], M_DEVBUF); + sc->sc_voltage_count = 0; for (int i = 0; i < sc->sc_current_count; i++) free(sc->sc_current_sensors[i], M_DEVBUF); + sc->sc_current_count = 0; for (int i = 0; i < sc->sc_power_count; i++) free(sc->sc_power_sensors[i], M_DEVBUF); + sc->sc_power_count = 0; for (int i = 0; i < sc->sc_light_count; i++) free(sc->sc_light_sensors[i], M_DEVBUF); + sc->sc_light_count = 0; if (sc->sc_sms_tq) { taskqueue_drain(sc->sc_sms_tq, &sc->sc_sms_task);