From nobody Sun Nov 15 17:28:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jSHz44V7Pz70kBL for ; Sun, 15 Nov 2026 17:28:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jSHz41Cp8z4bYP for ; Sun, 15 Nov 2026 17:28:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794763728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/PwL/P8zJ1+gD98A7ySQMi1sEWyZ01CMKt71yQgxQTw=; b=uJNzwdwePlk5C/r1rUShK+7RzI+1JxbXNU9N48wslHiXEMCUzm3p6GYZRDDc3MWsHCclFm LosDh/SC/K7r/yp0rBZzlrVCoHcB4coFN5avm1GCh6NTemKbcbzM9cdHxbv+EgIKQe3C+o JVRZj/+1cbM2QarhcicmZPD10wZiFfc5iZg6jkHPxBnoVWkETMRB3vOho4DVgm8QFcJ369 qcYx8id8W7IU6VYi5hdB61UOND5PoJgfkL2pLgrIn2jTnEb7MF5F6SCELS804RwntHBTbE 5hWWHDib2uXnx/fbT1NgC9yDOPUgaddQmleKlIqRHQtYb2l/ZA/3B5xH/AahJw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794763728; b=s62ODqvuCEfr+1AJ57I/vUKUpcvEzJJvEFimgl2omIUcrIpHnwfDirzVbYBhkoQ90j4H4B gde2PAojKrpt9rt58mMJchtIj5Um0Uh9CslI4APCvoc7mnhGMGwmXQ03TBvgpBXQafCj6m syt5QJc23T6EonW8HSh1+i/5rv5pwAOsP/W0B1aetc2eoCLlV3YXLKrSmtzZRfJjpicIRz YsLKfb58XMJooPE+xx3uuE3DsynHxDFs+jW3MPItJMRx5elMqvfHZkHa0vuTgpTJGg34BD 9VinZNtYd9FZVd9/RYQA4vBhOvWqAtssxELdGJxbFlSjs6o9Cck1VzerWqjxGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794763728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/PwL/P8zJ1+gD98A7ySQMi1sEWyZ01CMKt71yQgxQTw=; b=qhzl3yyRk1TXJBz5DO8EBBmhrwOgMMGxIf1Pwu6qZQOk7kteGAJhF0OT1smdGgIfGVtjtH 0w38ppeV2F5kYHy2pJ5ZbKI84l1IPKzrqch7ie7IOSc1qTxfsAhHt0NgObQ0wGP0zSSzqd LTxwir3Qm84zZ959HcbkuhTrXbnpP0tHT1ICQlmLLgBneL5FjhIQKBd4A+cKwcO2ZowVV+ OC6ab8NRP2uN+iQPhOdyIWC1GuLSZzF3A6pSwkcYLknfcYcnSAf8YTIM12Jc5XwSZHinsy Oi/3FNOOPsrm7aRDDAI5qynUsy1oVVwDXCHJTv3szLIggPyodR3BVpDRz/cQIQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jSHz40mkHzGFB for ; Sun, 15 Nov 2026 17:28:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id bb9a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 15 Nov 2026 17:28:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 7352ad7b2c0b - stable/14 - libcasper: Use pdfork() for the zygote List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 7352ad7b2c0b384b307468ccd7c0af6c1b544f41 Auto-Submitted: auto-generated Date: Sun, 15 Nov 2026 17:28:48 +0000 Message-Id: <6af9ebd0.bb9a.3f61f849@gitrepo.freebsd.org> The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=7352ad7b2c0b384b307468ccd7c0af6c1b544f41 commit 7352ad7b2c0b384b307468ccd7c0af6c1b544f41 Author: Dag-Erling Smørgrav AuthorDate: 2026-11-09 22:13:42 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-11-14 15:49:24 +0000 libcasper: Use pdfork() for the zygote Use pdfork(2) rather than fork(2) to fork the zygote, and close the descriptor when the main loop terminates. MFC after: 1 week Sponsored by: Klara, Inc. Sponsored by: Qualys, Inc. Reviewed by: oshogbo Differential Revision: https://reviews.freebsd.org/D60176 (cherry picked from commit 425e4c102f8aedfc7c439bb01d648aabac798888) --- lib/libcasper/libcasper/libcasper_service.c | 12 ++++++++---- lib/libcasper/libcasper/zygote.c | 6 +++--- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/lib/libcasper/libcasper/libcasper_service.c b/lib/libcasper/libcasper/libcasper_service.c index 6e9cd9d3d338..5ea3fa7127be 100644 --- a/lib/libcasper/libcasper/libcasper_service.c +++ b/lib/libcasper/libcasper/libcasper_service.c @@ -223,8 +223,9 @@ service_register_core(int fd) void casper_main_loop(int fd) { + int pfd, ret = 0; - if (zygote_init() < 0) + if ((pfd = zygote_init()) < 0) _exit(1); /* @@ -233,9 +234,12 @@ casper_main_loop(int fd) service_register_core(fd); while (service_have_connections()) { - if (!service_poll_dispatch()) - _exit(1); + if (!service_poll_dispatch()) { + ret = 1; + break; + } } - _exit(0); + (void)close(pfd); + _exit(ret); } diff --git a/lib/libcasper/libcasper/zygote.c b/lib/libcasper/libcasper/zygote.c index e0dcc665ee9e..c99e854cbf10 100644 --- a/lib/libcasper/libcasper/zygote.c +++ b/lib/libcasper/libcasper/zygote.c @@ -189,13 +189,13 @@ send: int zygote_init(void) { - int serrno, sp[2]; + int pfd, serrno, sp[2]; pid_t pid; if (socketpair(PF_UNIX, SOCK_STREAM | SOCK_NONBLOCK, 0, sp) == -1) return (-1); - pid = fork(); + pid = pdfork(&pfd, 0); switch (pid) { case -1: /* Failure. */ @@ -214,7 +214,7 @@ zygote_init(void) /* Parent. */ zygote_sock = sp[0]; close(sp[1]); - return (0); + return (pfd); } /* NOTREACHED */ }