From nobody Sun Nov 15 17:28:35 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jSHyr1Bfbz70jyW for ; Sun, 15 Nov 2026 17:28:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jSHyr0CBtz4bW4 for ; Sun, 15 Nov 2026 17:28:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794763716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/RHbd9hE6th8RQXdViBZwDFJpTZioa14wxy+ITd4tdE=; b=Pt4XTywf1NcXXUdsI9Hlq4GXzRgyat3Ku0+n0aqcEuN/IpxmDHusM+wrwL2rI3LHFdH6Xf CsHvdwGN6D+YQAKNKYojcvZCIUpm+e4Aamvo5dt5OyPx7ytiD8Il0/D6ikwSJ3ZcHxd6x7 +GDGILgpTz5zNbAZtrr7UQ57O71BwFpohX+UWb883hwKoXeKyHjXRSUNa2OcMC3Mrg50MR BoyCsQs32sRBYLINZO0FNSNwlB8+zcniFkfDcOrNkNNmMbn+v+u3LmJqemyBDl6pspa6No cfFDCE42xOFqEpw5FWPltDCLoieSl79INCnXZhjBzDNvRinCfx+NV0sbhrcR0g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794763716; b=xYgm8cYxGjy3bYmRWzKInqqMt388DPMSNzbyoUBSJBNePl0kLsjIs+1iIzwlVt1iij8o4d 88A85oHZQ51XBKXrgXEEBrNmd6Iy2kpKrGG+9DfuYhEXPtjCAh+hFQSqzzgspZMURJbp+W GWEcPUTzGpLC4jF678DGEt/tWKi/8Vusqu5vifkIRd/e1XWIhe27O0VqBSunQeuCPr/Es8 3l3dhFtXExR3SzQoyXoGv/WZ/CGNXAFnMLAw+ZApbDYKFwP6WjiS9hQON1ub+jK/IX1bke 6sPIeI0fK5UZXVFwcYXJ6OO4bLqGQyF2pJg2jGP5JiTAux/XzzJbtOxAhBdHyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794763716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/RHbd9hE6th8RQXdViBZwDFJpTZioa14wxy+ITd4tdE=; b=Wib5ARjltEuiIsAGctMiPigLUWB8nBUaTzkWMHGYad7I9qcE4XvmsMRAkO3grH9a9Kcac+ BZYi42p9EGy0QtC/YdKnXQyN7VVYpJ5hkVrRviheuDfwmGfofeedGdEiW0y8g2qSjDl0Ok sbym6PoC84HQltMdkd8AQfcv2//N2GcTny4sMURhsR0ShxlQ+Kf2O4hxClw7AZtTLLoXjo BF35GHwz/w1huPnN7a3KGMuhD4h2xxO1IZI9Ml+qjgJJVEUcHGtfz/RyyTRbGifP2vLoFy 8vm4N3Y7fbwtKaPqqkMDCZARRTMmcV6y/VnRXJFrtpMRrat+ZT4XqbUuVc9qKg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jSHyq6zT3zGTC for ; Sun, 15 Nov 2026 17:28:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id c900 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 15 Nov 2026 17:28:35 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 0c9ae19f02b1 - stable/15 - libcasper: Use pdfork() for the zygote List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 0c9ae19f02b179b3649e6aa5208a3e1a8a2097df Auto-Submitted: auto-generated Date: Sun, 15 Nov 2026 17:28:35 +0000 Message-Id: <6af9ebc3.c900.74d59fa2@gitrepo.freebsd.org> The branch stable/15 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=0c9ae19f02b179b3649e6aa5208a3e1a8a2097df commit 0c9ae19f02b179b3649e6aa5208a3e1a8a2097df Author: Dag-Erling Smørgrav AuthorDate: 2026-11-09 22:13:42 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-11-14 15:49:21 +0000 libcasper: Use pdfork() for the zygote Use pdfork(2) rather than fork(2) to fork the zygote, and close the descriptor when the main loop terminates. MFC after: 1 week Sponsored by: Klara, Inc. Sponsored by: Qualys, Inc. Reviewed by: oshogbo Differential Revision: https://reviews.freebsd.org/D60176 (cherry picked from commit 425e4c102f8aedfc7c439bb01d648aabac798888) libcasper: Use casper_pdfork() Fixes: 425e4c102f8a ("libcasper: Use pdfork() for the zygote") (cherry picked from commit d0fd70983b6b93d4a6a4671457619eb34786b38d) --- lib/libcasper/libcasper/libcasper_service.c | 12 ++++++++---- lib/libcasper/libcasper/zygote.c | 6 +++--- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/lib/libcasper/libcasper/libcasper_service.c b/lib/libcasper/libcasper/libcasper_service.c index b951de58d229..402a266bce68 100644 --- a/lib/libcasper/libcasper/libcasper_service.c +++ b/lib/libcasper/libcasper/libcasper_service.c @@ -222,8 +222,9 @@ service_register_core(int fd) void casper_main_loop(int fd) { + int pfd, ret = 0; - if (zygote_init() < 0) + if ((pfd = zygote_init()) < 0) _exit(1); /* @@ -232,9 +233,12 @@ casper_main_loop(int fd) service_register_core(fd); while (service_have_connections()) { - if (!service_poll_dispatch()) - _exit(1); + if (!service_poll_dispatch()) { + ret = 1; + break; + } } - _exit(0); + (void)close(pfd); + _exit(ret); } diff --git a/lib/libcasper/libcasper/zygote.c b/lib/libcasper/libcasper/zygote.c index 574d80a16b01..a1caaadc2d7e 100644 --- a/lib/libcasper/libcasper/zygote.c +++ b/lib/libcasper/libcasper/zygote.c @@ -188,13 +188,13 @@ send: int zygote_init(void) { - int serrno, sp[2]; + int pfd, serrno, sp[2]; pid_t pid; if (socketpair(PF_UNIX, SOCK_STREAM | SOCK_NONBLOCK, 0, sp) == -1) return (-1); - pid = fork(); + pid = casper_pdfork(&pfd); switch (pid) { case -1: /* Failure. */ @@ -213,7 +213,7 @@ zygote_init(void) /* Parent. */ zygote_sock = sp[0]; close(sp[1]); - return (0); + return (pfd); } /* NOTREACHED */ }