From nobody Sun Nov 15 09:02:59 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jS4lS3lYqz70VF1; Sun, 15 Nov 2026 09:03:00 +0000 (UTC) (envelope-from mmel@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jS4lS1wHHz4DVr; Sun, 15 Nov 2026 09:03:00 +0000 (UTC) (envelope-from mmel@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794733380; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FHauAY1c7dwXZ1d6LwJWqzWmYwYnOvqVpv/53yatdi8=; b=EYVpZ1tQhWP3blWMYlC+uW3sBuoaUdwdGUROOi9Jx5DF81zXdcvAgQHVswFJGlIjX9shQa KOMR3WH9x3mzndsOV/wN6OaFEv2NuxaYiTtk+ys50+Db5GJDntCo6RgMhQC2JZU5/cC2oQ R6O5GYM/jQtJd19/tUCHQjJyCiDc9IWPfbcxbu/6TK+SHh1+D2BtOeAIX/WcPr4UOra5hN SFQk8TRL4kE13ON63SHqFKQpD61hhGsMJ0ZBxZNkbmGUwW5IXVjT3Pe5Ryn/sugmIPFUFt MS/DxoUdSTz+OwO45VxPzXG2jjkntvpVTw3zkYkmJFZWzyup7/1DrNReYY50+Q== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794733380; b=GIO487JBJpCp180eH4pcrA7u/Rx5GWHwjb4FOAAwavjd4i/UF7hLjBbDTjGcBrDpmS6VfE uN5/T8eATYF3eBZ6VZ8HXfB4pkXBPtnDqY/dLPjWw/Mv5FvXw1xxr9dUiNCuKdDau5CebW 9PQc5adWu9Y1nk/rp4PN0V6Z8f4zNHAQGqPUxy95ekETthPni59lebWoZHA16dXqyvAJhM MFHqHuVghGBEgfjlPgqadwo/5cJ5z7+tcIU5A6bRtGkX/WfIJpVv0TL7Nx/oW4grdSsQFC QImsbI2gJ2EaVDNOKNB6yD7KrEMH1gYi3O8bJIJajNPB2hmmq/AMNi/iWSjTuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794733380; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FHauAY1c7dwXZ1d6LwJWqzWmYwYnOvqVpv/53yatdi8=; b=Bgju8TDy7KLzxJkceo/VUWQ/txr7FXOPgot8ahpJl6ITmWik1BvWVpBQRIaTfh7vHthPAj 8jZ2a9vNRIk4Jkb2/E6VmlEYmFj6aGIVLVgHCpj6LQ+rOvZ0HfesJINAHUpgfkqmjMwcLy geatv/8CFV4QcZl9wqZL1PaWUIdW012sBrC3Efc6/rUrOuTtvDeeq/IbEHnxOkOQgF711T OU3t1u+PwnUhqYhJC4YIB6ohMx/DqYn+YDopgmSQcq9bC20G3OfKVtARzCXBELgMi0Jq5d wQjq9xllBPu6axxEoLy6oPJ1RnyXuhfdF/OAo2M+8SoCdxCjDNEA4WHMrs0b4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2001:67c:14a0:5fe0:482f:defd:1b0e:6310] (unknown [IPv6:2001:67c:14a0:5fe0:482f:defd:1b0e:6310]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mmel/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4jS4lR5GyRz1B9N; Sun, 15 Nov 2026 09:02:59 +0000 (UTC) (envelope-from mmel@FreeBSD.org) Message-ID: <270cf888-f3ed-4bb6-b2de-812532a602b3@FreeBSD.org> Date: Sun, 15 Nov 2026 10:02:59 +0100 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 010f31a79c43 - main - regulator: Do not delay when setting the voltage failed To: Emmanuel Vadot , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <6af5878e.1d9d3.39d1342c@gitrepo.freebsd.org> Content-Language: cs Reply-To: mmel@FreeBSD.org From: Michal Meloun In-Reply-To: <6af5878e.1d9d3.39d1342c@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12. 11. 2026 10:31, Emmanuel Vadot wrote: > The branch main has been updated by manu: > > URL: https://cgit.FreeBSD.org/src/commit/?id=010f31a79c4313344a05df768ea31429ec7a9fd6 > > commit 010f31a79c4313344a05df768ea31429ec7a9fd6 > Author: Emmanuel Vadot > AuthorDate: 2026-11-12 08:44:24 +0000 > Commit: Emmanuel Vadot > CommitDate: 2026-11-12 09:31:23 +0000 > > regulator: Do not delay when setting the voltage failed > > regnode_set_voltage_checked() called regnode_delay() with the delay > returned by the driver even when REGNODE_SET_VOLTAGE() failed. A driver > does not have to set it on error, so the delay could be a random value > from the stack. Only wait when the voltage was set, like > regnode_set_voltage() does. I think this change is wrong. A failed operation may legitimately want to use delay() to stabilise the system state after an internal operation, even if it fails. Each driver should be responsible for setting udelay to a defined value, even in the event of a failure. Of course, we could help by setting udelay to 0 before REGNODE_SET_VOLTAGE() is called. Michal > > Reported by: llm-postcr > Tested on: A64 > --- > sys/dev/regulator/regulator.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sys/dev/regulator/regulator.c b/sys/dev/regulator/regulator.c > index 6b49c6e93aae..b59710b8aef0 100644 > --- a/sys/dev/regulator/regulator.c > +++ b/sys/dev/regulator/regulator.c > @@ -827,7 +827,8 @@ regnode_set_voltage_checked(struct regnode *regnode, struct regulator *reg, > max_uvolt = all_max_uvolt; > > rv = REGNODE_SET_VOLTAGE(regnode, min_uvolt, max_uvolt, &udelay); > - regnode_delay(udelay); > + if (rv == 0) > + regnode_delay(udelay); > REGNODE_UNLOCK(regnode); > return (rv); > } >