From nobody Sat Nov 14 16:03:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jRf745H0Lz71KJl for ; Sat, 14 Nov 2026 16:03:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jRf744SKpz4YqY for ; Sat, 14 Nov 2026 16:03:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794672208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GC/6hQczfHXbOMWi7VHvmv/EyFqMihShv7ca1A6eYvQ=; b=v98A9epLH6lrNYchFe852DDss1YwOhjRCsKRxq2U76WkAYFenP4d3o2HprMPwMpcAN1DjG CRk7uaW/EBobngzgbwsL57WnBbsgzYjtCd5N+5XlFYlbcCl7Ys7qzS9fOV57gNIA6NQjF+ c0xAnZf+gz95oXzRNHSnuzYcGf6n3TkKqErUJi6HybONmsHNru1Fw2BJaAfjKWXkCtrVrF lKMDC+9638XHNTRHJWS8aAcN3KAwC4cwP1e9/qjz1RXqKDdOf8mqqshKQ8/pwQ6IdusQ59 Rx2F0XyDo3+IaEFiW8pTv9FjCsHmzyh5Lu/QbL3AGmPwlGAyGL7jrgpwU77GQQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794672208; b=prQVTW71w45K8zKy3RNnfpIiw9sKHW6dmKoO3htnOMyZ/NzbKJXJgRv4XDCWHvXrCpXn2a HFst4+plL2PTjEKyMKy6lmFrvXkCX3MZGufwSYMB9T5sVGBFifrDKUEa2QqTPSqVxWFcyl 3Vibw2/gq+5ekMBxp51B30HbHQ4YRmXEO+mWpGGokeaBh3Izv1FiziNQFePZBAOmBa5Re4 vlrBz+kopIW24jXCDhumGTbWVN7sDzZkLaY0ZXZv7BL4Ma6r5FpBGFCciLuTQ3OUrU6Z0t vpDZejgxBZ6hV05EPRVEvZDE6PvipN+/YZvJKcSQTEVqlv2dJVOjl7C62Z9Sog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794672208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GC/6hQczfHXbOMWi7VHvmv/EyFqMihShv7ca1A6eYvQ=; b=J8TgOUN4E3X66LRDFGb+xaDitL1vtESRdZyJmmWZJWvUOXv4dfg01cHEh/oQACWcOY7M9N t5HZIeLrX+YSPsy2UeDfH39snGROTJAkdS4QywFyHny20Cj4X+mPx9NQNM/QEEp7TuUhaf Ui+hsQnebsD73VM1uov3ZyamjP6UQz1ZrRpS/CaY6ZZ8gbv43iTORyAg0WK86mr9bnogQE vNKWHGM4jd5+iU9KHXyrcUK6ZJ47PE9l+aXaDIkvF7YmwHFS6LcaB/svcGQ2UHqbaATXd2 fqJJ6RXKwxRoh3kt7RpwWKSUoIW8n+9fwoTL7h0i2hLnlsfaj5uzKjKBIDeERQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jRf7447CfzR8g for ; Sat, 14 Nov 2026 16:03:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 15f3b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 14 Nov 2026 16:03:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 81dab94a5452 - main - acpi_pci_link: Ignore tunables with negative values List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 81dab94a5452f996a063bdba2103eda4aa32b3d1 Auto-Submitted: auto-generated Date: Sat, 14 Nov 2026 16:03:28 +0000 Message-Id: <6af88650.15f3b.30a42f60@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=81dab94a5452f996a063bdba2103eda4aa32b3d1 commit 81dab94a5452f996a063bdba2103eda4aa32b3d1 Author: John Baldwin AuthorDate: 2026-11-14 16:02:38 +0000 Commit: John Baldwin CommitDate: 2026-11-14 16:02:38 +0000 acpi_pci_link: Ignore tunables with negative values IRQ values are unsigned and negative values do not make sense. The invalid IRQ value (255) is already ignored, so ignoring other invalid values is consistent with that behavior. Reported by: cperciva --- sys/dev/acpica/acpi_pci_link.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/dev/acpica/acpi_pci_link.c b/sys/dev/acpica/acpi_pci_link.c index d9807876c443..cb6adee87252 100644 --- a/sys/dev/acpica/acpi_pci_link.c +++ b/sys/dev/acpica/acpi_pci_link.c @@ -974,7 +974,8 @@ acpi_pci_link_choose_irq(device_t dev, struct link *link) sizeof(link_name)))) { snprintf(tunable_buffer, sizeof(tunable_buffer), "hw.pci.link.%s.%d.irq", link_name, link->l_res_index); - if (getenv_int(tunable_buffer, &i) && PCI_INTERRUPT_VALID(i)) { + if (getenv_int(tunable_buffer, &i) && i >= 0 && + PCI_INTERRUPT_VALID(i)) { if (!link_valid_irq(link, i)) device_printf(dev, "Warning, IRQ %d is not listed as valid\n", @@ -983,7 +984,8 @@ acpi_pci_link_choose_irq(device_t dev, struct link *link) } snprintf(tunable_buffer, sizeof(tunable_buffer), "hw.pci.link.%s.irq", link_name); - if (getenv_int(tunable_buffer, &i) && PCI_INTERRUPT_VALID(i)) { + if (getenv_int(tunable_buffer, &i) && i >= 0 && + PCI_INTERRUPT_VALID(i)) { if (!link_valid_irq(link, i)) device_printf(dev, "Warning, IRQ %d is not listed as valid\n",