From nobody Fri Nov 13 22:07:50 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jRBFz0kBfz6yC8X for ; Fri, 13 Nov 2026 22:07:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jRBFy6fBlz3KH2 for ; Fri, 13 Nov 2026 22:07:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794607670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/As/7zOyx66tynS6O/bMDm7607jCYFrxliOajavXN7M=; b=iIwXRjCvQMWf4mXeioPyNdaIkd33xkJXCnX+AKuuq7YS66hZoRhGTUkNYGnOel/TBmWy1F P998dhVA4Icbt80eCMZB8jxr7JckdlNIq2i1rBJyPKzWd2LCLZHzetF1hKYWCnc7YKyCmO 3JOIR8/+8EgsHVsV+ZMUp4d+y1VueD0nA8Qk9oa8LaRjdHplKG9dqwUbl1PXioWY5l7WHI k2c99BOrUtfg5UmpdXM2yl1ss2C+kVJx3lBHE+wjJYbsh5eHjWtv7P5ePSM8dlA7HT+APZ Xb7HB0u1xtfgjIwEirkaSs3WYISK0wsnyxKS4mUKYUAJhgx5AbEU5WBGnmJYow== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794607670; b=FqMq1Bl5f6qGmAPGcjPtjoapdP5Qk77U9BOVCTHcbf/fOqR1QD8ASrCI0PjLVgblomdtci oOinsVEWi14jSNXyoYo27Vfcfe9oIBrV0MhAFojq7sTcefxSu7qFQXoxSo9Vbg/B1ZCaQ1 KBNna/Wo/5+fxdBbPkL6RnMGa7cWpmhcSQa0yV2lD38JSseidCiNe9ILdL/oMJr/yHgkFZ fk4ZiHOZ4dG3dL05gbjvUMDf9GF+NQqCvFgzaDSshZOwyEPhtz/ene+0QBDgpED4oI5qmt x4HNrKLYR6nCfYypmDZwofvDwoIW+8wsB6fm89kLQ5QFEErvc525aTMkbLtolA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794607670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/As/7zOyx66tynS6O/bMDm7607jCYFrxliOajavXN7M=; b=p7hCS3uqcPu7Xu/OuCRqKDVpS3wh/kgv2n6gD3Msfcn4yu7kWyl+NAmUlgaDiucztiWpap 81a5+yD8lyOb58D/cXLgVjtE0JioM6vmgoco5HQxk7bu+bBCcVG6U6YEsyL04+742dnYfY zQmvbdncphRDJLwfXebEqSo9N19e/RHIcgWMWIXFjbD5DqZnXsXXvwhT1TlVhlUq4VOFju x+OFvSF4JN/5g1Ybm7Ui5c7M0HAlB2jM+AP6iK1BY5dWpmmNyLwsqJXQmkIVWFe45kmW3h oMOBK1AvolOmWubdFBGQbIr+qZcaN7wzvfv75LFpxgvv67/keMlDUouNaG81hw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jRBFy6KJpztYq for ; Fri, 13 Nov 2026 22:07:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id c37d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 13 Nov 2026 22:07:50 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Osvaldo Janeri Filho From: Mark Johnston Subject: git: 0768a403252b - stable/14 - inetd: use snprintf() in inetd_setproctitle() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0768a403252b078b6e60b6872a9d429b173e0509 Auto-Submitted: auto-generated Date: Fri, 13 Nov 2026 22:07:50 +0000 Message-Id: <6af78a36.c37d.1b3b3baa@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=0768a403252b078b6e60b6872a9d429b173e0509 commit 0768a403252b078b6e60b6872a9d429b173e0509 Author: Osvaldo Janeri Filho AuthorDate: 2026-10-20 15:40:28 +0000 Commit: Mark Johnston CommitDate: 2026-11-13 22:07:31 +0000 inetd: use snprintf() in inetd_setproctitle() inetd_setproctitle() formats se_service (the service name taken verbatim from inetd.conf) and the peer address into an 80-byte buffer with sprintf(). A long service name can overflow it. Bound both calls with snprintf(). MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D60879 (cherry picked from commit 9ab2bf0f4296e8bfafe4dc70f2f200265e6933bd) --- usr.sbin/inetd/inetd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/inetd/inetd.c b/usr.sbin/inetd/inetd.c index dca67012251b..83a650777aeb 100644 --- a/usr.sbin/inetd/inetd.c +++ b/usr.sbin/inetd/inetd.c @@ -2102,9 +2102,9 @@ inetd_setproctitle(const char *a, int s) if (getpeername(s, (struct sockaddr *)&ss, &size) == 0) { getnameinfo((struct sockaddr *)&ss, size, pbuf, sizeof(pbuf), NULL, 0, NI_NUMERICHOST); - (void) sprintf(buf, "%s [%s]", a, pbuf); + (void) snprintf(buf, sizeof(buf), "%s [%s]", a, pbuf); } else - (void) sprintf(buf, "%s", a); + (void) snprintf(buf, sizeof(buf), "%s", a); setproctitle("%s", buf); }