From nobody Fri Nov 13 18:49:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jR5sX02Z0z714gh for ; Fri, 13 Nov 2026 18:49:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jR5sW4tDWz4TMr for ; Fri, 13 Nov 2026 18:49:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794595791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B7dZpMDhEex2bVdpEFZE/eOjDsxAz8tcbEJVFaLiT2w=; b=l+fkqfbAh655AGNDpoJQXfdCnPIQGvkYnp0MnD3zEeZ0YaMUhhihTb6fQs8q4B/C0iduEU w3mQcXKbypLwkyyNpeqTk3OFusSlV0nn8Py/eouZLsbGE6xt5XIN+WcJgc0O/xEBqw2qwR m2eDpFjqxQeJDl11XK14C+oHSC4C0pdX/ZUtket1khNufkHQu6ioWbC7enNdMXeIDEQWWn WNqnma9WuWopY8GY1vunEPO16nw6rGviTlsPItIVP81LcloN6oaVGUjyAZz+UDbh2U045v gTT+wfHyP9UYMFYkkf5duH6+XS7XW1BYTyWwiei9QVfPp42cfnusAUsJS6ybJQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794595791; b=b7bE7srLWDHtyKJqLzTEEBcvYfmOUcbQR+VmbVDkdjYTnGmeODOqjLxRdWUs3ODM1Z8RM9 PBMCzqWZhuWlVlOEHHizEfqXk0kt+aHjSxjE+GzccZZ8Fy75aeXvplpQL5zfoVIYSAuWTF fHZQlNGE9TVIckIRP1qLZDRuPsMicc0HtekIDpN2iCNFnr8eNceJFUzX/R3OIr+ucJypH/ u9etAwP/cnjxfTmT8XJUSMIc+yDBDkOylpYvviF35rqrxDiKCha94Bw2gYduMA7omcQZHF QTaUCxkjxX2Omj/xZUWvRWEtRPzR9R9pn8QsO3t2EZLtRKoWXx1/+6lwU2WdwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794595791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B7dZpMDhEex2bVdpEFZE/eOjDsxAz8tcbEJVFaLiT2w=; b=k2nHsiRcAu0TQ6C7uaX42CpKDfROnX0tdqLR6INGJFp3jvYyRPj530GgbYN7mQuT7YzMaF Jok5K5B8P7HBf17eGeexHcPW9V5L5le1XpjhDE/uvBcVwzTyazjbHUE0JkoE2cwFqHFrs8 pd8I0P5wuhm6XmsdEmoGupe/rGgMcZL4sH1f5k0k2IrY0UssMwxKWyZpIi4KgGfv7J17Ws nc3qNR1kyxRX3YxH4u3KorgJDZzwY2oz6X1PCSXpV2HwSRcFdr4EpazSWikX2AwmK6BOIf nAh5ROZUKPYr4xxg63nStXbgBTLArlmLhpZWmZ7SPhzA8YRbeATEDnsd8c9kjQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jR5sW4YX1zncx for ; Fri, 13 Nov 2026 18:49:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f835 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 13 Nov 2026 18:49:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 067161c31fe8 - main - acpi: Tasks: Ensure sane values for number of tasks and threads List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 067161c31fe8eed8a046ba3f820748cf9d6627c1 Auto-Submitted: auto-generated Date: Fri, 13 Nov 2026 18:49:51 +0000 Message-Id: <6af75bcf.1f835.6fb52ef0@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=067161c31fe8eed8a046ba3f820748cf9d6627c1 commit 067161c31fe8eed8a046ba3f820748cf9d6627c1 Author: Olivier Certner AuthorDate: 2026-10-01 13:57:57 +0000 Commit: Olivier Certner CommitDate: 2026-11-13 18:32:31 +0000 acpi: Tasks: Ensure sane values for number of tasks and threads Make sure that these are set to sane values even on silly tunables: - There must be at least one thread to process the 'acpi_taskq'. - Use the ACPI_MAX_TASKS default when a negative number of tasks was specified. This avoids common pilot errors causing a bogus huge memory allocation for acpi_tasks[]. Reviewed by: obiwac (older version) Differential Revision: https://reviews.freebsd.org/D60373 --- sys/dev/acpica/Osd/OsdSchedule.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sys/dev/acpica/Osd/OsdSchedule.c b/sys/dev/acpica/Osd/OsdSchedule.c index 957fe3e69a7c..badb15dd009f 100644 --- a/sys/dev/acpica/Osd/OsdSchedule.c +++ b/sys/dev/acpica/Osd/OsdSchedule.c @@ -94,6 +94,11 @@ static int acpi_taskq_started; static void acpi_task_init(void *arg) { + if (acpi_max_tasks < 0) { + acpi_max_tasks = ACPI_MAX_TASKS; + printf("ACPI: Negative number of tasks, defaulting to %d.\n", + acpi_max_tasks); + } acpi_tasks = malloc(sizeof(*acpi_tasks) * acpi_max_tasks, M_ACPITASK, M_WAITOK | M_ZERO); @@ -111,7 +116,12 @@ acpi_taskq_init(void *arg) acpi_taskq = taskqueue_create_fast("acpi_task", M_WAITOK, &taskqueue_thread_enqueue, &acpi_taskq); + + if (acpi_max_threads < 1) + acpi_max_threads = 1; + taskqueue_start_threads(&acpi_taskq, acpi_max_threads, PWAIT, "acpi_task"); + if (acpi_task_count > 0) { if (bootverbose) printf("AcpiOsExecute: enqueue %d pending tasks\n",